Tracing: Use base::span in TracePacketTokenizer::Parse [chromium/src : main]
0 views
Skip to first unread message
kelsen liu (Gerrit)
Oct 21, 2025, 12:06:49 PMOct 21
to Eric Seckler, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Eric Seckler
kelsen liu added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Eric Seckler
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Eric Seckler (Gerrit)
Oct 21, 2025, 12:31:07 PMOct 21
to kelsen liu, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from kelsen liu
Eric Seckler voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- kelsen liu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
kelsen liu (Gerrit)
Oct 22, 2025, 2:43:07 AMOct 22
to Jinsuk Kim, Eric Seckler, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Jinsuk Kim
kelsen liu added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Attention is currently required from:
- Jinsuk Kim
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jinsuk Kim (Gerrit)
Oct 22, 2025, 11:04:17 AMOct 22
to kelsen liu, Eric Seckler, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from kelsen liu
Jinsuk Kim voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- kelsen liu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
kelsen liu (Gerrit)
Oct 22, 2025, 11:07:58 AMOct 22
to Jinsuk Kim, Eric Seckler, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
kelsen liu voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
kelsen liu (Gerrit)
Oct 22, 2025, 11:08:24 AMOct 22
to Jinsuk Kim, Eric Seckler, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
kelsen liu added 1 comment![]( "Open in Gerrit")
Patchset-level comments
kelsen liu . resolved
Thank you！
Chromium LUCI CQ (Gerrit)
Oct 22, 2025, 12:41:53 PMOct 22
to kelsen liu, Jinsuk Kim, Eric Seckler, AyeAye, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Tracing: Use base::span in TracePacketTokenizer::Parse
This CL refactors the `Parse` method in `TracePacketTokenizer` to use
`base::span<const uint8_t>` instead of a raw pointer and size pair.
No behavior changes.
Bug: 40285824
Change-Id: I72991d58b80cc0f0c857331e7b1159c63600a1a2
Commit-Queue: kelsen liu <kels...@chromium.org>
Reviewed-by: Eric Seckler <esec...@chromium.org>
Reviewed-by: Jinsuk Kim <jins...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1533690}
Files:
- M content/browser/android/tracing_controller_android.cc
- M content/browser/tracing/startup_tracing_controller.cc
- M services/tracing/public/cpp/perfetto/perfetto_session.cc
- M services/tracing/public/cpp/perfetto/perfetto_tracing_backend.cc
- M services/tracing/public/cpp/perfetto/trace_packet_tokenizer.cc
- M services/tracing/public/cpp/perfetto/trace_packet_tokenizer.h
- M services/tracing/public/cpp/perfetto/trace_packet_tokenizer_unittest.cc
- M services/tracing/tracing_service_unittest.cc
Change size: M
Delta: 8 files changed, 35 insertions(+), 34 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Eric Seckler, +1 by Jinsuk Kim
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages