Convert to UNSAFE_TODO in components [chromium/src : main]

0 views

Skip to first unread message

Arthur Sonzogni (Gerrit)

unread,

Nov 7, 2025, 11:21:03 AM (2 days ago) Nov 7

to Enterprise Policy Reviews, Zijie He, chromium...@chromium.org, spang...@chromium.org, cc-...@chromium.org, fuchsia...@chromium.org, tmartino+tran...@chromium.org, security-...@chromium.org, tracing...@chromium.org, yhanada+...@chromium.org, feature-me...@chromium.org, wfh+...@chromium.org, ios-r...@chromium.org, crostin...@chromium.org, performance-m...@chromium.org, asvitki...@chromium.org, subresource-f...@chromium.org, grt+...@chromium.org, mfoltz+wa...@chromium.org, net-r...@chromium.org, ryanchu...@chromium.org, mpdento...@chromium.org, penghu...@chromium.org, vasilii+watchlis...@chromium.org, fuzzin...@chromium.org, gcasto+w...@chromium.org, chromiumme...@microsoft.com, glazuno...@chromium.org, dougste...@chromium.org, mac-r...@chromium.org, language...@chromium.org

Arthur Sonzogni has uploaded the change for review

Commit message

Convert to UNSAFE_TODO in components

This is an automated #cleanup patch using the [Script] below.

We are migrating from coarse-grained file-level suppression (#pragma
allow_unsafe_buffers) to granular, expression-level markers
(UNSAFE_TODO()). The pragma disables safety checks for an entire file,
whereas UNSAFE_TODO() isolates specific potentially unsafe operations, allowing
the rest of the file to be enforced as safe.

This CL was uploaded by an experimental version of git cl split
(https://crbug.com/389069356).

Script: https://docs.google.com/document/d/1ORQGBNn2R-CEvNbDTjRd-GrOBOFlCxIHdcvSUA_EhR4/edit?usp=sharing

AX-Relnotes: N/A

Cleanup: This is an automated #cleanup.

Bug: 409340989

Change-Id: I3781a1241a6ffb10114e28b4a74b051124a3fb03

Change diff

Change information

Files:

M components/allocation_recorder/crash_handler/allocation_recorder_holder.cc
M components/allocation_recorder/crash_handler/allocation_recorder_holder_unittest.cc
M components/android_autofill/browser/android_autofill_features.cc
M components/apdu/apdu_fuzzer.cc
M components/bookmarks/browser/bookmark_node_data_read_fuzzer.cc
M components/browser_ui/photo_picker/android/features.cc
M components/cbor/reader_fuzzer.cc
M components/chromeos_camera/jpeg_encode_accelerator_unittest.cc
M components/chromeos_camera/mjpeg_decode_accelerator_unittest.cc
M components/crash/content/browser/crash_handler_host_linux.cc
M components/crash/core/app/breakpad_linux.cc
M components/crash/core/app/crash_export_thunks.cc
M components/crash/core/app/crashpad.cc
M components/crash/core/app/crashpad_android.cc
M components/crash/core/app/crashpad_ios_unittest.mm
M components/crash/core/app/fallback_crash_handler_launcher_win.cc
M components/crash/core/app/minidump_with_crashpad_info.cc
M components/crash/core/common/crash_key_breakpad.cc
M components/crash/core/common/objc_zombie.mm
M components/cronet/android/cronet_bidirectional_stream_adapter.cc
M components/cronet/android/io_buffer_with_byte_buffer.cc
M components/cronet/android/test/test_server/embedded_test_server_adapter.cc
M components/desks_storage/core/local_desk_data_manager.cc
M components/device_signals/core/common/mac/platform_utils_mac.mm
M components/download/internal/common/in_memory_download_file.cc
M components/embedder_support/android/util/input_stream.cc
M components/embedder_support/android/util/input_stream_unittest.cc
M components/exo/data_offer_unittest.cc
M components/exo/data_source.cc
M components/exo/shell_surface_unittest.cc
M components/exo/surface_tree_host_unittest.cc
M components/exo/wayland/client_tracker.cc
M components/exo/wayland/clients/yuv.cc
M components/exo/wayland/server_unittest.cc
M components/exo/wayland/surface_augmenter.cc
M components/exo/wayland/test/integration/buffer_checker_test.cc
M components/exo/wayland/test/wayland_server_test.cc
M components/exo/wayland/wayland_dmabuf_feedback_manager.cc
M components/exo/wayland/wayland_keyboard_delegate.cc
M components/exo/wayland/wayland_protocol_logger.cc
M components/exo/wayland/zcr_gaming_input.cc
M components/exo/wayland/zcr_keyboard_configuration.cc
M components/exo/wayland/zcr_notification_shell.cc
M components/exo/wm_helper.cc
M components/external_intents/android/external_intents_features.cc
M components/feedback/redaction_tool/ip_address.h
M components/feedback/redaction_tool/url_canon.h
M components/feedback/redaction_tool/url_canon_internal.h
M components/gwp_asan/client/guarded_page_allocator_unittest.cc
M components/gwp_asan/client/sampling_malloc_shims_unittest.cc
M components/gwp_asan/common/extreme_lightweight_detector_util.h
M components/gwp_asan/common/pack_stack_trace_differential_fuzzer.cc
M components/gwp_asan/common/pack_stack_trace_unpack_fuzzer.cc
M components/gwp_asan/crash_handler/crash_analyzer.cc
M components/js_injection/renderer/js_binding.cc
M components/language/ios/browser/language_detection_javascript_unittest.mm
M components/media_router/common/providers/cast/certificate/net_trust_store.h
M components/media_router/common/providers/cast/channel/cast_framer_ingest_fuzzer.cc
M components/media_router/common/providers/cast/channel/enum_table.h
M components/metal_util/hdr_copier_layer.mm
M components/metrics/call_stacks/stack_sampling_recorder_unittest.cc
M components/os_crypt/async/browser/dpapi_key_provider.cc
M components/ownership/owner_key_util_impl_unittest.cc
M components/page_info/android/page_info_features.cc
M components/paint_preview/player/android/javatests/paint_preview_test_service.cc
M components/password_manager/core/browser/leak_detection/fuzzer/cypher_decrypt_fuzzer.cc
M components/password_manager/core/browser/leak_detection/fuzzer/cypher_encrypt_with_key_fuzzer.cc
M components/password_manager/core/common/passwords_directory_util_ios_unittest.cc
M components/password_manager/ios/account_select_fill_data_unittest.cc
M components/performance_manager/public/voting/voting.h
M components/policy/core/common/registry_dict.cc
M components/power_metrics/energy_impact_mac_unittest.mm
M components/power_metrics/energy_metrics_provider_win.cc
M components/power_metrics/resource_coalition_mac.mm
M components/power_metrics/resource_coalition_mac_unittest.mm
M components/segmentation_platform/embedder/home_modules/home_modules_card_registry.cc
M components/spellcheck/browser/spellcheck_host_metrics_unittest.cc
M components/spellcheck/browser/spellcheck_platform_mac_unittest.cc
M components/startup_metric_utils/browser/startup_metric_utils.cc
M components/subresource_filter/core/common/indexed_ruleset.h
M components/sync_device_info/local_device_info_util_fuchsia.cc
M components/system_cpu/host_processor_info_scanner.cc
M components/tracing/common/graphics_memory_dump_provider_android.cc
M components/url_pattern_index/string_splitter.h
M components/viz/service/display_embedder/software_output_device_mac.cc
M components/webui/flags/flags_state.cc
M components/wifi/network_properties.cc
M components/wifi/wifi_service_win.cc
M components/zucchini/buffer_sink.h
M components/zucchini/buffer_source.h
M components/zucchini/buffer_view.h
M components/zucchini/exception_filter_helper_win_unittest.cc
M components/zucchini/fuzzers/disassembler_dex_fuzzer.cc
M components/zucchini/fuzzers/disassembler_elf_fuzzer.cc
M components/zucchini/fuzzers/disassembler_win32_fuzzer.cc
M components/zucchini/io_utils.h
M components/zucchini/patch_utils.h
M components/zucchini/rel32_utils.h
M components/zucchini/suffix_array.h
M components/zucchini/zucchini_integration.cc

Change size: XL

Delta: 100 files changed, 379 insertions(+), 748 deletions(-)

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages