[tracing] Migrate legacy async macros in various folders [chromium/src : main]

0 views
Skip to first unread message

Etienne Pierre-Doray (Gerrit)

unread,
Dec 19, 2025, 10:03:28 AM (yesterday) Dec 19
to Francois Pierre Doray, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, spang...@chromium.org, android-web...@chromium.org, chrome-gr...@chromium.org, feature-v...@chromium.org, halliwe...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, storage...@chromium.org
Attention needed from Francois Pierre Doray

Etienne Pierre-Doray added 1 comment

Patchset-level comments
File-level comment, Patchset 5 (Latest):
Etienne Pierre-Doray . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:
  • Francois Pierre Doray
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: If26545b28c180fc831b0d6e0c87b45a5474f1c93
Gerrit-Change-Number: 7254727
Gerrit-PatchSet: 5
Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
Gerrit-Attention: Francois Pierre Doray <fdo...@chromium.org>
Gerrit-Comment-Date: Fri, 19 Dec 2025 15:03:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Francois Pierre Doray (Gerrit)

unread,
Dec 19, 2025, 10:48:30 AM (yesterday) Dec 19
to Etienne Pierre-Doray, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, spang...@chromium.org, android-web...@chromium.org, chrome-gr...@chromium.org, feature-v...@chromium.org, halliwe...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, storage...@chromium.org
Attention needed from Etienne Pierre-Doray

Francois Pierre Doray voted and added 1 comment

Votes added by Francois Pierre Doray

Code-Review+1

1 comment

Patchset-level comments
Francois Pierre Doray . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Etienne Pierre-Doray
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: If26545b28c180fc831b0d6e0c87b45a5474f1c93
    Gerrit-Change-Number: 7254727
    Gerrit-PatchSet: 5
    Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
    Gerrit-Attention: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Comment-Date: Fri, 19 Dec 2025 15:48:23 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Etienne Pierre-Doray (Gerrit)

    unread,
    Dec 19, 2025, 10:50:42 AM (yesterday) Dec 19
    to Francois Pierre Doray, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, spang...@chromium.org, android-web...@chromium.org, chrome-gr...@chromium.org, feature-v...@chromium.org, halliwe...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, storage...@chromium.org

    Etienne Pierre-Doray voted

    Commit-Queue+2
    Owners-Override+1
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: If26545b28c180fc831b0d6e0c87b45a5474f1c93
    Gerrit-Change-Number: 7254727
    Gerrit-PatchSet: 5
    Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
    Gerrit-Comment-Date: Fri, 19 Dec 2025 15:50:35 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Dec 19, 2025, 10:54:25 AM (yesterday) Dec 19
    to Etienne Pierre-Doray, Francois Pierre Doray, AyeAye, chromium...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, spang...@chromium.org, android-web...@chromium.org, chrome-gr...@chromium.org, feature-v...@chromium.org, halliwe...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, storage...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [tracing] Migrate legacy async macros in various folders

    Migrating the following async event macros somewhat mechanically:
    ```
    - TRACE_EVENT(_NESTABLE)?_ASYNC_BEGIN(_WITH_TIMESTAMP)?[012](<category_group>, <name>, <id>, ...)
    -> TRACE_EVENT_BEGIN(<category_group>, <name>, <track>, ...)

    - TRACE_EVENT(_NESTABLE)?_ASYNC_END(_WITH_TIMESTAMP)?[012](<category_group>, <name>, <id>, ...)
    -> TRACE_EVENT_END(<category_group>, <track>, ...)

    - TRACE_EVENT(_NESTABLE)?_ASYNC_INSTANT(_WITH_TIMESTAMP)?[012](<category_group>, <name>, <id>, ...)
    -> TRACE_EVENT_INSTANT(<category_group>, <name>, <track>, ...)
    ```

    These are the few remaining usage in various folders in chrome
    Bug: 432427382
    Change-Id: If26545b28c180fc831b0d6e0c87b45a5474f1c93
    Reviewed-by: Francois Pierre Doray <fdo...@chromium.org>
    Commit-Queue: Etienne Pierre-Doray <etie...@chromium.org>
    Owners-Override: Etienne Pierre-Doray <etie...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1561151}
    Files:
    • M android_webview/browser/gfx/begin_frame_source_webview.cc
    • M base/trace_event/memory_dump_manager.cc
    • M chromecast/browser/cast_web_contents_impl.cc
    • M device/vr/android/arcore/arcore_gl.cc
    • M device/vr/openxr/openxr_api_wrapper.cc
    • M device/vr/openxr/openxr_render_loop.cc
    • M ios/web/webui/url_data_manager_ios_backend.mm
    • M sandbox/policy/win/sandbox_win.cc
    • M storage/browser/blob/blob_reader.cc
    • M storage/browser/blob/mojo_blob_reader.cc
    • M storage/browser/quota/quota_manager_impl.cc
    Change size: M
    Delta: 11 files changed, 103 insertions(+), 95 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Francois Pierre Doray
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: If26545b28c180fc831b0d6e0c87b45a5474f1c93
    Gerrit-Change-Number: 7254727
    Gerrit-PatchSet: 6
    Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages