[tracing] Fix startup-shutdown hang [chromium/src : main]
0 views
Skip to first unread message
Etienne Pierre-Doray (Gerrit)
Jun 25, 2026, 7:54:41 AM (9 days ago) Jun 25
to Eric Seckler, Gabriel Charette, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Eric Seckler
Etienne Pierre-Doray added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Eric Seckler
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Eric Seckler (Gerrit)
Jun 25, 2026, 9:12:44 AM (8 days ago) Jun 25
to Etienne Pierre-Doray, Gabriel Charette, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray
Eric Seckler voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Etienne Pierre-Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Jun 25, 2026, 9:38:13 AM (8 days ago) Jun 25
to Eric Seckler, Gabriel Charette, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Etienne Pierre-Doray voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 25, 2026, 10:41:47 AM (8 days ago) Jun 25
to Etienne Pierre-Doray, Eric Seckler, Gabriel Charette, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[tracing] Fix startup-shutdown hang
This should fix b/40796622 hang.
This happens because ShutdownAndWaitForStopIfNeeded is
called while startup tracing is still initializing, and never gets
OnTracingStopped signal if the tracing service is disconnected.
This is fixed by propagating OnDisconnect in mojo backend which
results in a OnTracingStopped notification on the consumer side.
Bug: 40796622
Change-Id: I9bd5de15463b1f7d1bb873abead1e25a8ec4850f
Commit-Queue: Etienne Pierre-Doray <etie...@chromium.org>
Reviewed-by: Eric Seckler <esec...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1652413}
Files:
- M services/tracing/public/cpp/perfetto/perfetto_tracing_backend.cc
Change size: S
Delta: 1 file changed, 10 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Eric Seckler
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages