[BRP] Remove TraceLog::OptionalAutoLock exception [chromium/src : main]

0 views
Skip to first unread message

Bartek Nowierski (Gerrit)

unread,
Jun 25, 2024, 8:44:09 AM (6 days ago) Jun 25
to Stephen Nusko, Keishi Hattori, chromium...@chromium.org, Hans Wennborg, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Stephen Nusko

Bartek Nowierski voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Stephen Nusko
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2215c5e9113f25ad63116a80a569ff7a83579652
Gerrit-Change-Number: 5653890
Gerrit-PatchSet: 1
Gerrit-Owner: Bartek Nowierski <bar...@chromium.org>
Gerrit-Reviewer: Bartek Nowierski <bar...@chromium.org>
Gerrit-Reviewer: Stephen Nusko <nus...@chromium.org>
Gerrit-CC: Hans Wennborg <ha...@chromium.org>
Gerrit-CC: Keishi Hattori <kei...@chromium.org>
Gerrit-Attention: Stephen Nusko <nus...@chromium.org>
Gerrit-Comment-Date: Tue, 25 Jun 2024 12:43:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Stephen Nusko (Gerrit)

unread,
Jun 25, 2024, 9:14:49 AM (6 days ago) Jun 25
to Bartek Nowierski, Chromium LUCI CQ, Keishi Hattori, chromium...@chromium.org, Hans Wennborg, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Bartek Nowierski

Stephen Nusko voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Bartek Nowierski
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2215c5e9113f25ad63116a80a569ff7a83579652
Gerrit-Change-Number: 5653890
Gerrit-PatchSet: 1
Gerrit-Owner: Bartek Nowierski <bar...@chromium.org>
Gerrit-Reviewer: Bartek Nowierski <bar...@chromium.org>
Gerrit-Reviewer: Stephen Nusko <nus...@chromium.org>
Gerrit-CC: Hans Wennborg <ha...@chromium.org>
Gerrit-CC: Keishi Hattori <kei...@chromium.org>
Gerrit-Attention: Bartek Nowierski <bar...@chromium.org>
Gerrit-Comment-Date: Tue, 25 Jun 2024 13:14:36 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Jun 25, 2024, 9:49:30 AM (6 days ago) Jun 25
to Bartek Nowierski, Stephen Nusko, Keishi Hattori, chromium...@chromium.org, Hans Wennborg, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[BRP] Remove TraceLog::OptionalAutoLock exception

The embedding class can be marked STACK_ALLOCATED, and we generally don't rewrite these
Bug: 348793153
Change-Id: I2215c5e9113f25ad63116a80a569ff7a83579652
Commit-Queue: Bartek Nowierski <bar...@chromium.org>
Commit-Queue: Stephen Nusko <nus...@chromium.org>
Reviewed-by: Stephen Nusko <nus...@chromium.org>
Auto-Submit: Bartek Nowierski <bar...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1319114}
Files:
  • M base/trace_event/trace_log.cc
  • M tools/clang/rewrite_raw_ptr_fields/manual-fields-to-ignore.txt
Change size: S
Delta: 2 files changed, 8 insertions(+), 11 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Stephen Nusko
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2215c5e9113f25ad63116a80a569ff7a83579652
Gerrit-Change-Number: 5653890
Gerrit-PatchSet: 2
Gerrit-Owner: Bartek Nowierski <bar...@chromium.org>
Gerrit-Reviewer: Bartek Nowierski <bar...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Stephen Nusko <nus...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages