Victor Samun (Gerrit)

unread,

Jun 25, 2026, 10:43:35 AMJun 25

to John Chen, Wenbin Zhang, android-bu...@system.gserviceaccount.com, catapult...@chromium.org, telemetr...@chromium.org

Attention needed from John Chen and Wenbin Zhang

Victor Samun voted and added 1 comment

Votes added by Victor Samun

Auto-Submit	+1
Commit-Queue	+1

1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Victor Samun . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:

John Chen
Wenbin Zhang

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

John Chen (Gerrit)

unread,

Jun 25, 2026, 12:28:36 PMJun 25

to Victor Samun, catapul...@luci-project-accounts.iam.gserviceaccount.com, Wenbin Zhang, android-bu...@system.gserviceaccount.com, catapult...@chromium.org, telemetr...@chromium.org

Attention needed from Victor Samun and Wenbin Zhang

John Chen voted

Code-Review	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention is currently required from:

Victor Samun
Wenbin Zhang

Submit Requirements:

Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Farid (Mojtaba) Faridzad (Gerrit)

unread,

Jun 25, 2026, 12:56:30 PMJun 25

to Victor Samun, Wenbin Zhang, John Chen, catapul...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, catapult...@chromium.org, telemetr...@chromium.org

Attention needed from Victor Samun

Farid (Mojtaba) Faridzad voted

Code-Review	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention is currently required from:

Victor Samun

Submit Requirements:

Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

catapult-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

unread,

Jun 25, 2026, 12:58:52 PMJun 25

to Victor Samun, Farid (Mojtaba) Faridzad, Wenbin Zhang, John Chen, android-bu...@system.gserviceaccount.com, catapult...@chromium.org, telemetr...@chromium.org

catapul...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Change information

Commit message:

Add wait for target update after navigation

Test |testGetUpdatedInspectableContextsUpdateContextsData| is flaky: we
got empty url in |/json| response, but after small time url become not
empty.
In some cases |/json| request arrive to main process before arrive
message |DidCommitNavigation|. So we need wait for message arrive to
main process after navigation completed

Change-Id: Ibec8b8b4ca9227231386ccc075e16edaec0eb45d

Reviewed-on: https://chromium-review.googlesource.com/c/catapult/+/8005475

Auto-Submit: Victor Samun <victo...@yandex-team.ru>

Reviewed-by: John Chen <john...@chromium.org>

Reviewed-by: Farid (Mojtaba) Faridzad <fari...@google.com>

Commit-Queue: Farid (Mojtaba) Faridzad <fari...@google.com>

Files:

M telemetry/telemetry/internal/backends/chrome_inspector/inspector_page.py

Change size: S

Delta: 1 file changed, 27 insertions(+), 0 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Farid (Mojtaba) Faridzad, +1 by John Chen

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Victor Samun (Gerrit)

unread,

Jun 29, 2026, 2:03:51 AM (13 days ago) Jun 29

to catapul...@luci-project-accounts.iam.gserviceaccount.com, Farid (Mojtaba) Faridzad, Wenbin Zhang, John Chen, android-bu...@system.gserviceaccount.com, catapult...@chromium.org, telemetr...@chromium.org

Attention needed from John Chen

Victor Samun added 1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Victor Samun . resolved

When this CL will be rolled to chromium/src?

Open in Gerrit

Related details

Attention is currently required from:

John Chen

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

John Chen (Gerrit)

unread,

Jul 7, 2026, 1:12:54 PM (4 days ago) Jul 7

to catapul...@luci-project-accounts.iam.gserviceaccount.com, Victor Samun, Farid (Mojtaba) Faridzad, Wenbin Zhang, android-bu...@system.gserviceaccount.com, catapult...@chromium.org, telemetr...@chromium.org

Attention needed from Victor Samun

John Chen added 1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Victor Samun . unresolved

When this CL will be rolled to chromium/src?

John Chen

Looks like the roller is having some difficulties. I'll take a look.

Open in Gerrit

Related details

Attention is currently required from:

Victor Samun

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

John Chen (Gerrit)

unread,

Jul 7, 2026, 1:54:39 PM (4 days ago) Jul 7

to catapul...@luci-project-accounts.iam.gserviceaccount.com, Victor Samun, Farid (Mojtaba) Faridzad, Wenbin Zhang, android-bu...@system.gserviceaccount.com, catapult...@chromium.org, telemetr...@chromium.org

Attention needed from Victor Samun

John Chen added 1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Victor Samun . unresolved

When this CL will be rolled to chromium/src?

John Chen

Looks like the roller is having some difficulties. I'll take a look.

John Chen

Hi Victor:

Your change is causing a test failure in Chromium, so the roller was unable to roll it. The failed attempt is https://chromium-review.git.corp.google.com/c/chromium/src/+/8006011. Several failures occurred while testing on Android. Here is an example output:

```
[75/182] Pixel_Video_HEVC passed 2.9342s (worker 1)
Error on getting frame urls
Traceback (most recent call last):
  File "/b/swarming/w/ir/third_party/catapult/telemetry/third_party/websocket-client/websocket/_socket.py", line 81, in recv
    bytes_ = sock.recv(bufsize)
             ^^^^^^^^^^^^^^^^^^
TimeoutError: timed out

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/b/swarming/w/ir/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_websocket.py", line 171, in _Receive
    data = self._socket.recv()
           ^^^^^^^^^^^^^^^^^^^
  File "/b/swarming/w/ir/third_party/catapult/telemetry/third_party/websocket-client/websocket/_core.py", line 294, in recv
    opcode, data = self.recv_data()
                   ^^^^^^^^^^^^^^^^
  File "/b/swarming/w/ir/third_party/catapult/telemetry/third_party/websocket-client/websocket/_core.py", line 311, in recv_data
    opcode, frame = self.recv_data_frame(control_frame)
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/b/swarming/w/ir/third_party/catapult/telemetry/third_party/websocket-client/websocket/_core.py", line 324, in recv_data_frame
    frame = self.recv_frame()
            ^^^^^^^^^^^^^^^^^
  File "/b/swarming/w/ir/third_party/catapult/telemetry/third_party/websocket-client/websocket/_core.py", line 358, in recv_frame
    return self.frame_buffer.recv_frame()
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/b/swarming/w/ir/third_party/catapult/telemetry/third_party/websocket-client/websocket/_abnf.py", line 337, in recv_frame
    self.recv_header()
  File "/b/swarming/w/ir/third_party/catapult/telemetry/third_party/websocket-client/websocket/_abnf.py", line 287, in recv_header
    header = self.recv_strict(2)
             ^^^^^^^^^^^^^^^^^^^
  File "/b/swarming/w/ir/third_party/catapult/telemetry/third_party/websocket-client/websocket/_abnf.py", line 372, in recv_strict
    bytes_ = self.recv(min(16384, shortage))
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/b/swarming/w/ir/third_party/catapult/telemetry/third_party/websocket-client/websocket/_core.py", line 428, in _recv
    return recv(self.sock, bufsize)
           ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/b/swarming/w/ir/third_party/catapult/telemetry/third_party/websocket-client/websocket/_socket.py", line 84, in recv
    raise WebSocketTimeoutException(message)
websocket._exceptions.WebSocketTimeoutException: timed out

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/b/swarming/w/ir/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_page.py", line 87, in _GetFrameUrls
    result = self._inspector_websocket.SyncRequest(
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/b/swarming/w/ir/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_websocket.py", line 132, in SyncRequest
    res = self._Receive(timeout)
          ^^^^^^^^^^^^^^^^^^^^^^
  File "/b/swarming/w/ir/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_websocket.py", line 181, in _Receive
    raise WebSocketException(err) from err
telemetry.internal.backends.chrome_inspector.inspector_websocket.WebSocketException: WebSocketException of type <class 'websocket._exceptions.WebSocketTimeoutException'>. Error message: WebSocketTimeoutException('timed out')
```

Could you please take a look as soon as possible? Thanks. Sorry for not bringing this to your attention sooner. I was out of office for a few days due to US holidays.

Open in Gerrit

Related details

Attention is currently required from:

Victor Samun

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

John Chen (Gerrit)

unread,

Jul 10, 2026, 1:11:59 PM (2 days ago) Jul 10

to catapul...@luci-project-accounts.iam.gserviceaccount.com, Victor Samun, Farid (Mojtaba) Faridzad, Wenbin Zhang, android-bu...@system.gserviceaccount.com, catapult...@chromium.org, telemetr...@chromium.org

Attention needed from Victor Samun

John Chen has created a revert of this change

Open original change

Related details

Attention is currently required from:

Victor Samun

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

Add wait for target update after navigation [catapult : main]

Victor Samun (Gerrit)

Victor Samun voted and added 1 comment

Votes added by Victor Samun

1 comment

Related details

John Chen (Gerrit)

John Chen voted

Related details

Farid (Mojtaba) Faridzad (Gerrit)

Farid (Mojtaba) Faridzad voted

Related details

catapult-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

catapul...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Change information

Victor Samun (Gerrit)

Victor Samun added 1 comment

Related details

John Chen (Gerrit)

John Chen added 1 comment

Related details

John Chen (Gerrit)

John Chen added 1 comment

Related details

John Chen (Gerrit)

John Chen has created a revert of this change

Related details