[telemetry] Directly support --js-flags in benchmark runner [catapult : main]

0 views
Skip to first unread message

Camillo Bruni (Gerrit)

unread,
Feb 12, 2026, 8:49:09 AM (13 days ago) Feb 12
to Maxim Sheshukov, Wenbin Zhang, Catapult LUCI CQ, catapult...@chromium.org, telemetr...@chromium.org
Attention needed from Maxim Sheshukov and Wenbin Zhang

Camillo Bruni added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Camillo Bruni . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:
  • Maxim Sheshukov
  • Wenbin Zhang
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: catapult
Gerrit-Branch: main
Gerrit-Change-Id: Ie877f192bf80052df7b679ff7836b254fb0d32c5
Gerrit-Change-Number: 7566986
Gerrit-PatchSet: 1
Gerrit-Owner: Camillo Bruni <cbr...@chromium.org>
Gerrit-Reviewer: Camillo Bruni <cbr...@chromium.org>
Gerrit-Reviewer: Maxim Sheshukov <maximsh...@google.com>
Gerrit-Reviewer: Wenbin Zhang <wenbi...@google.com>
Gerrit-Attention: Maxim Sheshukov <maximsh...@google.com>
Gerrit-Attention: Wenbin Zhang <wenbi...@google.com>
Gerrit-Comment-Date: Thu, 12 Feb 2026 13:49:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Maxim Sheshukov (Gerrit)

unread,
Feb 12, 2026, 9:12:45 AM (13 days ago) Feb 12
to Camillo Bruni, Wenbin Zhang, Catapult LUCI CQ, catapult...@chromium.org, telemetr...@chromium.org
Attention needed from Camillo Bruni and Wenbin Zhang

Maxim Sheshukov voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Camillo Bruni
  • Wenbin Zhang
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: catapult
Gerrit-Branch: main
Gerrit-Change-Id: Ie877f192bf80052df7b679ff7836b254fb0d32c5
Gerrit-Change-Number: 7566986
Gerrit-PatchSet: 1
Gerrit-Owner: Camillo Bruni <cbr...@chromium.org>
Gerrit-Reviewer: Camillo Bruni <cbr...@chromium.org>
Gerrit-Reviewer: Maxim Sheshukov <maximsh...@google.com>
Gerrit-Reviewer: Wenbin Zhang <wenbi...@google.com>
Gerrit-Attention: Wenbin Zhang <wenbi...@google.com>
Gerrit-Attention: Camillo Bruni <cbr...@chromium.org>
Gerrit-Comment-Date: Thu, 12 Feb 2026 14:12:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
open
diffy

Maxim Sheshukov (Gerrit)

unread,
Feb 17, 2026, 6:19:11 AM (8 days ago) Feb 17
to Camillo Bruni, Code Review Nudger, Wenbin Zhang, Catapult LUCI CQ, catapult...@chromium.org, telemetr...@chromium.org
Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
Gerrit-Attention: Wenbin Zhang <wenbi...@google.com>
Gerrit-Attention: Camillo Bruni <cbr...@chromium.org>
Gerrit-Comment-Date: Tue, 17 Feb 2026 11:19:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
open
diffy

Camillo Bruni (Gerrit)

unread,
Feb 19, 2026, 4:56:14 PM (6 days ago) Feb 19
to Code Review Nudger, Maxim Sheshukov, Wenbin Zhang, Catapult LUCI CQ, catapult...@chromium.org, telemetr...@chromium.org
Attention needed from Maxim Sheshukov and Wenbin Zhang

Camillo Bruni added 1 comment

Patchset-level comments
Camillo Bruni . resolved

gentle ping (or suggest another owner)

Open in Gerrit

Related details

Attention is currently required from:
  • Maxim Sheshukov
  • Wenbin Zhang
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: catapult
Gerrit-Branch: main
Gerrit-Change-Id: Ie877f192bf80052df7b679ff7836b254fb0d32c5
Gerrit-Change-Number: 7566986
Gerrit-PatchSet: 1
Gerrit-Owner: Camillo Bruni <cbr...@chromium.org>
Gerrit-Reviewer: Camillo Bruni <cbr...@chromium.org>
Gerrit-Reviewer: Maxim Sheshukov <maximsh...@google.com>
Gerrit-Reviewer: Wenbin Zhang <wenbi...@google.com>
Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
Gerrit-Attention: Maxim Sheshukov <maximsh...@google.com>
Gerrit-Attention: Wenbin Zhang <wenbi...@google.com>
Gerrit-Comment-Date: Thu, 19 Feb 2026 21:56:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Maxim Sheshukov (Gerrit)

unread,
Feb 20, 2026, 4:50:47 AM (5 days ago) Feb 20
to Camillo Bruni, Code Review Nudger, Wenbin Zhang, Catapult LUCI CQ, catapult...@chromium.org, telemetr...@chromium.org
Attention needed from Camillo Bruni and Wenbin Zhang

Maxim Sheshukov voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Camillo Bruni
  • Wenbin Zhang
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: catapult
Gerrit-Branch: main
Gerrit-Change-Id: Ie877f192bf80052df7b679ff7836b254fb0d32c5
Gerrit-Change-Number: 7566986
Gerrit-PatchSet: 1
Gerrit-Owner: Camillo Bruni <cbr...@chromium.org>
Gerrit-Reviewer: Camillo Bruni <cbr...@chromium.org>
Gerrit-Reviewer: Maxim Sheshukov <maximsh...@google.com>
Gerrit-Reviewer: Wenbin Zhang <wenbi...@google.com>
Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
Gerrit-Attention: Wenbin Zhang <wenbi...@google.com>
Gerrit-Attention: Camillo Bruni <cbr...@chromium.org>
Gerrit-Comment-Date: Fri, 20 Feb 2026 09:50:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
open
diffy

Wenbin Zhang (Gerrit)

unread,
Feb 20, 2026, 5:21:13 PM (5 days ago) Feb 20
to Camillo Bruni, Code Review Nudger, Maxim Sheshukov, Catapult LUCI CQ, catapult...@chromium.org, telemetr...@chromium.org
Attention needed from Camillo Bruni and Maxim Sheshukov

Wenbin Zhang voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Camillo Bruni
  • Maxim Sheshukov
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: catapult
Gerrit-Branch: main
Gerrit-Change-Id: Ie877f192bf80052df7b679ff7836b254fb0d32c5
Gerrit-Change-Number: 7566986
Gerrit-PatchSet: 1
Gerrit-Owner: Camillo Bruni <cbr...@chromium.org>
Gerrit-Reviewer: Camillo Bruni <cbr...@chromium.org>
Gerrit-Reviewer: Maxim Sheshukov <maximsh...@google.com>
Gerrit-Reviewer: Wenbin Zhang <wenbi...@google.com>
Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
Gerrit-Attention: Maxim Sheshukov <maximsh...@google.com>
Gerrit-Attention: Camillo Bruni <cbr...@chromium.org>
Gerrit-Comment-Date: Fri, 20 Feb 2026 22:21:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Camillo Bruni (Gerrit)

unread,
Feb 23, 2026, 7:57:12 AM (2 days ago) Feb 23
to Wenbin Zhang, Code Review Nudger, Maxim Sheshukov, Catapult LUCI CQ, catapult...@chromium.org, telemetr...@chromium.org
Attention needed from Maxim Sheshukov

Camillo Bruni voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Maxim Sheshukov
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: catapult
Gerrit-Branch: main
Gerrit-Change-Id: Ie877f192bf80052df7b679ff7836b254fb0d32c5
Gerrit-Change-Number: 7566986
Gerrit-PatchSet: 1
Gerrit-Owner: Camillo Bruni <cbr...@chromium.org>
Gerrit-Reviewer: Camillo Bruni <cbr...@chromium.org>
Gerrit-Reviewer: Maxim Sheshukov <maximsh...@google.com>
Gerrit-Reviewer: Wenbin Zhang <wenbi...@google.com>
Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
Gerrit-Attention: Maxim Sheshukov <maximsh...@google.com>
Gerrit-Comment-Date: Mon, 23 Feb 2026 12:57:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Catapult LUCI CQ (Gerrit)

unread,
Feb 23, 2026, 8:16:08 AM (2 days ago) Feb 23
to Camillo Bruni, Wenbin Zhang, Code Review Nudger, Maxim Sheshukov, catapult...@chromium.org, telemetr...@chromium.org

Catapult LUCI CQ submitted the change

Change information

Commit message:
[telemetry] Directly support --js-flags in benchmark runner
Bug: chromium:483858937
Change-Id: Ie877f192bf80052df7b679ff7836b254fb0d32c5
Reviewed-by: Wenbin Zhang <wenbi...@google.com>
Commit-Queue: Camillo Bruni <cbr...@chromium.org>
Files:
  • M telemetry/telemetry/internal/browser/browser_options.py
  • M telemetry/telemetry/internal/browser/browser_options_unittest.py
Change size: M
Delta: 2 files changed, 59 insertions(+), 8 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Wenbin Zhang
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: catapult
Gerrit-Branch: main
Gerrit-Change-Id: Ie877f192bf80052df7b679ff7836b254fb0d32c5
Gerrit-Change-Number: 7566986
Gerrit-PatchSet: 2
Gerrit-Owner: Camillo Bruni <cbr...@chromium.org>
Gerrit-Reviewer: Camillo Bruni <cbr...@chromium.org>
Gerrit-Reviewer: Catapult LUCI CQ <catapul...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Maxim Sheshukov <maximsh...@google.com>
Gerrit-Reviewer: Wenbin Zhang <wenbi...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages