[perf] Add global switch flag for loading bot_platform data from csv [chromium/src : main]

0 views
Skip to first unread message

Camillo Bruni (Gerrit)

unread,
Feb 24, 2026, 7:53:05 AM (22 hours ago) Feb 24
to John Chen, chromium...@chromium.org, telemetr...@chromium.org
Attention needed from John Chen

Camillo Bruni added 1 comment

Patchset-level comments
File-level comment, Patchset 7 (Latest):
Camillo Bruni . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:
  • John Chen
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I79bc4f275f9d83ef777ccfecdefa334217ecd9ce
Gerrit-Change-Number: 7598960
Gerrit-PatchSet: 7
Gerrit-Owner: Camillo Bruni <cbr...@chromium.org>
Gerrit-Reviewer: Camillo Bruni <cbr...@chromium.org>
Gerrit-Reviewer: John Chen <john...@chromium.org>
Gerrit-Attention: John Chen <john...@chromium.org>
Gerrit-Comment-Date: Tue, 24 Feb 2026 12:52:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

John Chen (Gerrit)

unread,
Feb 24, 2026, 11:55:49 AM (18 hours ago) Feb 24
to Camillo Bruni, Chromium LUCI CQ, chromium...@chromium.org, telemetr...@chromium.org
Attention needed from Camillo Bruni

John Chen voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Camillo Bruni
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I79bc4f275f9d83ef777ccfecdefa334217ecd9ce
    Gerrit-Change-Number: 7598960
    Gerrit-PatchSet: 7
    Gerrit-Owner: Camillo Bruni <cbr...@chromium.org>
    Gerrit-Reviewer: Camillo Bruni <cbr...@chromium.org>
    Gerrit-Reviewer: John Chen <john...@chromium.org>
    Gerrit-Attention: Camillo Bruni <cbr...@chromium.org>
    Gerrit-Comment-Date: Tue, 24 Feb 2026 16:55:43 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Camillo Bruni (Gerrit)

    unread,
    Feb 24, 2026, 12:18:56 PM (17 hours ago) Feb 24
    to John Chen, Chromium LUCI CQ, chromium...@chromium.org, telemetr...@chromium.org

    Camillo Bruni voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I79bc4f275f9d83ef777ccfecdefa334217ecd9ce
    Gerrit-Change-Number: 7598960
    Gerrit-PatchSet: 7
    Gerrit-Owner: Camillo Bruni <cbr...@chromium.org>
    Gerrit-Reviewer: Camillo Bruni <cbr...@chromium.org>
    Gerrit-Reviewer: John Chen <john...@chromium.org>
    Gerrit-Comment-Date: Tue, 24 Feb 2026 17:18:39 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Feb 24, 2026, 12:30:42 PM (17 hours ago) Feb 24
    to Camillo Bruni, John Chen, chromium...@chromium.org, telemetr...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [perf] Add global switch flag for loading bot_platform data from csv

    - Add _USE_CSV_SCHEDULE_FILES to select between the original
    python-based or the new csv-based approach
    - Update type annotations
    - Mark more globals in bot_platforms.py as private

    BYPASS_LARGE_CHANGE_WARNING: ridiculous limits
    Bug: 482952915
    Change-Id: I79bc4f275f9d83ef777ccfecdefa334217ecd9ce
    Reviewed-by: John Chen <john...@chromium.org>
    Commit-Queue: Camillo Bruni <cbr...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1589489}
    Files:
    • M tools/perf/core/bot_platforms.py
    Change size: XL
    Delta: 1 file changed, 668 insertions(+), 658 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by John Chen
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I79bc4f275f9d83ef777ccfecdefa334217ecd9ce
    Gerrit-Change-Number: 7598960
    Gerrit-PatchSet: 8
    Gerrit-Owner: Camillo Bruni <cbr...@chromium.org>
    Gerrit-Reviewer: Camillo Bruni <cbr...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: John Chen <john...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages