Shared Storage: Remove performance benchmarks [chromium/src : main]

0 views
Skip to first unread message

Cammie Smith Barnes (Gerrit)

unread,
Jul 6, 2026, 4:23:01 PM (5 days ago) Jul 6
to Yao Xiao, Chromium LUCI CQ, chromium...@chromium.org, telemetr...@chromium.org
Attention needed from Yao Xiao

Cammie Smith Barnes added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Cammie Smith Barnes . resolved

yaoxia@, PTAL, thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Yao Xiao
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I35efeb7f026503e6d0f7d4f5a81b46db7bcd0d9a
Gerrit-Change-Number: 8048021
Gerrit-PatchSet: 1
Gerrit-Owner: Cammie Smith Barnes <cam...@chromium.org>
Gerrit-Reviewer: Cammie Smith Barnes <cam...@chromium.org>
Gerrit-Reviewer: Yao Xiao <yao...@chromium.org>
Gerrit-Attention: Yao Xiao <yao...@chromium.org>
Gerrit-Comment-Date: Mon, 06 Jul 2026 20:22:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Yao Xiao (Gerrit)

unread,
Jul 6, 2026, 6:30:32 PM (5 days ago) Jul 6
to Cammie Smith Barnes, Chromium LUCI CQ, chromium...@chromium.org, telemetr...@chromium.org
Attention needed from Cammie Smith Barnes

Yao Xiao voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Cammie Smith Barnes
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I35efeb7f026503e6d0f7d4f5a81b46db7bcd0d9a
    Gerrit-Change-Number: 8048021
    Gerrit-PatchSet: 1
    Gerrit-Owner: Cammie Smith Barnes <cam...@chromium.org>
    Gerrit-Reviewer: Cammie Smith Barnes <cam...@chromium.org>
    Gerrit-Reviewer: Yao Xiao <yao...@chromium.org>
    Gerrit-Attention: Cammie Smith Barnes <cam...@chromium.org>
    Gerrit-Comment-Date: Mon, 06 Jul 2026 22:30:22 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Cammie Smith Barnes (Gerrit)

    unread,
    Jul 6, 2026, 6:34:04 PM (5 days ago) Jul 6
    to Annie Sullivan, Yao Xiao, Chromium LUCI CQ, chromium...@chromium.org, telemetr...@chromium.org
    Attention needed from Annie Sullivan

    Cammie Smith Barnes added 1 comment

    Cammie Smith Barnes . resolved

    sullivan@, PTAL, thanks!

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Annie Sullivan
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I35efeb7f026503e6d0f7d4f5a81b46db7bcd0d9a
    Gerrit-Change-Number: 8048021
    Gerrit-PatchSet: 2
    Gerrit-Owner: Cammie Smith Barnes <cam...@chromium.org>
    Gerrit-Reviewer: Annie Sullivan <sull...@chromium.org>
    Gerrit-Reviewer: Cammie Smith Barnes <cam...@chromium.org>
    Gerrit-Reviewer: Yao Xiao <yao...@chromium.org>
    Gerrit-Attention: Annie Sullivan <sull...@chromium.org>
    Gerrit-Comment-Date: Mon, 06 Jul 2026 22:33:58 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Annie Sullivan (Gerrit)

    unread,
    Jul 8, 2026, 7:36:53 PM (3 days ago) Jul 8
    to Cammie Smith Barnes, Yao Xiao, Chromium LUCI CQ, chromium...@chromium.org, telemetr...@chromium.org
    Attention needed from Cammie Smith Barnes

    Annie Sullivan voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Cammie Smith Barnes
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I35efeb7f026503e6d0f7d4f5a81b46db7bcd0d9a
    Gerrit-Change-Number: 8048021
    Gerrit-PatchSet: 2
    Gerrit-Owner: Cammie Smith Barnes <cam...@chromium.org>
    Gerrit-Reviewer: Annie Sullivan <sull...@chromium.org>
    Gerrit-Reviewer: Cammie Smith Barnes <cam...@chromium.org>
    Gerrit-Reviewer: Yao Xiao <yao...@chromium.org>
    Gerrit-Attention: Cammie Smith Barnes <cam...@chromium.org>
    Gerrit-Comment-Date: Wed, 08 Jul 2026 23:36:45 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Cammie Smith Barnes (Gerrit)

    unread,
    Jul 9, 2026, 11:16:49 AM (3 days ago) Jul 9
    to Annie Sullivan, Yao Xiao, Chromium LUCI CQ, chromium...@chromium.org, telemetr...@chromium.org

    Cammie Smith Barnes voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I35efeb7f026503e6d0f7d4f5a81b46db7bcd0d9a
    Gerrit-Change-Number: 8048021
    Gerrit-PatchSet: 2
    Gerrit-Owner: Cammie Smith Barnes <cam...@chromium.org>
    Gerrit-Reviewer: Annie Sullivan <sull...@chromium.org>
    Gerrit-Reviewer: Cammie Smith Barnes <cam...@chromium.org>
    Gerrit-Reviewer: Yao Xiao <yao...@chromium.org>
    Gerrit-Comment-Date: Thu, 09 Jul 2026 15:16:38 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Cammie Smith Barnes (Gerrit)

    unread,
    Jul 9, 2026, 1:55:30 PM (2 days ago) Jul 9
    to Annie Sullivan, Yao Xiao, Chromium LUCI CQ, chromium...@chromium.org, telemetr...@chromium.org
    Gerrit-Comment-Date: Thu, 09 Jul 2026 17:55:23 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jul 9, 2026, 2:04:48 PM (2 days ago) Jul 9
    to Cammie Smith Barnes, Annie Sullivan, Yao Xiao, chromium...@chromium.org, telemetr...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Shared Storage: Remove performance benchmarks

    The shared storage performance benchmarks under tools/perf/contrib
    are no longer maintained and are being removed to clean up the
    codebase and as a prerequisite for stubbing the deprecated Shared
    Storage APIs.

    This CL deletes the tools/perf/contrib/shared_storage directory
    and updates tools/perf/process_perf_results.pydeps.
    Bug: 462465887
    Change-Id: I35efeb7f026503e6d0f7d4f5a81b46db7bcd0d9a
    Commit-Queue: Cammie Smith Barnes <cam...@chromium.org>
    Reviewed-by: Yao Xiao <yao...@chromium.org>
    Reviewed-by: Annie Sullivan <sull...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1659697}
    Files:
    • D tools/perf/contrib/shared_storage/.gitignore
    • D tools/perf/contrib/shared_storage/OWNERS
    • D tools/perf/contrib/shared_storage/README.md
    • D tools/perf/contrib/shared_storage/__init__.py
    • D tools/perf/contrib/shared_storage/page_set.py
    • D tools/perf/contrib/shared_storage/pages.py
    • D tools/perf/contrib/shared_storage/process_results
    • D tools/perf/contrib/shared_storage/setup_worklet_and_db.html
    • D tools/perf/contrib/shared_storage/shared_storage.py
    • D tools/perf/contrib/shared_storage/shared_storage_shared_page_state.py
    • D tools/perf/contrib/shared_storage/utils/__init__.py
    • D tools/perf/contrib/shared_storage/utils/file_util.py
    • D tools/perf/contrib/shared_storage/utils/histogram_list.py
    • D tools/perf/contrib/shared_storage/utils/process_results.py
    • D tools/perf/contrib/shared_storage/utils/util.py
    • D tools/perf/contrib/shared_storage/utils/xvfb.py
    • D tools/perf/contrib/shared_storage/worklet.js
    • M tools/perf/process_perf_results.pydeps
    Change size: XL
    Delta: 18 files changed, 0 insertions(+), 2222 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Annie Sullivan, +1 by Yao Xiao
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I35efeb7f026503e6d0f7d4f5a81b46db7bcd0d9a
    Gerrit-Change-Number: 8048021
    Gerrit-PatchSet: 3
    Gerrit-Owner: Cammie Smith Barnes <cam...@chromium.org>
    Gerrit-Reviewer: Annie Sullivan <sull...@chromium.org>
    Gerrit-Reviewer: Cammie Smith Barnes <cam...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Yao Xiao <yao...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages