Revert "Add wait for target update after navigation" [catapult : main]
0 views
Skip to first unread message
rubber-stamper@appspot.gserviceaccount.com (Gerrit)
Jul 10, 2026, 1:12:10 PM (2 days ago) Jul 10
to John Chen, Farid (Mojtaba) Faridzad, catapul...@luci-project-accounts.iam.gserviceaccount.com, Victor Samun, android-bu...@system.gserviceaccount.com, Wenbin Zhang, telemetr...@chromium.org
Attention needed from Farid (Mojtaba) Faridzad and Victor Samun
Message from rubber-...@appspot.gserviceaccount.com![]( "Open in Gerrit")
The change is not in the configured time window. Rubber Stamper is only allowed to review reverts within 14 day(s). Learn more: go/rubber-stamper-user-guide.
Related details
Attention is currently required from:
- Farid (Mojtaba) Faridzad
- Victor Samun
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
John Chen (Gerrit)
Jul 10, 2026, 1:16:55 PM (2 days ago) Jul 10
to Wenbin Zhang, Farid (Mojtaba) Faridzad, catapul...@luci-project-accounts.iam.gserviceaccount.com, Victor Samun, android-bu...@system.gserviceaccount.com, telemetr...@chromium.org
Attention needed from Farid (Mojtaba) Faridzad, Victor Samun and Wenbin Zhang
John Chen voted and added 1 comment![]( "Open in Gerrit")
Votes added by John Chen
| Auto-Submit | +1 |
| Commit-Queue | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 1 (Latest):
John Chen . resolved
Wenbin or Farid: Could you please review this revert CL, which is needed to unblock roller from Catapult to Chromium. Rubber Stamper wasn't able to approve it, since the original change was too old. Thanks!
Related details
Attention is currently required from:
- Farid (Mojtaba) Faridzad
- Victor Samun
- Wenbin Zhang
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Farid (Mojtaba) Faridzad (Gerrit)
Jul 10, 2026, 1:20:58 PM (2 days ago) Jul 10
to John Chen, Wenbin Zhang, catapul...@luci-project-accounts.iam.gserviceaccount.com, Victor Samun, android-bu...@system.gserviceaccount.com, telemetr...@chromium.org
Attention needed from John Chen, Victor Samun and Wenbin Zhang
Farid (Mojtaba) Faridzad voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- John Chen
- Victor Samun
- Wenbin Zhang
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
John Chen (Gerrit)
Jul 10, 2026, 1:21:24 PM (2 days ago) Jul 10
to Farid (Mojtaba) Faridzad, Wenbin Zhang, catapul...@luci-project-accounts.iam.gserviceaccount.com, Victor Samun, android-bu...@system.gserviceaccount.com, telemetr...@chromium.org
Attention needed from Victor Samun and Wenbin Zhang
John Chen voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Victor Samun
- Wenbin Zhang
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
catapult-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
Jul 10, 2026, 1:38:15 PM (2 days ago) Jul 10
to John Chen, Farid (Mojtaba) Faridzad, Wenbin Zhang, Victor Samun, android-bu...@system.gserviceaccount.com, telemetr...@chromium.org
catapul...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Revert "Add wait for target update after navigation"
This reverts commit 6936eb033ac1369fc2d9f8bb40af8da0f972b81d.
Reason for revert: Causing test failures in Chromium, blocking the roller from Catapult to Chromium.
Failure Link: https://chromium-review.git.corp.google.com/c/chromium/src/+/8006011
Original change's description:
> Add wait for target update after navigation
>
> Test |testGetUpdatedInspectableContextsUpdateContextsData| is flaky: we
> got empty url in |/json| response, but after small time url become not
> empty.
> In some cases |/json| request arrive to main process before arrive
> message |DidCommitNavigation|. So we need wait for message arrive to
> main process after navigation completed
>
> Change-Id: Ibec8b8b4ca9227231386ccc075e16edaec0eb45d
> Reviewed-on: https://chromium-review.googlesource.com/c/catapult/+/8005475
> Auto-Submit: Victor Samun <victo...@yandex-team.ru>
> Reviewed-by: John Chen <john...@chromium.org>
> Reviewed-by: Farid (Mojtaba) Faridzad <fari...@google.com>
> Commit-Queue: Farid (Mojtaba) Faridzad <fari...@google.com>
Change-Id: I67f55487b7c472e4db31cab4147e4ee7ae43021c
Reviewed-by: Farid (Mojtaba) Faridzad <fari...@google.com>
Commit-Queue: John Chen <john...@chromium.org>
Auto-Submit: John Chen <john...@chromium.org>
Files:
- M telemetry/telemetry/internal/backends/chrome_inspector/inspector_page.py
Change size: S
Delta: 1 file changed, 0 insertions(+), 27 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Farid (Mojtaba) Faridzad
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages