Fix browser detection with custom local build dirs [catapult : main]
0 views
Skip to first unread message
Camillo Bruni (Gerrit)
Feb 9, 2026, 10:31:44 AMFeb 9
to Wenbin Zhang, catapult...@chromium.org, telemetr...@chromium.org
Attention needed from Wenbin Zhang
Camillo Bruni added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Wenbin Zhang
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Camillo Bruni (Gerrit)
Feb 19, 2026, 4:55:28 PM (6 days ago) Feb 19
to Catapult LUCI CQ, Wenbin Zhang, catapult...@chromium.org, telemetr...@chromium.org
Attention needed from Wenbin Zhang
Camillo Bruni added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Wenbin Zhang
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Wenbin Zhang (Gerrit)
Feb 20, 2026, 5:29:45 PM (5 days ago) Feb 20
to Camillo Bruni, Catapult LUCI CQ, catapult...@chromium.org, telemetr...@chromium.org
Attention needed from Camillo Bruni
Wenbin Zhang voted and added 2 comments![]( "Open in Gerrit")
Votes added by Wenbin Zhang
| Code-Review | +1 |
2 comments
Patchset-level comments
Wenbin Zhang . resolved
LGTM with one nit.
File telemetry/telemetry/internal/backends/chrome/desktop_browser_finder.py
Related details
Attention is currently required from:
- Camillo Bruni
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Camillo Bruni (Gerrit)
Feb 23, 2026, 7:54:50 AM (2 days ago) Feb 23
to Wenbin Zhang, Catapult LUCI CQ, catapult...@chromium.org, telemetr...@chromium.org
Camillo Bruni voted and added 1 comment![]( "Open in Gerrit")
Votes added by Camillo Bruni
| Commit-Queue | +2 |
1 comment
File telemetry/telemetry/internal/backends/chrome/desktop_browser_finder.py
Line 367, Patchset 3:
print("#" * 80, browsers)Wenbin Zhang . resolved
Camillo Bruninit: debug log?
Done
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Catapult LUCI CQ (Gerrit)
Feb 23, 2026, 8:12:50 AM (2 days ago) Feb 23
to Camillo Bruni, Wenbin Zhang, catapult...@chromium.org, telemetr...@chromium.org
Catapult LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
3 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: telemetry/telemetry/internal/backends/chrome/desktop_browser_finder.py
Insertions: 0, Deletions: 1.
@@ -364,7 +364,6 @@
'exact', finder_options, normalized_executable,
is_content_shell,
browser_directory))
- print("#" * 80, browsers)
return browsers
raise exceptions.PathMissingError(
```
Change information
Commit message:
Fix browser detection with custom local build dirs
The browser finder eagerly scans all out/* dirs for known chrome
types. If there are any non-standard names it hard crashes which
blocks us from running tests.
Change-Id: I927b4d643a69555b5c8b83932c460c68f4dadacf
Commit-Queue: Camillo Bruni <cbr...@chromium.org>
Reviewed-by: Wenbin Zhang <wenbi...@google.com>
Files:
- M telemetry/telemetry/internal/backends/chrome/desktop_browser_finder.py
- M telemetry/telemetry/internal/browser/possible_browser.py
Change size: S
Delta: 2 files changed, 12 insertions(+), 4 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Wenbin Zhang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages