Fix binding-setBindGroup.html on Compat [chromium/src : main]
0 views
Skip to first unread message
Kai Ninomiya (Gerrit)
Nov 12, 2025, 5:59:13 PM (11 hours ago) Nov 12
to Brandon Jones, chromium...@chromium.org, telemetr...@chromium.org, blink-...@chromium.org
Attention needed from Brandon Jones
Kai Ninomiya voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Brandon Jones
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brandon Jones (Gerrit)
Nov 12, 2025, 6:04:07 PM (11 hours ago) Nov 12
to Kai Ninomiya, Chromium LUCI CQ, chromium...@chromium.org, telemetr...@chromium.org, blink-...@chromium.org
Attention needed from Kai Ninomiya
Brandon Jones voted![]( "Open in Gerrit")
Attention is currently required from:
- Kai Ninomiya
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Nov 12, 2025, 7:41:40 PM (10 hours ago) Nov 12
to Kai Ninomiya, Brandon Jones, chromium...@chromium.org, telemetr...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Fix binding-setBindGroup.html on Compat
Use a uniform buffer to avoid needing maxStorageBuffersInVertexStage>=1.
Broke because I changed requestAdapter to request Compatibility Mode in
https://chromium-review.googlesource.com/c/chromium/src/+/7033613
and somehow didn't notice that one of the tests had broken (I thought I
ran them all).
This broke blink_perf.webgpu, not just webgpu_compat, because the code
now enforces Compat on all adapters (even Core-capable ones).
Fixed: 460130527
Change-Id: I79aa183465c35916d7fb7742f8cb7b1a25356fdd
Auto-Submit: Kai Ninomiya <kai...@chromium.org>
Commit-Queue: Kai Ninomiya <kai...@chromium.org>
Reviewed-by: Brandon Jones <baj...@chromium.org>
Commit-Queue: Brandon Jones <baj...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1544049}
Files:
- M third_party/blink/perf_tests/webgpu/binding-setBindGroup.html
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Brandon Jones
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages