Add Android to desktop stories in expectations [catapult : main]

1 view
Skip to first unread message

Renato Pereyra (Gerrit)

unread,
Feb 25, 2025, 1:19:46 PM2/25/25
to Jonathan Ross, catapult...@chromium.org, telemetr...@chromium.org
Attention needed from Jonathan Ross

Renato Pereyra added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Renato Pereyra . resolved

Not sure I did this correctly but just trying to get desktop stories running for Android desktop.

Open in Gerrit

Related details

Attention is currently required from:
  • Jonathan Ross
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: catapult
Gerrit-Branch: main
Gerrit-Change-Id: Ic250469f0d04efec7369d6acbb703ef62ac4afa6
Gerrit-Change-Number: 6270236
Gerrit-PatchSet: 1
Gerrit-Owner: Renato Pereyra <renato...@google.com>
Gerrit-Reviewer: Jonathan Ross <jon...@chromium.org>
Gerrit-Attention: Jonathan Ross <jon...@chromium.org>
Gerrit-Comment-Date: Tue, 25 Feb 2025 18:19:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Jonathan Ross (Gerrit)

unread,
Feb 25, 2025, 2:23:48 PM2/25/25
to Renato Pereyra, John Chen, catapult...@chromium.org, telemetr...@chromium.org
Attention needed from John Chen and Renato Pereyra

Jonathan Ross added 2 comments

Patchset-level comments
Renato Pereyra . resolved

Not sure I did this correctly but just trying to get desktop stories running for Android desktop.

Jonathan Ross

That should update story matching. We will need to have telemetry identify that it needs to use the `platform backend` for Android.

I think that invovles [`third_party/catapult/telemetry/telemetry/internal/platform/device_finder.py`](https://source.chromium.org/chromium/chromium/src/+/main:third_party/catapult/telemetry/telemetry/internal/platform/device_finder.py;drc=1fe05501cf4f6f9f95a85b12f04e59a4485e1ffe;l=27)

Jonathan Ross . resolved

+johnchen@ an owner of telemetry. I've done some small work in this repo before. However I lack enough familiarity with the entire backend selection.

johnchen@ can likely provided more acccurate guidance here

Open in Gerrit

Related details

Attention is currently required from:
  • John Chen
  • Renato Pereyra
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: catapult
Gerrit-Branch: main
Gerrit-Change-Id: Ic250469f0d04efec7369d6acbb703ef62ac4afa6
Gerrit-Change-Number: 6270236
Gerrit-PatchSet: 1
Gerrit-Owner: Renato Pereyra <renato...@google.com>
Gerrit-Reviewer: John Chen <john...@chromium.org>
Gerrit-Reviewer: Jonathan Ross <jon...@chromium.org>
Gerrit-Attention: Renato Pereyra <renato...@google.com>
Gerrit-Attention: John Chen <john...@chromium.org>
Gerrit-Comment-Date: Tue, 25 Feb 2025 19:23:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Renato Pereyra <renato...@google.com>
unsatisfied_requirement
open
diffy

John Chen (Gerrit)

unread,
Feb 25, 2025, 2:32:52 PM2/25/25
to Renato Pereyra, Jonathan Ross, catapult...@chromium.org, telemetr...@chromium.org
Attention needed from Renato Pereyra

John Chen added 1 comment

Patchset-level comments
John Chen . unresolved

This change will have enormous effects on our perf testing infrastructure, as it will start running desktop benchmarks on our Android devices on perf waterfall. Could you elaborate why this is needed?

Open in Gerrit

Related details

Attention is currently required from:
  • Renato Pereyra
Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: catapult
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic250469f0d04efec7369d6acbb703ef62ac4afa6
    Gerrit-Change-Number: 6270236
    Gerrit-PatchSet: 1
    Gerrit-Owner: Renato Pereyra <renato...@google.com>
    Gerrit-Reviewer: John Chen <john...@chromium.org>
    Gerrit-Reviewer: Jonathan Ross <jon...@chromium.org>
    Gerrit-Attention: Renato Pereyra <renato...@google.com>
    Gerrit-Comment-Date: Tue, 25 Feb 2025 19:32:49 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    unsatisfied_requirement
    open
    diffy

    John Chen (Gerrit)

    unread,
    Feb 25, 2025, 2:40:36 PM2/25/25
    to Renato Pereyra, Jonathan Ross, catapult...@chromium.org, telemetr...@chromium.org
    Attention needed from Jonathan Ross and Renato Pereyra

    John Chen added 1 comment

    Patchset-level comments
    Renato Pereyra . resolved

    Not sure I did this correctly but just trying to get desktop stories running for Android desktop.

    Jonathan Ross

    That should update story matching. We will need to have telemetry identify that it needs to use the `platform backend` for Android.

    I think that invovles [`third_party/catapult/telemetry/telemetry/internal/platform/device_finder.py`](https://source.chromium.org/chromium/chromium/src/+/main:third_party/catapult/telemetry/telemetry/internal/platform/device_finder.py;drc=1fe05501cf4f6f9f95a85b12f04e59a4485e1ffe;l=27)

    John Chen

    I guess I lack some context here. What is "Android desktop"?

    This change would cause Telemetry's benchmark selection algorithm to treat all Android device as desktop devices, not just some special "Android desktop" devices.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Jonathan Ross
    • Renato Pereyra
    Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: catapult
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic250469f0d04efec7369d6acbb703ef62ac4afa6
    Gerrit-Change-Number: 6270236
    Gerrit-PatchSet: 1
    Gerrit-Owner: Renato Pereyra <renato...@google.com>
    Gerrit-Reviewer: John Chen <john...@chromium.org>
    Gerrit-Reviewer: Jonathan Ross <jon...@chromium.org>
    Gerrit-Attention: Renato Pereyra <renato...@google.com>
    Gerrit-Attention: Jonathan Ross <jon...@chromium.org>
    Gerrit-Comment-Date: Tue, 25 Feb 2025 19:40:31 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Renato Pereyra <renato...@google.com>
    Comment-In-Reply-To: Jonathan Ross <jon...@chromium.org>
    unsatisfied_requirement
    open
    diffy

    Renato Pereyra (Gerrit)

    unread,
    Feb 25, 2025, 4:03:02 PM2/25/25
    to John Chen, Jonathan Ross, catapult...@chromium.org, telemetr...@chromium.org

    Renato Pereyra abandoned this change

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: abandon
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages