[benchmarking] Update signature of CustomizeOptions method of Benchmark class [catapult : master]
Wenbin Zhang (Gerrit)
Attention is currently required from: Wenbin Zhang.
Wenbin Zhang uploaded patch set #2 to this change.
[benchmarking] Update signature of CustomizeOptions method of Benchmark class
We will remove the FindBrowser call in CustomizeOptions, in order to avoid the FindBrowser to be called twice during RunBenchmark.
This CL updates the signature of the CustomizaOptions of the parent class in Telemetry.
We will have another CL to update the child class in Perf repo, and then a last CL to update the caller on Telemetry. More details on:
crbug/1149275#c6
Bug: chromium:1149275
Change-Id: I8d6f20c72548635b22b18c11a5f0dcf67ef27e4c
---
M telemetry/telemetry/benchmark.py
1 file changed, 1 insertion(+), 1 deletion(-)
To view, visit change 2550943. To unsubscribe, or for help writing mail filters, visit settings.
Wenbin Zhang (Gerrit)
Patch set 2:Auto-Submit +1
1 comment:
Commit Message:
Patch Set #1, Line 8:
We will remove the FindBrowser call in CustomizeOptions, in order to avoid the FindBrowser to be called twice during RunBenchmark.Nit: Please add an empty line before this.
Done
To view, visit change 2550943. To unsubscribe, or for help writing mail filters, visit settings.
Wenbin Zhang (Gerrit)
Patch set 2:Commit-Queue +2
Commit Bot (Gerrit)
CQ is trying the patch.
Note: The patchset #2 "Edit commit message" sent to CQ was uploaded after this CL was CR+1-ed.
Reviewer, please verify there is nothing unexpected https://chromium-review.googlesource.com/c/2550943/2
Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/chromium-review.googlesource.com/2550943/2
Bot data: {"action": "start", "triggered_at": "2020-11-19T18:47:00.0Z", "revision": "e3bc35798077fbe89538d6833d5c8caf0334e434"}
Commit Bot (Gerrit)
Commit Bot submitted this change.
[benchmarking] Update signature of CustomizeOptions method of Benchmark class
We will remove the FindBrowser call in CustomizeOptions, in order to avoid the FindBrowser to be called twice during RunBenchmark.
This CL updates the signature of the CustomizaOptions of the parent class in Telemetry.
We will have another CL to update the child class in Perf repo, and then a last CL to update the caller on Telemetry. More details on:
crbug/1149275#c6
Bug: chromium:1149275
Change-Id: I8d6f20c72548635b22b18c11a5f0dcf67ef27e4c
Reviewed-on: https://chromium-review.googlesource.com/c/catapult/+/2550943
Auto-Submit: Wenbin Zhang <wenbi...@google.com>
Commit-Queue: Wenbin Zhang <wenbi...@google.com>
Reviewed-by: John Chen <john...@chromium.org>
---
M telemetry/telemetry/benchmark.py
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/telemetry/telemetry/benchmark.py b/telemetry/telemetry/benchmark.py
index 7963ec4..d28f341 100644
--- a/telemetry/telemetry/benchmark.py
+++ b/telemetry/telemetry/benchmark.py
@@ -130,7 +130,7 @@
def ProcessCommandLineArgs(cls, parser, args):
pass
- def CustomizeOptions(self, finder_options):
+ def CustomizeOptions(self, finder_options, possible_browser=None):
"""Add options that are required by this benchmark."""
def GetBugComponents(self):
To view, visit change 2550943. To unsubscribe, or for help writing mail filters, visit settings.