Add script for PGO for WebView [chromium/src : main]
Mateusz Zbikowski (Gerrit)
Mateusz Zbikowski voted and added 4 comments![]( "Open in Gerrit")
Votes added by Mateusz Zbikowski
| Code-Review | +1 |
4 comments
LGTM with comments.
As for the presubmit failures, I hope this is just a case of needing a rebase.
data_deps += [ "//clank/android_webview:system_webview_google${_webview_bitness_if_needed}_bundle" ]
} else {
data_deps += [
"//android_webview:system_webview${_webview_bitness_if_needed}_bundle",Optional: instead, we might want to define separate targets - the internal one in clank, and add it through `TELEMETRY_CLANK_BROWSER_TARGET_SUFFIXES` - this might be cleaner and more consistent with prior art.
python_library("generate_profile_py") {
testonly = true
pydeps_file = "//tools/pgo/generate_profile.pydeps"
data = [ "//.vpython3" ]
}I think we need all this too (+ the pydeps file itself, and the deps on the python_library target in our `generate_profile_webview_test`). If you've been running this locally then you'll have all the required files, but without these entries I am guessing they would not be passed to the `generate_profile` swarming task.
installer_path = f'{args.outputdir}/bin/system_webview_google_64_32_bundle'As discussed, can we have an arg for that? It can default to this value but that would allow running the script without an internal checkout.
Related details
- Peter Wen
- Ziad Youssef
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |