Remove the last remnants of Syzygy build configuration. [chromium/src : master]

Sigurður Ásgeirsson (Gerrit)

unread,

Aug 2, 2018, 11:11:58 AM8/2/18

to Chris Hamilton, syzyg...@chromium.org, Nico Weber

Sigurður Ásgeirsson would like Chris Hamilton to review this change.

Remove the last remnants of Syzygy build configuration.

Bug: 821764
Change-Id: Ie09082382f1a65524cb849ac86a859b2d8101e75
---
M DEPS
D build/get_syzygy_binaries.py
2 files changed, 0 insertions(+), 544 deletions(-)

To view, visit change 1160599. To unsubscribe, or for help writing mail filters, visit settings.

Sigurður Ásgeirsson (Gerrit)

unread,

Aug 2, 2018, 11:12:16 AM8/2/18

to syzyg...@chromium.org, Chris Hamilton, Nico Weber, Commit Bot, chromium...@chromium.org

Hey Chris,

I think this ought to be safe now, as it seems LLD is the default. Let's do that wake!

Siggi

View Change

To view, visit change 1160599. To unsubscribe, or for help writing mail filters, visit settings.

Nico Weber (Gerrit)

unread,

Aug 2, 2018, 11:14:15 AM8/2/18

to Sigurður Ásgeirsson, syzyg...@chromium.org, Nico Weber, Chris Hamilton, Nico Weber, Commit Bot, chromium...@chromium.org

Probably should remove https://cs.chromium.org/chromium/src/tools/determinism/remove_build_metadata.py?type=cs&q=zap_timestamp&sq=package:chromium&g=0&l=84 too.

Add 804926 to bug line as well.

View Change

To view, visit change 1160599. To unsubscribe, or for help writing mail filters, visit settings.

Nico Weber (Gerrit)

unread,

Aug 2, 2018, 11:15:32 AM8/2/18

to Sigurður Ásgeirsson, syzyg...@chromium.org, Nico Weber, Chris Hamilton, Nico Weber, Commit Bot, chromium...@chromium.org

alternatively, could landhttps://chromium-review.googlesource.com/c/chromium/src/+/1108185

View Change

To view, visit change 1160599. To unsubscribe, or for help writing mail filters, visit settings.

Nico Weber (Gerrit)

unread,

Aug 2, 2018, 11:15:39 AM8/2/18

to Sigurður Ásgeirsson, syzyg...@chromium.org, Nico Weber, Chris Hamilton, Nico Weber, Commit Bot, chromium...@chromium.org

https://chromium-review.googlesource.com/c/chromium/src/+/1108185

View Change

To view, visit change 1160599. To unsubscribe, or for help writing mail filters, visit settings.

Sigurður Ásgeirsson (Gerrit)

unread,

Aug 2, 2018, 11:20:55 AM8/2/18

to syzyg...@chromium.org, Nico Weber, Chris Hamilton, Nico Weber, Commit Bot, chromium...@chromium.org

Patch Set 1:
https://chromium-review.googlesource.com/c/chromium/src/+/1108185

Yeah, please do land this one - I'll abandon mine.

View Change

To view, visit change 1160599. To unsubscribe, or for help writing mail filters, visit settings.

Sigurður Ásgeirsson (Gerrit)

unread,

Aug 2, 2018, 11:21:24 AM8/2/18

to syzyg...@chromium.org, Nico Weber, Chris Hamilton, Nico Weber, Commit Bot, chromium...@chromium.org

Sigurður Ásgeirsson abandoned this change.

View Change

Abandoned

Nico's doing this in https://chromium-review.googlesource.com/c/chromium/src/+/1108185

To view, visit change 1160599. To unsubscribe, or for help writing mail filters, visit settings.

Sigurður Ásgeirsson

unread,

Aug 2, 2018, 11:23:18 AM8/2/18

to chr...@chromium.org, tha...@chromium.org, tha...@google.com, ger...@eemailme.com, commi...@chromium.org, chromium...@chromium.org, syzyg...@chromium.org, stef...@gmail.com

Uh, Seb's doing this.

--
You received this message because you are subscribed to the Google Groups "syzygy-team" group.
To unsubscribe from this group and stop receiving emails from it, send an email to syzygy-team...@chromium.org.
For more options, visit https://groups.google.com/a/chromium.org/d/optout.

Reply all

Reply to author

Forward