Remove zap_timestamp and the Syzygy deps [chromium/src : master]

4 views
Skip to first unread message

Commit Bot (Gerrit)

unread,
Aug 2, 2018, 1:37:39 PM8/2/18
to Sébastien Marchand, syzyg...@chromium.org, Nico Weber, Sigurður Ásgeirsson, chromium...@chromium.org

RevisionConflictException: Failed to submit 1 change due to the following problems:
Change 1108185: Change 1108185 is work in progress

View Change

    To view, visit change 1108185. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: chromium/src
    Gerrit-Branch: master
    Gerrit-Change-Id: I3c6e4ce0793997823b89978cf7eda5b3a26399b8
    Gerrit-Change-Number: 1108185
    Gerrit-PatchSet: 3
    Gerrit-Owner: Sébastien Marchand <sebma...@chromium.org>
    Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
    Gerrit-Reviewer: Sigurður Ásgeirsson <si...@chromium.org>
    Gerrit-Reviewer: Sébastien Marchand <sebma...@chromium.org>
    Gerrit-CC: Commit Bot <commi...@chromium.org>
    Gerrit-Comment-Date: Thu, 02 Aug 2018 17:37:38 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: No
    Gerrit-MessageType: comment

    Sigurður Ásgeirsson

    unread,
    Aug 2, 2018, 1:41:35 PM8/2/18
    to change-...@chromium-review.googlesource.com, Sébastien Marchand, syzyg...@chromium.org, Nico Weber, chromium...@chromium.org
    Seb - I think you need to send this for review before it'll submit?

    Sigurður Ásgeirsson (Gerrit)

    unread,
    Aug 2, 2018, 1:41:38 PM8/2/18
    to Sébastien Marchand, syzyg...@chromium.org, Nico Weber, Commit Bot, chromium...@chromium.org

    Seb - I think you need to send this for review before it'll submit?

    View Change

      To view, visit change 1108185. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: chromium/src
      Gerrit-Branch: master
      Gerrit-Change-Id: I3c6e4ce0793997823b89978cf7eda5b3a26399b8
      Gerrit-Change-Number: 1108185
      Gerrit-PatchSet: 3
      Gerrit-Owner: Sébastien Marchand <sebma...@chromium.org>
      Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
      Gerrit-Reviewer: Sigurður Ásgeirsson <si...@chromium.org>
      Gerrit-Reviewer: Sébastien Marchand <sebma...@chromium.org>
      Gerrit-CC: Commit Bot <commi...@chromium.org>
      Gerrit-Comment-Date: Thu, 02 Aug 2018 17:41:35 +0000

      Sébastien Marchand (Gerrit)

      unread,
      Aug 2, 2018, 1:45:11 PM8/2/18
      to syzyg...@chromium.org, Nico Weber, Sigurður Ásgeirsson, Commit Bot, chromium...@chromium.org

      This change is ready for review.

      Patch set 3:Commit-Queue +2

      View Change

        To view, visit change 1108185. To unsubscribe, or for help writing mail filters, visit settings.

        Gerrit-Project: chromium/src
        Gerrit-Branch: master
        Gerrit-Change-Id: I3c6e4ce0793997823b89978cf7eda5b3a26399b8
        Gerrit-Change-Number: 1108185
        Gerrit-PatchSet: 3
        Gerrit-Owner: Sébastien Marchand <sebma...@chromium.org>
        Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
        Gerrit-Reviewer: Sigurður Ásgeirsson <si...@chromium.org>
        Gerrit-Reviewer: Sébastien Marchand <sebma...@chromium.org>
        Gerrit-CC: Commit Bot <commi...@chromium.org>
        Gerrit-Comment-Date: Thu, 02 Aug 2018 17:45:08 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        Gerrit-MessageType: comment

        Commit Bot (Gerrit)

        unread,
        Aug 2, 2018, 1:48:59 PM8/2/18
        to Sébastien Marchand, syzyg...@chromium.org, Nico Weber, Sigurður Ásgeirsson, chromium...@chromium.org

        Commit Bot merged this change.

        View Change

        Approvals: Nico Weber: Looks good to me Sigurður Ásgeirsson: Looks good to me Sébastien Marchand: Commit
        Remove zap_timestamp and the Syzygy deps

        This isn't needed anymore as we're now using LLD.

        Bug: 804926, 821764
        Change-Id: I3c6e4ce0793997823b89978cf7eda5b3a26399b8
        Reviewed-on: https://chromium-review.googlesource.com/1108185
        Reviewed-by: Sigurður Ásgeirsson <si...@chromium.org>
        Reviewed-by: Nico Weber <tha...@chromium.org>
        Commit-Queue: Sébastien Marchand <sebma...@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#580239}
        ---
        M DEPS
        D build/get_syzygy_binaries.py
        M tools/determinism/deterministic_build_blacklist.json
        M tools/determinism/remove_build_metadata.py
        4 files changed, 2 insertions(+), 587 deletions(-)


        To view, visit change 1108185. To unsubscribe, or for help writing mail filters, visit settings.

        Gerrit-Project: chromium/src
        Gerrit-Branch: master
        Gerrit-Change-Id: I3c6e4ce0793997823b89978cf7eda5b3a26399b8
        Gerrit-Change-Number: 1108185
        Gerrit-PatchSet: 4
        Gerrit-Owner: Sébastien Marchand <sebma...@chromium.org>
        Gerrit-Reviewer: Commit Bot <commi...@chromium.org>
        Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
        Gerrit-Reviewer: Sigurður Ásgeirsson <si...@chromium.org>
        Gerrit-Reviewer: Sébastien Marchand <sebma...@chromium.org>
        Gerrit-MessageType: merged
        Reply all
        Reply to author
        Forward
        0 new messages