Is "runtime_flag" supposed to work for alias?

27 views
Skip to first unread message

Koji Ishii

unread,
Jun 27, 2017, 10:08:41 AM6/27/17
to style-dev, Quinten Yearsley
Hi all, a novice question.

When CSSProperties.json5 has:
 {
      name: "line-break",
      alias_for: "-webkit-line-break",
      runtime_flag: "CSSLineBreak",
 },
Should this alias be only valid when CSSLineBreak flag is set?

I do not see this alias listed in LayoutTests/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt, but the property seems to work in M58 stable.

I added this alias to import wpt tests by following crbug.com/614955 guidance, but I'm afraid that I intentionally shipped this according to a Japanese stackoverflow article and my own tests, unless I'm mistaken somewhere.

From this, I'm guessing "runtime_flag" is supposed to be ignored for aliases, but experts confirmation would be appreciated.

Eddy Mead

unread,
Jun 27, 2017, 11:58:07 PM6/27/17
to Koji Ishii, style-dev, Quinten Yearsley, sh...@chromium.org
Hi Koji,

As per the documentation for runtime_flag in CSSProperties.json5, runtime_flag is not supported for alias_for, sorry :/ I've asked shend@ to make a CL to throw an error if those flags are set together so that we don't accidentally ship something like this again. 

In the mean time, what do you want to do with the line-break property?

Cheers,
Eddy

--
You received this message because you are subscribed to the Google Groups "style-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to style-dev+unsubscribe@chromium.org.
To post to this group, send email to styl...@chromium.org.
To view this discussion on the web, visit https://groups.google.com/a/chromium.org/d/msgid/style-dev/CACQRE%2BR_9AeoNtjc87PonbwaM4JHzfCXzyPTbq5F8dMP5KY-og%40mail.gmail.com.

Koji Ishii

unread,
Jun 28, 2017, 12:58:51 AM6/28/17
to Eddy Mead, Koji Ishii, style-dev, Quinten Yearsley, sh...@chromium.org
Thank you Eddy for the confirmation, and the plan to avoid this happening again.

Well, we were to unprefix it anyway, so I'll go the post facto intent-to-ship process.

Alan Cutter

unread,
Jun 28, 2017, 2:50:46 AM6/28/17
to style-dev, qyea...@chromium.org
Thanks for bringing it to our attention that we don't list property aliases in our webexposed tests!
I have created a patch to fix this: https://chromium-review.googlesource.com/c/551400

PhistucK

unread,
Jun 28, 2017, 2:59:43 AM6/28/17
to Alan Cutter, style-dev, Quinten Yearsley
Woo hoo!


PhistucK

--
You received this message because you are subscribed to the Google Groups "style-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to style-dev+unsubscribe@chromium.org.
To post to this group, send email to styl...@chromium.org.

Darren Shen

unread,
Jun 28, 2017, 3:22:41 AM6/28/17
to PhistucK, Alan Cutter, style-dev, Quinten Yearsley
I've also created a patch to prevent runtime flags from being used for aliases: https://chromium-review.googlesource.com/c/551877/

On Wed, Jun 28, 2017 at 4:59 PM PhistucK <phis...@gmail.com> wrote:
Woo hoo!


PhistucK

On Wed, Jun 28, 2017 at 9:50 AM, Alan Cutter <alanc...@chromium.org> wrote:
Thanks for bringing it to our attention that we don't list property aliases in our webexposed tests!
I have created a patch to fix this: https://chromium-review.googlesource.com/c/551400

On Wednesday, 28 June 2017 00:08:41 UTC+10, Koji Ishii wrote:
Hi all, a novice question.

When CSSProperties.json5 has:
 {
      name: "line-break",
      alias_for: "-webkit-line-break",
      runtime_flag: "CSSLineBreak",
 },
Should this alias be only valid when CSSLineBreak flag is set?

I do not see this alias listed in LayoutTests/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt, but the property seems to work in M58 stable.

I added this alias to import wpt tests by following crbug.com/614955 guidance, but I'm afraid that I intentionally shipped this according to a Japanese stackoverflow article and my own tests, unless I'm mistaken somewhere.

From this, I'm guessing "runtime_flag" is supposed to be ignored for aliases, but experts confirmation would be appreciated.

--
You received this message because you are subscribed to the Google Groups "style-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to style-dev+...@chromium.org.

To post to this group, send email to styl...@chromium.org.

--
You received this message because you are subscribed to the Google Groups "style-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to style-dev+...@chromium.org.

To post to this group, send email to styl...@chromium.org.

PhistucK

unread,
Jun 28, 2017, 3:26:24 AM6/28/17
to Darren Shen, Alan Cutter, style-dev, Quinten Yearsley
Do you have an idea of how many CSS properties were/are accidentally shipped this way?


PhistucK

On Wed, Jun 28, 2017 at 10:22 AM, Darren Shen <sh...@chromium.org> wrote:
I've also created a patch to prevent runtime flags from being used for aliases: https://chromium-review.googlesource.com/c/551877/

On Wed, Jun 28, 2017 at 4:59 PM PhistucK <phis...@gmail.com> wrote:
Woo hoo!


PhistucK

On Wed, Jun 28, 2017 at 9:50 AM, Alan Cutter <alanc...@chromium.org> wrote:
Thanks for bringing it to our attention that we don't list property aliases in our webexposed tests!
I have created a patch to fix this: https://chromium-review.googlesource.com/c/551400

On Wednesday, 28 June 2017 00:08:41 UTC+10, Koji Ishii wrote:
Hi all, a novice question.

When CSSProperties.json5 has:
 {
      name: "line-break",
      alias_for: "-webkit-line-break",
      runtime_flag: "CSSLineBreak",
 },
Should this alias be only valid when CSSLineBreak flag is set?

I do not see this alias listed in LayoutTests/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt, but the property seems to work in M58 stable.

I added this alias to import wpt tests by following crbug.com/614955 guidance, but I'm afraid that I intentionally shipped this according to a Japanese stackoverflow article and my own tests, unless I'm mistaken somewhere.

From this, I'm guessing "runtime_flag" is supposed to be ignored for aliases, but experts confirmation would be appreciated.

--
You received this message because you are subscribed to the Google Groups "style-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to style-dev+unsubscribe@chromium.org.

To post to this group, send email to styl...@chromium.org.

--
You received this message because you are subscribed to the Google Groups "style-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to style-dev+unsubscribe@chromium.org.

To post to this group, send email to styl...@chromium.org.

Darren Shen

unread,
Jun 28, 2017, 3:29:38 AM6/28/17
to PhistucK, Alan Cutter, style-dev, Quinten Yearsley
Only line-break seems to have triggered the new assert I put in.

On Wed, Jun 28, 2017 at 5:26 PM PhistucK <phis...@gmail.com> wrote:
Do you have an idea of how many CSS properties were/are accidentally shipped this way?


PhistucK
On Wed, Jun 28, 2017 at 10:22 AM, Darren Shen <sh...@chromium.org> wrote:
I've also created a patch to prevent runtime flags from being used for aliases: https://chromium-review.googlesource.com/c/551877/

On Wed, Jun 28, 2017 at 4:59 PM PhistucK <phis...@gmail.com> wrote:
Woo hoo!


PhistucK

On Wed, Jun 28, 2017 at 9:50 AM, Alan Cutter <alanc...@chromium.org> wrote:
Thanks for bringing it to our attention that we don't list property aliases in our webexposed tests!
I have created a patch to fix this: https://chromium-review.googlesource.com/c/551400

On Wednesday, 28 June 2017 00:08:41 UTC+10, Koji Ishii wrote:
Hi all, a novice question.

When CSSProperties.json5 has:
 {
      name: "line-break",
      alias_for: "-webkit-line-break",
      runtime_flag: "CSSLineBreak",
 },
Should this alias be only valid when CSSLineBreak flag is set?

I do not see this alias listed in LayoutTests/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt, but the property seems to work in M58 stable.

I added this alias to import wpt tests by following crbug.com/614955 guidance, but I'm afraid that I intentionally shipped this according to a Japanese stackoverflow article and my own tests, unless I'm mistaken somewhere.

From this, I'm guessing "runtime_flag" is supposed to be ignored for aliases, but experts confirmation would be appreciated.

--
You received this message because you are subscribed to the Google Groups "style-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to style-dev+...@chromium.org.

To post to this group, send email to styl...@chromium.org.

--
You received this message because you are subscribed to the Google Groups "style-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to style-dev+...@chromium.org.

To post to this group, send email to styl...@chromium.org.

--
You received this message because you are subscribed to the Google Groups "style-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to style-dev+...@chromium.org.

To post to this group, send email to styl...@chromium.org.

Eddy Mead

unread,
Jun 28, 2017, 3:31:52 AM6/28/17
to Darren Shen, PhistucK, Alan Cutter, style-dev, Quinten Yearsley
Yep, AFAICT it seems to be the only one.

Woo hoo!


PhistucK

To unsubscribe from this group and stop receiving emails from it, send an email to style-dev+unsubscribe@chromium.org.

To post to this group, send email to styl...@chromium.org.

--
You received this message because you are subscribed to the Google Groups "style-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to style-dev+unsubscribe@chromium.org.

To post to this group, send email to styl...@chromium.org.

--
You received this message because you are subscribed to the Google Groups "style-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to style-dev+unsubscribe@chromium.org.

--
You received this message because you are subscribed to the Google Groups "style-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to style-dev+unsubscribe@chromium.org.

To post to this group, send email to styl...@chromium.org.
Reply all
Reply to author
Forward
0 new messages