explanatory doc for style code?
30 views
Skip to first unread message
fer...@chromium.org
Feb 16, 2018, 12:45:12 AM2/16/18
to style-dev, Takayoshi Kochi
I started writing
but then kochi@ suggested that there may already be one. I'm thinking something like
F
Fergal Daly
Feb 16, 2018, 2:24:19 AM2/16/18
to style-dev, Eric Willigers, Takayoshi Kochi
ericwilligers@ pointed me to https://goo.gl/3ane6s and https://goo.gl/z0Z9gn for style invalidation. I also found
https://chromium.googlesource.com/chromium/src/+/lkcr/third_party/WebKit/Source/core/style/stylerecalc.md
and https://crbug.com/795634 which makes me think there isn't something more general yet,
F
--
You received this message because you are subscribed to a topic in the Google Groups "style-dev" group.
To unsubscribe from this topic, visit https://groups.google.com/a/chromium.org/d/topic/style-dev/lcrHTyMFsfI/unsubscribe.
To unsubscribe from this group and all its topics, send an email to style-dev+unsubscribe@chromium.org.
To post to this group, send email to styl...@chromium.org.
To view this discussion on the web, visit https://groups.google.com/a/chromium.org/d/msgid/style-dev/b160b82c-e979-4785-93f2-83d188ca083e%40chromium.org.
Rune Lillesveen
Feb 16, 2018, 6:33:20 AM2/16/18
to Fergal Daly, style-dev, Eric Willigers, Takayoshi Kochi
No, there's only bits and pieces of documentation for style, not a full overview. If you write documentation, please add .md files to the repo.
On Fri, Feb 16, 2018 at 8:24 AM Fergal Daly <fer...@chromium.org> wrote:
ericwilligers@ pointed me to https://goo.gl/3ane6s and https://goo.gl/z0Z9gn for style invalidation. I also foundhttps://chromium.googlesource.com/chromium/src/+/lkcr/third_party/WebKit/Source/core/style/stylerecalc.mdand https://crbug.com/795634 which makes me think there isn't something more general yet,FOn 16 February 2018 at 14:45, <fer...@chromium.org> wrote:I started writingbut then kochi@ suggested that there may already be one. I'm thinking something likeF
--
You received this message because you are subscribed to a topic in the Google Groups "style-dev" group.
To unsubscribe from this topic, visit https://groups.google.com/a/chromium.org/d/topic/style-dev/lcrHTyMFsfI/unsubscribe.
To unsubscribe from this group and all its topics, send an email to style-dev+...@chromium.org.
To post to this group, send email to styl...@chromium.org.
To view this discussion on the web, visit https://groups.google.com/a/chromium.org/d/msgid/style-dev/b160b82c-e979-4785-93f2-83d188ca083e%40chromium.org.
--
You received this message because you are subscribed to the Google Groups "style-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to style-dev+...@chromium.org.
To post to this group, send email to styl...@chromium.org.
To view this discussion on the web, visit https://groups.google.com/a/chromium.org/d/msgid/style-dev/CAAozHLkJiPjCy%2B8LN5n-%2Bm%3D1zD4cRMEj8EWNmRaomCpspne%3DsQ%40mail.gmail.com.
Rune Lillesveen
Fergal Daly
Feb 21, 2018, 1:54:43 AM2/21/18
to Rune Lillesveen, style-dev, Eric Willigers, Takayoshi Kochi
On 16 February 2018 at 20:33, Rune Lillesveen <fut...@chromium.org> wrote:
No, there's only bits and pieces of documentation for style, not a full overview. If you write documentation, please add .md files to the repo.
This doc is now in a reviewable state. It describes the process of collecting all of the matching rules for all of the elements in the doc
Please take a look, add suggestions, correct errors, point out oversights etc. Then I will send a CL to submit it as an MD.
If people would rather review/comment on an MD, I'm happy to convert it first and send out a CL but docs seems more suitable,
F
On Fri, Feb 16, 2018 at 8:24 AM Fergal Daly <fer...@chromium.org> wrote:
ericwilligers@ pointed me to https://goo.gl/3ane6s and https://goo.gl/z0Z9gn for style invalidation. I also foundhttps://chromium.googlesource.com/chromium/src/+/lkcr/third_party/WebKit/Source/core/style/stylerecalc.mdand https://crbug.com/795634 which makes me think there isn't something more general yet,FOn 16 February 2018 at 14:45, <fer...@chromium.org> wrote:I started writingbut then kochi@ suggested that there may already be one. I'm thinking something likeF
--
You received this message because you are subscribed to a topic in the Google Groups "style-dev" group.
To unsubscribe from this topic, visit https://groups.google.com/a/chromium.org/d/topic/style-dev/lcrHTyMFsfI/unsubscribe.
To unsubscribe from this group and all its topics, send an email to style-dev+unsubscribe@chromium.org.
--
To post to this group, send email to styl...@chromium.org.
To view this discussion on the web, visit https://groups.google.com/a/chromium.org/d/msgid/style-dev/b160b82c-e979-4785-93f2-83d188ca083e%40chromium.org.
You received this message because you are subscribed to the Google Groups "style-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to style-dev+unsubscribe@chromium.org.
To post to this group, send email to styl...@chromium.org.
To view this discussion on the web, visit https://groups.google.com/a/chromium.org/d/msgid/style-dev/CAAozHLkJiPjCy%2B8LN5n-%2Bm%3D1zD4cRMEj8EWNmRaomCpspne%3DsQ%40mail.gmail.com.
----Rune Lillesveen
You received this message because you are subscribed to a topic in the Google Groups "style-dev" group.
To unsubscribe from this topic, visit https://groups.google.com/a/chromium.org/d/topic/style-dev/lcrHTyMFsfI/unsubscribe.
To unsubscribe from this group and all its topics, send an email to style-dev+unsubscribe@chromium.org.
To post to this group, send email to styl...@chromium.org.
To view this discussion on the web, visit https://groups.google.com/a/chromium.org/d/msgid/style-dev/CACuPfeT4VVYbOpxrhn1X4n2Hc7PX6Gj1Y9BF2f5hkN6yZwfRyQ%40mail.gmail.com.
Takayoshi Kochi
Feb 28, 2018, 12:15:14 AM2/28/18
to Fergal Daly, Rune Lillesveen, style-dev, Eric Willigers
BTW, this is not specific to the current Blink's implementation of style,
I think this "How browsers work" document:
is still a good read to get the general idea of how rendering engine works.
Also, Mozilla's blog post about their new style engine (stylo)
explains what complicates the style engine and how their new system overcame
the difficulties.
--
Takayoshi Kochi
Fergal Daly
Feb 28, 2018, 11:47:37 PM2/28/18
to Takayoshi Kochi, Rune Lillesveen, style-dev, Eric Willigers
Thanks they're good docs. Rune is reviewing this CL to add some more class-level docs and an overview
F
Reply all
Reply to author
Forward
0 new messages