Issue 1490618 in chromium: Support light-dark() function for color values

[futhark via monorail]

Updates:
Cc: styl...@chromium.org

Comment #5 on issue 1490618 by fut...@chromium.org: Support light-dark() function for color values
https://bugs.chromium.org/p/chromium/issues/detail?id=1490618#c5

Issue 1490636 has been merged into this issue.

--
You received this message because:
1. You were specifically CC'd on the issue

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

Reply to this email to add a comment or make updates.

[bramus via monorail]

Updates:
Cc: fut...@chromium.org

Comment #6 on issue 1490618 by bra...@chromium.org: Support light-dark() function for color values
https://bugs.chromium.org/p/chromium/issues/detail?id=1490618#c6

Issue 1471662 has been merged into this issue.

[futhark via monorail]

Updates:
Owner: fut...@chromium.org

Comment #7 on issue 1490618 by fut...@chromium.org: Support light-dark() function for color values
https://bugs.chromium.org/p/chromium/issues/detail?id=1490618#c7

(No comment was entered for this change.)

[futhark via monorail]

Updates:
Labels: Pri-2

Comment #8 on issue 1490618 by fut...@chromium.org: Support light-dark() function for color values
https://bugs.chromium.org/p/chromium/issues/detail?id=1490618#c8

[futhark via monorail]

Updates:
Status: Started

Comment #9 on issue 1490618 by fut...@chromium.org: Support light-dark() function for color values
https://bugs.chromium.org/p/chromium/issues/detail?id=1490618#c9

[Git Watcher via monorail]

Comment #10 on issue 1490618 by Git Watcher: Support light-dark() function for color values
https://bugs.chromium.org/p/chromium/issues/detail?id=1490618#c10

The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/ad1bc8e13485222b29d5d7fdc9d3307bf7769172

commit ad1bc8e13485222b29d5d7fdc9d3307bf7769172
Author: Rune Lillesveen <fut...@chromium.org>
Date: Wed Jan 31 08:45:30 2024

Implement support for light-dark() color function

Specification:
https://drafts.csswg.org/css-color-5/#light-dark

Change all -internal-light-dark() instances in UA sheets to
light-dark(). Also use light-dark() for UA-only support for image
values, but guard use with UA mode check.

Coincidentally fixes a bug where -internal-light-dark(GreyText, ...)
was forced, but GreyText was kept as a system color. This is why the
expectation pngs change. Also covered by the new unit test.

Bug: 1490618
Change-Id: Iea21d31733332f9e3d56e00dda74ebd4e5662cea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5245470
Reviewed-by: Anders Hartvoll Ruud <and...@chromium.org>
Commit-Queue: Rune Lillesveen <fut...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1254396}

[modify] https://crrev.com/ad1bc8e13485222b29d5d7fdc9d3307bf7769172/third_party/blink/renderer/core/css/resolver/style_builder_converter.cc
[modify] https://crrev.com/ad1bc8e13485222b29d5d7fdc9d3307bf7769172/third_party/blink/renderer/core/css/parser/css_property_parser_test.cc
[modify] https://crrev.com/ad1bc8e13485222b29d5d7fdc9d3307bf7769172/third_party/blink/renderer/core/css/properties/longhands/longhands_custom.cc
[modify] https://crrev.com/ad1bc8e13485222b29d5d7fdc9d3307bf7769172/third_party/blink/renderer/core/html/resources/html.css
[modify] https://crrev.com/ad1bc8e13485222b29d5d7fdc9d3307bf7769172/third_party/blink/web_tests/platform/linux/virtual/controls-refresh-hc/fast/forms/color-scheme/calendar-picker/date-picker-disabled-values-expected.png
[modify] https://crrev.com/ad1bc8e13485222b29d5d7fdc9d3307bf7769172/third_party/blink/web_tests/TestExpectations
[modify] https://crrev.com/ad1bc8e13485222b29d5d7fdc9d3307bf7769172/third_party/blink/renderer/core/css/style_engine_test.cc
[modify] https://crrev.com/ad1bc8e13485222b29d5d7fdc9d3307bf7769172/third_party/blink/web_tests/external/wpt/html/semantics/forms/the-selectlist-element/selectlist-option-arbitrary-content-displayed-ref.tentative.html
[modify] https://crrev.com/ad1bc8e13485222b29d5d7fdc9d3307bf7769172/third_party/blink/renderer/core/html/resources/selectlist.css
[modify] https://crrev.com/ad1bc8e13485222b29d5d7fdc9d3307bf7769172/third_party/blink/renderer/platform/runtime_enabled_features.json5
[delete] https://crrev.com/af08f953061df38f2056247b3f8bc7f3c4e93fa9/third_party/blink/web_tests/external/wpt/css/css-color/light-dark-basic-expected.txt
[modify] https://crrev.com/ad1bc8e13485222b29d5d7fdc9d3307bf7769172/third_party/blink/renderer/core/css/css_value_keywords.json5
[modify] https://crrev.com/ad1bc8e13485222b29d5d7fdc9d3307bf7769172/third_party/blink/web_tests/platform/win/virtual/controls-refresh-hc/fast/forms/color-scheme/calendar-picker/date-picker-disabled-values-expected.png
[modify] https://crrev.com/ad1bc8e13485222b29d5d7fdc9d3307bf7769172/third_party/blink/renderer/core/css/css.dict
[add] https://crrev.com/ad1bc8e13485222b29d5d7fdc9d3307bf7769172/third_party/blink/web_tests/external/wpt/css/css-color/light-dark-currentcolor-in-color.html
[modify] https://crrev.com/ad1bc8e13485222b29d5d7fdc9d3307bf7769172/third_party/blink/renderer/core/css/css_light_dark_value_pair_test.cc
[modify] https://crrev.com/ad1bc8e13485222b29d5d7fdc9d3307bf7769172/third_party/blink/renderer/core/css/view-source.css
[modify] https://crrev.com/ad1bc8e13485222b29d5d7fdc9d3307bf7769172/third_party/blink/renderer/core/css/css_light_dark_value_pair.cc
[modify] https://crrev.com/ad1bc8e13485222b29d5d7fdc9d3307bf7769172/third_party/blink/renderer/core/css/resolver/style_resolver.h
[modify] https://crrev.com/ad1bc8e13485222b29d5d7fdc9d3307bf7769172/third_party/blink/renderer/core/style/computed_style_test.cc
[modify] https://crrev.com/ad1bc8e13485222b29d5d7fdc9d3307bf7769172/third_party/blink/renderer/modules/media_controls/resources/mediaControls.css
[modify] https://crrev.com/ad1bc8e13485222b29d5d7fdc9d3307bf7769172/third_party/blink/renderer/core/css/properties/css_parsing_utils.cc
[modify] https://crrev.com/ad1bc8e13485222b29d5d7fdc9d3307bf7769172/third_party/blink/renderer/core/html/forms/resources/suggestion_picker_dark.css
[modify] https://crrev.com/ad1bc8e13485222b29d5d7fdc9d3307bf7769172/third_party/blink/web_tests/platform/mac/virtual/controls-refresh-hc/fast/forms/color-scheme/calendar-picker/date-picker-disabled-values-expected.png

[Git Watcher via monorail]

Comment #11 on issue 1490618 by Git Watcher: Support light-dark() function for color values
https://bugs.chromium.org/p/chromium/issues/detail?id=1490618#c11

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src/+/e3cfad827fd4d114805a30298f3ac84d0289f06a

commit e3cfad827fd4d114805a30298f3ac84d0289f06a
Author: Rune Lillesveen <fut...@chromium.org>
Date: Wed Jan 31 11:52:00 2024

Ship light-dark() for colors

I2S:

https://groups.google.com/a/chromium.org/g/blink-dev/c/IsXAWrFLUHE

Bug: 1490618
Change-Id: I3599de4d6dff3ef5c103a60e3d8e60f7535b2e9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5252028
Auto-Submit: Rune Lillesveen <fut...@chromium.org>

Reviewed-by: Anders Hartvoll Ruud <and...@chromium.org>

Commit-Queue: Anders Hartvoll Ruud <and...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1254449}

[modify] https://crrev.com/e3cfad827fd4d114805a30298f3ac84d0289f06a/third_party/blink/renderer/platform/runtime_enabled_features.json5

[futhark via monorail]

Updates:
Status: Fixed

Comment #12 on issue 1490618 by fut...@chromium.org: Support light-dark() function for color values
https://bugs.chromium.org/p/chromium/issues/detail?id=1490618#c12

(No comment was entered for this change.)