Issue 320370 in chromium: Implement page-margin-box @rules

[mstensho via monorail]

Updates:
Cc: styl...@chromium.org

Comment #41 on issue 320370 by mste...@chromium.org: Implement page-margin-box @rules
https://bugs.chromium.org/p/chromium/issues/detail?id=320370#c41

Issue 1510398 has been merged into this issue.

--
You received this message because:
1. You were specifically CC'd on the issue

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

Reply to this email to add a comment or make updates.

[Git Watcher via monorail]

Comment #42 on issue 320370 by Git Watcher: Implement page-margin-box @rules
https://bugs.chromium.org/p/chromium/issues/detail?id=320370#c42

The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/375b14d2921d70e84878cf75f399d3fe1909583c

commit 375b14d2921d70e84878cf75f399d3fe1909583c
Author: Steinar H. Gunderson <se...@chromium.org>
Date: Fri Jan 19 21:01:47 2024

[css-page-3] Support @page margin at-rules

Parse subrules of @page that deal with page margin boxes
(e.g. @top-left).

This is for parsing (and serialization) only; the styles don't actually
do anything yet. It's unclear whether there is a fully defined
serialization spec for these.

We do not currently expose this through CSSOM, in part because it is
unclear what the interface should look like.

Bug: 320370
Fuchsia-Binary-Size: New functionality in the parser
Change-Id: I03e25631758a229ae0124d9fbdd816dfa4316568
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5189281
Commit-Queue: Steinar H Gunderson <se...@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <and...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1249487}

[modify] https://crrev.com/375b14d2921d70e84878cf75f399d3fe1909583c/third_party/blink/web_tests/external/wpt/css/css-page/parsing/margin-rules-001-expected.txt
[modify] https://crrev.com/375b14d2921d70e84878cf75f399d3fe1909583c/third_party/blink/renderer/core/css/parser/css_parser_impl.h
[modify] https://crrev.com/375b14d2921d70e84878cf75f399d3fe1909583c/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/375b14d2921d70e84878cf75f399d3fe1909583c/third_party/blink/renderer/core/css/style_rule.h
[modify] https://crrev.com/375b14d2921d70e84878cf75f399d3fe1909583c/third_party/blink/renderer/core/css/parser/at_rule_descriptor_parser.cc
[modify] https://crrev.com/375b14d2921d70e84878cf75f399d3fe1909583c/third_party/blink/renderer/core/css/style_rule.cc
[modify] https://crrev.com/375b14d2921d70e84878cf75f399d3fe1909583c/third_party/blink/renderer/core/css/parser/css_at_rule_id.h
[modify] https://crrev.com/375b14d2921d70e84878cf75f399d3fe1909583c/third_party/blink/renderer/core/css/parser/css_parser_impl.cc
[modify] https://crrev.com/375b14d2921d70e84878cf75f399d3fe1909583c/third_party/blink/renderer/core/css/parser/css_at_rule_id.cc
[modify] https://crrev.com/375b14d2921d70e84878cf75f399d3fe1909583c/third_party/blink/renderer/core/css/css_page_rule.cc
[modify] https://crrev.com/375b14d2921d70e84878cf75f399d3fe1909583c/third_party/blink/renderer/core/css/parser/css_property_parser.cc
[modify] https://crrev.com/375b14d2921d70e84878cf75f399d3fe1909583c/third_party/blink/public/mojom/use_counter/metrics/web_feature.mojom
[modify] https://crrev.com/375b14d2921d70e84878cf75f399d3fe1909583c/third_party/blink/web_tests/external/wpt/css/css-page/parsing/margin-rules-001.html
[modify] https://crrev.com/375b14d2921d70e84878cf75f399d3fe1909583c/third_party/blink/renderer/core/css/style_sheet_contents.cc
[add] https://crrev.com/375b14d2921d70e84878cf75f399d3fe1909583c/third_party/blink/web_tests/virtual/page-margin-boxes/external/wpt/css/css-page/parsing/margin-rules-001-expected.txt
[modify] https://crrev.com/375b14d2921d70e84878cf75f399d3fe1909583c/third_party/blink/renderer/core/css/css_page_rule_test.cc