Issue 1508033 in chromium: [WPT] New failures introduced in external/wpt/css by import https://crrev.com/c/5083719

[wpt-autoroller via monorail]

Status: Untriaged
Owner: ----
CC: styl...@chromium.org
Labels: Test-WebTest
Components: Blink>CSS
Pri: 3
Type: Bug

New issue 1508033 by wpt-aut...@chops-service-accounts.iam.gserviceaccount.com: [WPT] New failures introduced in external/wpt/css by import https://crrev.com/c/5083719
https://bugs.chromium.org/p/chromium/issues/detail?id=1508033

WPT import https://crrev.com/c/5083719 introduced new failures in external/wpt/css:

List of new failures:
[ Linux ] external/wpt/css/css-color/parsing/color-valid-rgb.html new failing tests: https://crrev.com/c/5083719/4/third_party/blink/web_tests/platform/linux/external/wpt/css/css-color/parsing/color-valid-rgb-expected.txt
[ Mac ] external/wpt/css/css-color/parsing/color-valid-rgb.html new failing tests: https://crrev.com/c/5083719/4/third_party/blink/web_tests/platform/mac/external/wpt/css/css-color/parsing/color-valid-rgb-expected.txt
[ Win10 ] external/wpt/css/css-color/parsing/color-valid-rgb.html new failing tests: https://crrev.com/c/5083719/4/third_party/blink/web_tests/platform/win10/external/wpt/css/css-color/parsing/color-valid-rgb-expected.txt
[ Linux ] external/wpt/css/selectors/parsing/parse-state.html new failing tests: https://crrev.com/c/5083719/4/third_party/blink/web_tests/platform/linux/external/wpt/css/selectors/parsing/parse-state-expected.txt
[ Mac ] external/wpt/css/selectors/parsing/parse-state.html new failing tests: https://crrev.com/c/5083719/4/third_party/blink/web_tests/platform/mac/external/wpt/css/selectors/parsing/parse-state-expected.txt
[ Win10 ] external/wpt/css/selectors/parsing/parse-state.html new failing tests: https://crrev.com/c/5083719/4/third_party/blink/web_tests/platform/win10/external/wpt/css/selectors/parsing/parse-state-expected.txt

Expectations or baseline files [0] have been automatically added for the failing results to keep the bots green. Please investigate the new failures and triage as appropriate.

Upstream changes imported:
https://github.com/web-platform-tests/wpt/compare/cce26e3757dcfd21629f3334072ce9c1292c4d9f...a83bf9a725f275854b37d31dc1708d08c5dd5670
[WPT] [CSP] Rewrite flaky inline-style-blocked: https://github.com/web-platform-tests/wpt/commit/a83bf9a725f275854b37d31dc1708d08c5dd5670
css-color : modern rgb supports mixed units (#43450): https://github.com/web-platform-tests/wpt/commit/21d329d43f75adef5fdf052dcd4bfaad40e8bc85 [affecting this directory]
compute-pressure: Ensure clean test exit: https://github.com/web-platform-tests/wpt/commit/da0a56526aa23f752fc0186b8cf22fa9f05e2fc8
WebKit export of https://bugs.webkit.org/show_bug.cgi?id=265160 (#43497): https://github.com/web-platform-tests/wpt/commit/3c7b862cc35c5517455771395f8d6e3c727243e6 [affecting this directory]
Fix progress function calculation: https://github.com/web-platform-tests/wpt/commit/94c20e8f17b32ff2adfefd87a1fea07189456be8 [affecting this directory]
allow :state() after ::part(): https://github.com/web-platform-tests/wpt/commit/5ddf095c380db657c000017e46dfebc45e93f682 [affecting this directory]

[0]: https://chromium.googlesource.com/chromium/src/+/HEAD/docs/testing/web_test_expectations.md

This bug was filed automatically due to a new WPT test failure for which you are marked an OWNER. If you do not want to receive these reports, please add "wpt { notify: NO }" to the relevant DIR_METADATA file.

--
You received this message because:
1. You were specifically CC'd on the issue

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

Reply to this email to add a comment or make updates.

[aaronhk via monorail]

Updates:
Blockedon: 1508413

Comment #1 on issue 1508033 by aar...@chromium.org: [WPT] New failures introduced in external/wpt/css by import https://crrev.com/c/5083719
https://bugs.chromium.org/p/chromium/issues/detail?id=1508033#c1

I'll handle color-valid-rgb.html failures elsewhere

crbug.com/1508413

[sesse via monorail]

Updates:
Owner: tk...@chromium.org
Status: Assigned

Comment #2 on issue 1508033 by se...@chromium.org: [WPT] New failures introduced in external/wpt/css by import https://crrev.com/c/5083719
https://bugs.chromium.org/p/chromium/issues/detail?id=1508033#c2

Assigning to tkent@, who according to Rune has worked on :state().

[tkent via monorail]

Updates:
Components: Blink>HTML>CustomElements
Owner: jar...@chromium.org

Comment #3 on issue 1508033 by tk...@chromium.org: [WPT] New failures introduced in external/wpt/css by import https://crrev.com/c/5083719
https://bugs.chromium.org/p/chromium/issues/detail?id=1508033#c3

I think jarhar@ is responsible for custom state now.

[sesse via monorail]

Comment #4 on issue 1508033 by se...@chromium.org: [WPT] New failures introduced in external/wpt/css by import https://crrev.com/c/5083719
https://bugs.chromium.org/p/chromium/issues/detail?id=1508033#c4

Issue 1509076 has been merged into this issue.

[Git Watcher via monorail]

Updates:
Status: Fixed

Comment #5 on issue 1508033 by Git Watcher: [WPT] New failures introduced in external/wpt/css by import https://crrev.com/c/5083719
https://bugs.chromium.org/p/chromium/issues/detail?id=1508033#c5

The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/3c0043bb4ed6a64b84af6df417a132bc626ab92f

commit 3c0043bb4ed6a64b84af6df417a132bc626ab92f
Author: Joey Arhar <jar...@chromium.org>
Date: Wed Jan 31 21:19:57 2024

Implement :state(foo) alongside :--foo

This patch implements :state(foo) alongsite :--foo so that we can have
both supported on stable at the same time and then deprecate/remove
:--foo. This patch does not enable :state(foo) by default. I will do
that after implementing deprecation for :--foo.

Due to pushback from webkit, the syntax for this feature was discussed
again in the CSSWG, and a resolution was made to go back from :--foo to
:state(foo):
https://github.com/w3c/csswg-drafts/issues/4805#issuecomment-1663111980

This was discussed in an I2S where we decided to only deprecate :--foo
if WebKit ships :--foo, which has now happened.
https://groups.google.com/a/chromium.org/g/blink-dev/c/JvpHoUfhJYE

Fixed: 1508033
Bug: 1514397
Change-Id: I497fd5acc05ba033e8e72c429568099c89d5d639
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5153145
Reviewed-by: Mason Freed <mas...@chromium.org>
Auto-Submit: Joey Arhar <jar...@chromium.org>
Commit-Queue: Joey Arhar <jar...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1254746}

[modify] https://crrev.com/3c0043bb4ed6a64b84af6df417a132bc626ab92f/third_party/blink/renderer/core/inspector/inspector_trace_events.cc
[modify] https://crrev.com/3c0043bb4ed6a64b84af6df417a132bc626ab92f/third_party/blink/renderer/core/html/custom/custom_state_set.cc
[modify] https://crrev.com/3c0043bb4ed6a64b84af6df417a132bc626ab92f/third_party/blink/web_tests/external/wpt/custom-elements/state/tentative/state-pseudo-class.html
[modify] https://crrev.com/3c0043bb4ed6a64b84af6df417a132bc626ab92f/third_party/blink/renderer/core/css/parser/css_selector_parser.cc
[modify] https://crrev.com/3c0043bb4ed6a64b84af6df417a132bc626ab92f/third_party/blink/renderer/core/css/selector_checker.cc
[modify] https://crrev.com/3c0043bb4ed6a64b84af6df417a132bc626ab92f/third_party/blink/renderer/core/css/parser/css_proto_converter.cc
[add] https://crrev.com/3c0043bb4ed6a64b84af6df417a132bc626ab92f/third_party/blink/web_tests/virtual/css-custom-state-only-deprecated-syntax/README.md
[modify] https://crrev.com/3c0043bb4ed6a64b84af6df417a132bc626ab92f/third_party/blink/renderer/core/css/rule_feature_set.cc
[modify] https://crrev.com/3c0043bb4ed6a64b84af6df417a132bc626ab92f/third_party/blink/renderer/core/css/css_selector.cc
[rename] https://crrev.com/3c0043bb4ed6a64b84af6df417a132bc626ab92f/third_party/blink/web_tests/virtual/css-custom-state-only-deprecated-syntax/external/wpt/custom-state-pseudo-class/custom-state-set-strong-ref.tentative-expected.txt
[modify] https://crrev.com/3c0043bb4ed6a64b84af6df417a132bc626ab92f/third_party/blink/renderer/core/css/css_selector.h
[modify] https://crrev.com/3c0043bb4ed6a64b84af6df417a132bc626ab92f/third_party/blink/web_tests/VirtualTestSuites
[modify] https://crrev.com/3c0043bb4ed6a64b84af6df417a132bc626ab92f/third_party/blink/renderer/platform/runtime_enabled_features.json5
[delete] https://crrev.com/fd182d64f70641ba33287509b54da8853360f2dc/third_party/blink/web_tests/external/wpt/css/selectors/invalidation/state-in-has-expected.txt
[modify] https://crrev.com/3c0043bb4ed6a64b84af6df417a132bc626ab92f/third_party/blink/renderer/build/scripts/core/css/parser/templates/css.proto.tmpl
[add] https://crrev.com/3c0043bb4ed6a64b84af6df417a132bc626ab92f/third_party/blink/web_tests/virtual/css-custom-state-only-new-syntax/README.md
[rename] https://crrev.com/3c0043bb4ed6a64b84af6df417a132bc626ab92f/third_party/blink/web_tests/virtual/css-custom-state-only-deprecated-syntax/external/wpt/custom-elements/state/tentative/state-pseudo-class-expected.txt
[delete] https://crrev.com/fd182d64f70641ba33287509b54da8853360f2dc/third_party/blink/web_tests/external/wpt/css/selectors/parsing/parse-state-expected.txt
[add] https://crrev.com/3c0043bb4ed6a64b84af6df417a132bc626ab92f/third_party/blink/web_tests/virtual/css-custom-state-only-deprecated-syntax/state-pseudo-class.html
[modify] https://crrev.com/3c0043bb4ed6a64b84af6df417a132bc626ab92f/third_party/blink/web_tests/external/wpt/custom-elements/state/tentative/ElementInternals-states.html
[add] https://crrev.com/3c0043bb4ed6a64b84af6df417a132bc626ab92f/third_party/blink/web_tests/virtual/css-custom-state-only-deprecated-syntax/ElementInternals-states.html
[add] https://crrev.com/3c0043bb4ed6a64b84af6df417a132bc626ab92f/third_party/blink/web_tests/virtual/css-custom-state-only-deprecated-syntax/external/wpt/custom-elements/state/tentative/ElementInternals-states-expected.txt
[modify] https://crrev.com/3c0043bb4ed6a64b84af6df417a132bc626ab92f/third_party/blink/public/mojom/use_counter/metrics/web_feature.mojom
[rename] https://crrev.com/3c0043bb4ed6a64b84af6df417a132bc626ab92f/third_party/blink/web_tests/virtual/css-custom-state-only-deprecated-syntax/external/wpt/custom-state-pseudo-class/state-css-selector-shadow-dom.tentative-expected.txt
[modify] https://crrev.com/3c0043bb4ed6a64b84af6df417a132bc626ab92f/third_party/blink/renderer/core/css/parser/css_selector_parser_test.cc
[rename] https://crrev.com/3c0043bb4ed6a64b84af6df417a132bc626ab92f/third_party/blink/web_tests/virtual/css-custom-state-only-deprecated-syntax/external/wpt/custom-state-pseudo-class/state-css-selector.tentative-expected.txt