Issue 1517181 in chromium: Test for invalid (x y z) component names in relative colors fail

[futhark via monorail]

Updates:
Owner: aar...@chromium.org
Status: Assigned
Summary: Test for invalid (x y z) component names in relative colors fail

Comment #2 on issue 1517181 by fut...@chromium.org: Test for invalid (x y z) component names in relative colors fail
https://bugs.chromium.org/p/chromium/issues/detail?id=1517181#c2

(No comment was entered for this change.)

--
You received this message because:
1. You were specifically CC'd on the issue

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

Reply to this email to add a comment or make updates.

[futhark via monorail]

Comment #3 on issue 1517181 by fut...@chromium.org: Test for invalid (x y z) component names in relative colors fail
https://bugs.chromium.org/p/chromium/issues/detail?id=1517181#c3

For other combinations for color-spaces and component names too.

[aaronhk via monorail]

Comment #4 on issue 1517181 by aar...@chromium.org: Test for invalid (x y z) component names in relative colors fail
https://bugs.chromium.org/p/chromium/issues/detail?id=1517181#c4

Ugh, did they change the spec again 🙄. When I wrote this xyz params were _explicitly_ valid for all rectangular coordinate spaces.

[Git Watcher via monorail]

Comment #5 on issue 1517181 by Git Watcher: Test for invalid (x y z) component names in relative colors fail
https://bugs.chromium.org/p/chromium/issues/detail?id=1517181#c5

The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/40ae4896d35e696e45d56ff7cb9b7e9474758faf

commit 40ae4896d35e696e45d56ff7cb9b7e9474758faf
Author: Aaron Krajeski <aar...@chromium.org>
Date: Wed Jan 17 18:55:24 2024

RCS doesnt mix rgb and xyz keywords

The spec has changed and it's no longer possible to intermix them. Good
news is this allows the code to simplify quite a bit.

Bug: 1517181
Change-Id: I46e19e37656e2015f4c163da43bc947073285bf5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5198812
Commit-Queue: Aaron Krajeski <aar...@chromium.org>
Reviewed-by: Rune Lillesveen <fut...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1248270}

[modify] https://crrev.com/40ae4896d35e696e45d56ff7cb9b7e9474758faf/third_party/blink/renderer/core/css/properties/css_color_function_parser.h
[modify] https://crrev.com/40ae4896d35e696e45d56ff7cb9b7e9474758faf/third_party/blink/renderer/core/css/properties/css_color_function_parser.cc
[modify] https://crrev.com/40ae4896d35e696e45d56ff7cb9b7e9474758faf/third_party/blink/web_tests/external/wpt/css/css-color/parsing/color-computed-relative-color.html
[delete] https://crrev.com/3b5a36760c6e41f07eca7ea9512a23230a58f2aa/third_party/blink/web_tests/external/wpt/css/css-color/parsing/color-invalid-relative-color-expected.txt
[modify] https://crrev.com/40ae4896d35e696e45d56ff7cb9b7e9474758faf/third_party/blink/renderer/platform/graphics/color.h