Issue 1286329 in chromium: LockManagerBrowserTest.ObserverNavigate is flaky

6 views
Skip to first unread message

afakhry via monorail

unread,
Jan 11, 2022, 3:25:04 PM1/11/22
to stora...@chromium.org
Updates:
Summary: LockManagerBrowserTest.ObserverNavigate is flaky

Comment #6 on issue 1286329 by afa...@chromium.org: LockManagerBrowserTest.ObserverNavigate is flaky
https://bugs.chromium.org/p/chromium/issues/detail?id=1286329#c6

(No comment was entered for this change.)

--
You received this message because:
1. You were specifically CC'd on the issue

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

Reply to this email to add a comment or make updates.

wanderview via monorail

unread,
Jan 11, 2022, 3:40:58 PM1/11/22
to stora...@chromium.org
Updates:
Cc: wande...@chromium.org
Owner: m...@chromium.org
Status: Available

Comment #7 on issue 1286329 by wande...@chromium.org: LockManagerBrowserTest.ObserverNavigate is flaky
https://bugs.chromium.org/p/chromium/issues/detail?id=1286329#c7

I'm sorry, but I'm not familiar with the ObserverNavigate functionality. Marijn, do you have any ideas? Or can we leave this available at a lower priority?

mek via monorail

unread,
Jan 11, 2022, 3:56:20 PM1/11/22
to stora...@chromium.org
Updates:
Cc: fdo...@chromium.org pwn...@chromium.org
Labels: OS-Linux Pri-2
Owner: ----

Comment #8 on issue 1286329 by m...@chromium.org: LockManagerBrowserTest.ObserverNavigate is flaky
https://bugs.chromium.org/p/chromium/issues/detail?id=1286329#c8

Lowering priority and marking as available seems reasonable to me. Not sure if disabling the test on linux also disabled it for chrome os or if we need a separate CL for that, I can never remember how the various OS_ macros work.

Git Watcher via monorail

unread,
Jan 11, 2022, 10:49:14 PM1/11/22
to stora...@chromium.org

Comment #9 on issue 1286329 by Git Watcher: LockManagerBrowserTest.ObserverNavigate is flaky
https://bugs.chromium.org/p/chromium/issues/detail?id=1286329#c9

The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/c21572fb02a727665263669d17827c0200b37007

commit c21572fb02a727665263669d17827c0200b37007
Author: Timothy Loh <tim...@chromium.org>
Date: Wed Jan 12 03:48:32 2022

Disable flaky test LockManagerBrowserTest.ObserverNavigate on Chrome OS

Bug: 1286329
Change-Id: If6e39777dae44e745edec7ddc0fe57a12d67d5fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3382022
Owners-Override: Timothy Loh <tim...@chromium.org>
Auto-Submit: Timothy Loh <tim...@chromium.org>
Reviewed-by: Chloe Pelling <cpel...@google.com>
Commit-Queue: Chloe Pelling <cpel...@google.com>
Cr-Commit-Position: refs/heads/main@{#957916}

[modify] https://crrev.com/c21572fb02a727665263669d17827c0200b37007/content/browser/locks/lock_manager_browsertest.cc

takumif via monorail

unread,
Jan 18, 2022, 3:05:40 PM1/18/22
to stora...@chromium.org
Updates:
Labels: OS-Mac

Comment #10 on issue 1286329 by tak...@chromium.org: LockManagerBrowserTest.ObserverNavigate is flaky
https://bugs.chromium.org/p/chromium/issues/detail?id=1286329#c10

Flaky on Mac as well, will disable
Sample failure:
https://ci.chromium.org/ui/p/chromium/builders/ci/Mac11%20Tests/6406/overview

Git Watcher via monorail

unread,
Jan 18, 2022, 4:32:18 PM1/18/22
to stora...@chromium.org

Comment #11 on issue 1286329 by Git Watcher: LockManagerBrowserTest.ObserverNavigate is flaky
https://bugs.chromium.org/p/chromium/issues/detail?id=1286329#c11


The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/fd4dc8d18d73dbc1173f165e69a1a792680ef65c

commit fd4dc8d18d73dbc1173f165e69a1a792680ef65c
Author: Takumi Fujimoto <tak...@chromium.org>
Date: Tue Jan 18 21:12:47 2022

Disable LockManagerBrowserTest.ObserverNavigate on Mac for flakiness

Sample failure:
https://ci.chromium.org/ui/p/chromium/builders/ci/Mac11%20Tests/6406/overview

Bug: 1286329
Change-Id: Ifad0d4334a743c65435bb4e0399a467869cf73f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3399614
Commit-Queue: Takumi Fujimoto <tak...@chromium.org>
Owners-Override: Takumi Fujimoto <tak...@chromium.org>
Auto-Submit: Takumi Fujimoto <tak...@chromium.org>
Reviewed-by: David Baron <dba...@chromium.org>
Commit-Queue: David Baron <dba...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#960608}

[modify] https://crrev.com/fd4dc8d18d73dbc1173f165e69a1a792680ef65c/content/browser/locks/lock_manager_browsertest.cc

Git Watcher via monorail

unread,
Jan 28, 2022, 8:22:10 PM1/28/22
to stora...@chromium.org

Comment #12 on issue 1286329 by Git Watcher: LockManagerBrowserTest.ObserverNavigate is flaky
https://bugs.chromium.org/p/chromium/issues/detail?id=1286329#c12


The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/c3ea81fc72f6e062239ec267f4228b2f4aa1bec6

commit c3ea81fc72f6e062239ec267f4228b2f4aa1bec6
Author: Yuheng Huang <yuh...@google.com>
Date: Sat Jan 29 01:21:06 2022

[Sheriff] Disable LockManagerBrowserTest.ObserverNavigate on Win

Bug: 1286329
Change-Id: I081a7740bee3d411d2dafe146e992bbc772be8c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3425810
Auto-Submit: Yuheng Huang <yuh...@google.com>
Reviewed-by: Robert Liao <rob...@chromium.org>
Owners-Override: Yuheng Huang <yuh...@google.com>
Commit-Queue: Yuheng Huang <yuh...@google.com>
Cr-Commit-Position: refs/heads/main@{#964886}

[modify] https://crrev.com/c3ea81fc72f6e062239ec267f4228b2f4aa1bec6/content/browser/locks/lock_manager_browsertest.cc

fdegans via monorail

unread,
Apr 28, 2022, 12:13:25 PM4/28/22
to stora...@chromium.org

Comment #13 on issue 1286329 by fde...@chromium.org: LockManagerBrowserTest.ObserverNavigate is flaky
https://bugs.chromium.org/p/chromium/issues/detail?id=1286329#c13

This is also flaky on Fuchsia. I am making a CL to disable on all platforms at this point.

Git Watcher via monorail

unread,
Apr 28, 2022, 3:24:13 PM4/28/22
to stora...@chromium.org

Comment #14 on issue 1286329 by Git Watcher: LockManagerBrowserTest.ObserverNavigate is flaky
https://bugs.chromium.org/p/chromium/issues/detail?id=1286329#c14


The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/08bc84779a70a3c27df2a69000167306d37fbe96

commit 08bc84779a70a3c27df2a69000167306d37fbe96
Author: Fabrice de Gans <fde...@chromium.org>
Date: Thu Apr 28 19:23:22 2022

[content_browsertests] Disable flaky test on all platforms

LockManagerBrowserTest.ObserverNavigate is flaky on all platforms.

Bug: 1286329
Change-Id: Ia4219fd42cfd32dd4dc63d00621fc196dcecadad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3614350
Reviewed-by: Bo Liu <bo...@chromium.org>
Commit-Queue: Bo Liu <bo...@chromium.org>
Auto-Submit: Fabrice de Gans <fde...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#997338}

[modify] https://crrev.com/08bc84779a70a3c27df2a69000167306d37fbe96/content/browser/locks/lock_manager_browsertest.cc

sheriffbot via monorail

unread,
May 1, 2023, 11:57:24 AM5/1/23
to stora...@chromium.org
Updates:
Labels: Hotlist-Recharge-Cold
Status: Untriaged

Comment #15 on issue 1286329 by sheriffbot: LockManagerBrowserTest.ObserverNavigate is flaky
https://bugs.chromium.org/p/chromium/issues/detail?id=1286329#c15

This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

christinesm via monorail

unread,
May 4, 2023, 2:53:35 PM5/4/23
to stora...@chromium.org
Updates:
Status: Available

Comment #16 on issue 1286329 by chris...@chromium.org: LockManagerBrowserTest.ObserverNavigate is flaky
https://bugs.chromium.org/p/chromium/issues/detail?id=1286329#c16


(No comment was entered for this change.)

Reply all
Reply to author
Forward
0 new messages