OWP Storage Team Weekly

[Joshua Bell]

Storage team (SFO/MTV) weekly updates. The Storage team works on APIs like Indexed DB, Cache API, DOM Storage as well as the underpinnings like leveldb, sqlite, blobs, quota, and related components like FileAPI and DataTransfer.

Triage

• bsittler keeps the baton
  
• ongoing trickle of DataTransfer issues; spike in "can't copy/paste" (what changed?)

LevelDB

• wrapping up memory infra integration, last CL (adding UMA stats) being polished, two more CLs out for review - cmumford@
• converting to shared library, out for review with pwnall@ etc - cmumford@
• various github maintenance items, crc32 library items - cmumford@, pwnall@
• Internal outreach to teams to see if memory can be reduced - cmumford@

Async Cookies API

• Layout tests functional w/ blink's http server, but flakiness with WPT's runner (and Edge); investigating; flakiness related to observers/callbacks, may split up tests - bsittler@
• Resolved issues w/ network s13n efforts blocking impl - pwnall@

Indexed DB - dmurph@

• Landed patch to eliminate blob leaks (blob cleanup could be delayed indefinitely if new transactions issued before cleanup timer fired, or connection closed)
• Backing store refactors to simplify tombstone sweeper integration (adding stats gathering is first step

Servicification

• MessagePort Onion Soupification change landed but reverted due to unexpected perf regression - mek@
• Landed mojoified Blob integration with Indexed DB - mek@
• Starting again on Cache Storage S13n - cmumford@

Miscellaneous

• FileAPI spec discussion about FileReader.result values before event fires; in browsers today you get a partial result. Adding a user counter to see if anyone relies on this. - mek@
• Integrating feedback into web locks design and implementation - mode made an option, "scoped release" API approach - jsbell@
• Issue with session storage apparently not getting cleaned up - dmurph@

[Joshua Bell]

Storage team (SFO/MTV) weekly updates. The Storage team works on APIs like Indexed DB, Cache API, DOM Storage as well as the underpinnings like leveldb, sqlite, blobs, quota, and related components like FileAPI and DataTransfer.

Triage

• bsittler@ has the baton, digging in to issues
  
• Interesting flurry of hard-to-repro IDB, DataTransfer issues

Async Cookies

• Progressing with test split-up; trying to get tests in for 63 - bsittler@
• Landed mojo interfaces for network service hookup - pwnall@
• Have CL for overall infrastructure that provides getAll() and set() in document contexts; in review (maybe 63???)

Blob / MessagePort Servicification - mek@

• Fixed problem w/ MessagePort OnionSoupification, re-landed
  
• ... but now there's a new crash, digging in
  
• Getting blob handles into MP messages; getting closer to landing
  

Session Storage - dmurph@

• Set up time to talk with Android folks about Session Storage cleanup (which isn't happening consistently)
• Will be starting on servicification after wrapping up IDB work

Indexed DB

• Leaked blob cleanup change merged to M62 - dmurph@
• Refactoring IDB backend to make metadata easier to modify - dmurph@
• Tackling index tombstone sweeper - needs to stash metadata about state for scheduling/restarts - dmurph@
• Switching to focus on WASM module stream support for 63 - pwnall@

LevelDB - cmumford@

• 4 CLs out for leveldb changes
• CL last week revealed bug in leveldb; fix landed (collaborated with pwnall@)
• Handling several reviews of memory infra integration for ssid@
• adding logging to diagnose errors seen in canary on a googler's machine

Cache Storage - cmumford@

• Back to work on servicification

File & Directory Entries - jsbell@

• WebKit implemented, in Safari Tech Preview 41
• Upstreamed tests to WPT - current test results
• Safari passes nearly everything (after some test fixes); spec corrections for some failures
• Edge failures due to lack of full API coverage; reworking tests to avoid unneeded dependencies

Miscellaneous

• Revising icon used for quota permissions - jsbell@
• Discussion on native locks API with internal customers - jsbell@

[Joshua Bell]

Storage team (SFO/MTV) weekly updates. The Storage team works on APIs like Indexed DB, Cache API, DOM Storage as well as the underpinnings like leveldb, sqlite, blobs, quota, and related components like FileAPI and DataTransfer.

Triage

• bsittler keeps the baton another week
• nothing really new

Indexed DB

• Index tombstone sweeper in review - dmurph@ (& pwnall@)
• Blob leak fix landed and merged to 62 - dmurph@
• Metadata refactors landed - dmurph@
  
• Investigating blob-autowrapping leak issue - dmurph@
• Brainstorming on where blob storage should be implemented - inside leveldb? Inside existing IDB-specific leveldb wrappers? In a new wrapper layer? - dmurph@, pwnall@, jsbell@
  
• Working on WASM Module streaming; have plan with WASM folks, V8 folks requesting changes to internal API, design doc - pwnall@
• 2.0 spec CR exit: reviewed WPT test coverage, added a few missing tests - jsbell@, pwnall@

Async Cookies API - pwnall@, bsittler@

• Partial impl landed for 63 (behind experimental flag) - getAll and set for document contexts - pwnall@
• Reworking layout tests - polyfill broken by partial impl (need to rip it out) - bsittler@

Session Storage Servicification - dmurph@

• Started learning how implementation works, deviations from the spec, etc - w/ help from mek@

File & Directory Entries - jsbell@

• Reworked web-platform-tests to reduce API dependencies, better highlight per-browser failures

Cache Storage / Servicification - cmumford@

• Added UMA stats
• Starting on S13n

AppCache/Network Service - michaeln@

• CL up for review for AppCache resource/subresource loading; review feedback from Kinuko on comments
  

Blob Servicification - mek@

• Landed another CL for keeping blobs alive during postMessage(); more to do though
  
• Noted: the way we're loading from blob URLs won't work with mojo (as-is) because creating/revoking needs to be sequenced with resolving; need to design this. Implementations don't match spec (e.g. spec has resolve-when-parsed, which only FF does)

LevelDB Memory Reduction - cmumford@

• All but 2 CLs closed out now, one up for review, plan to abandon another

Miscellaneous

• A couple of issues with chrome://settings/clearBrowserData and chrome://settings/siteData vs. the FileSystem API found by the Privacy team. Cause found, fixes in review - jsbell@
• Landing some old extensions database refactors (1 landed, 3 more in review) - cmumford@
• Android-specific crash in cookies tree deletion; possible release blocker, fix identified - dmurph@ (with help from michaeln@ and mek@)

[Joshua Bell]

Storage team (SFO/MTV) weekly updates. The Storage team works on APIs like Indexed DB, Cache API, DOM Storage as well as the underpinnings like leveldb, sqlite, blobs, quota, and related components like FileAPI and DataTransfer.

Triage

• Trying to repro session storage bug, copy/paste issues - bsittler@
  
• Passes baton on to jsbell
  

Network Service / AppCache - michaeln@

• Committed big refactor change, working on follow-up CL for tests
• Wrote up notes on state of work
• Note that this is not turned on yet.

Cache Storage Servicification - cmumford@

• In progress!

Session Storage Servicification - dmurph@

• Writing unit tests for changes

Blobs Servicification - mek@

• Landed CLs for small fixes for mojo blobs (threading, keep renderer alive, missing histograms)
• Trying to see what still fails, updating tests that relied on old behavior
• Everything seems to pass (so getting close) - next up is figuring out launch plan

Indexed DB

• Following up on reports of missing IDB onerror callback (corruption... ?) - dmurph@
  
• Investigated blob leaks with autowrapping; may have found 2 causes - fixes in review - dmurph@
  
• CLs up for docs on Blink on implementation/data flows - pwnall@

Async Cookies

• Fixed renderer crash w/ detached iframe  - pwnall@
• Tests - bsittler@
• Round of improvements made; rolling in feedback
• Adding new simplified tests (may be follow-up CL)

LevelDB

• Did a bug triage pass - cmumford@
• Two remaining CLs on memory reduction; one in review, one (on iterators) will be closed as infeasible (no leveldb APIs to gather the data, push-back on adding them) - cmumford@
• Investigated two issues: pre-C++11 compilation bug, unsafe memory access - pwnall@
• Looked into Bazel builds for snappy - pwnall@

File System - jsbell@

• Landed two parts of fix for browsing data deletion vs. filesystem API glitches causing entries to not show as deleted