[soft navs] Remove SoftNavigationMetricsForReporting::first_contentful_paint field [chromium/src : main]
0 views
Skip to first unread message
Johannes Henkel (Gerrit)
Feb 17, 2026, 6:37:29 PM (4 days ago) Feb 17
to Michal Mocny, Scott Haseley, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, speed-metrics...@chromium.org
Attention needed from Michal Mocny and Scott Haseley
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Michal Mocny
- Scott Haseley
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Scott Haseley (Gerrit)
Feb 17, 2026, 6:38:27 PM (4 days ago) Feb 17
to Johannes Henkel, Michal Mocny, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, speed-metrics...@chromium.org
Attention needed from Johannes Henkel and Michal Mocny
Scott Haseley voted and added 1 comment![]( "Open in Gerrit")
Votes added by Scott Haseley
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Johannes Henkel
- Michal Mocny
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Philip Rogers (Gerrit)
Feb 17, 2026, 7:07:52 PM (4 days ago) Feb 17
to Johannes Henkel, Scott Haseley, Michal Mocny, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, speed-metrics...@chromium.org
Attention needed from Johannes Henkel and Michal Mocny
Philip Rogers voted and added 1 comment![]( "Open in Gerrit")
Votes added by Philip Rogers
| Code-Review | +1 |
1 comment
Patchset-level comments
Philip Rogers . resolved
LGTM
Related details
Attention is currently required from:
- Johannes Henkel
- Michal Mocny
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Johannes Henkel (Gerrit)
Feb 17, 2026, 7:19:42 PM (4 days ago) Feb 17
to Michal Mocny, Philip Rogers, Scott Haseley, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, speed-metrics...@chromium.org
Johannes Henkel voted and added 1 comment![]( "Open in Gerrit")
Votes added by Johannes Henkel
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Feb 17, 2026, 9:03:08 PM (4 days ago) Feb 17
to Johannes Henkel, Michal Mocny, Philip Rogers, Scott Haseley, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, speed-metrics...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[soft navs] Remove SoftNavigationMetricsForReporting::first_contentful_paint field
This isn't used and won't be used.
If we want to do an FCP soft navs metric in UKM,
we'll be using the ICP / Soft LCP messages instead.
Change-Id: I700dea752eec386f2c2b8f5f883fd86b401d90d9
Reviewed-by: Scott Haseley <shas...@chromium.org>
Commit-Queue: Johannes Henkel <joha...@chromium.org>
Reviewed-by: Philip Rogers <p...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1586133}
Files:
- M third_party/blink/public/web/web_performance_metrics_for_reporting.h
- M third_party/blink/renderer/core/timing/soft_navigation_heuristics.cc
Change size: XS
Delta: 2 files changed, 0 insertions(+), 4 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Scott Haseley, +1 by Philip Rogers
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages