Rename OriginatingProcess to OriginatingProcessId [chromium/src : main]

[Christopher Staite (Gerrit)]

Attention needed from Alexander Cooper, Chrome Security IPC Reviews and Kenichi Ishibashi

Christopher Staite added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Christopher Staite . resolved

Hi all. As discussed in https://crrev.com/c/7269607 and via email, this CL renames network::OriginatingProcess to network::OriginatingProcessId and network::RendererProcess to network::RendererProcessId. I think this warrants an OO. Please let me know if there's any other procedure that is required.

Open in Gerrit

Related details

Attention is currently required from:

• Alexander Cooper
• Chrome Security IPC Reviews
• Kenichi Ishibashi

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I46e24cac5857a0ac4182991f4edbb5ffcf26ebac

Gerrit-Change-Number: 7557820

Gerrit-PatchSet: 1

Gerrit-Owner: Christopher Staite <christoph...@menlosecurity.com>

Gerrit-Reviewer: Alexander Cooper <alco...@chromium.org>

Gerrit-Reviewer: Chrome Security IPC Reviews <chrome-securi...@google.com>

Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>

Gerrit-CC: Heron Yang <hero...@google.com>

Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>

Gerrit-CC: James Maclean <wjma...@chromium.org>

Gerrit-CC: Mangesh Ghiware <mghi...@google.com>

Gerrit-CC: Peter Beverloo <pe...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Chrome Security IPC Reviews <chrome-securi...@google.com>

Gerrit-Attention: Kenichi Ishibashi <ba...@chromium.org>

Gerrit-Attention: Alexander Cooper <alco...@chromium.org>

Gerrit-Comment-Date: Mon, 09 Feb 2026 17:49:45 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Alexander Cooper (Gerrit)]

Attention needed from Christopher Staite, Chrome Security IPC Reviews and Kenichi Ishibashi

Alexander Cooper voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Christopher Staite

Gerrit-Attention: Christopher Staite <christoph...@menlosecurity.com>

Gerrit-Comment-Date: Mon, 09 Feb 2026 17:54:59 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[gwsq (Gerrit)]

Attention needed from Christopher Staite, Giovanni Ortuno Urquidi and Kenichi Ishibashi

Message from gwsq

From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: ort...@chromium.org

📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).

IPC reviewer(s): ort...@chromium.org

Reviewer source(s):
ort...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)

Open in Gerrit

Related details

Attention is currently required from:

• Christopher Staite
• Giovanni Ortuno Urquidi
• Kenichi Ishibashi

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I46e24cac5857a0ac4182991f4edbb5ffcf26ebac

Gerrit-Change-Number: 7557820

Gerrit-PatchSet: 1

Gerrit-Owner: Christopher Staite <christoph...@menlosecurity.com>

Gerrit-Reviewer: Alexander Cooper <alco...@chromium.org>

Gerrit-Reviewer: Giovanni Ortuno Urquidi <ort...@chromium.org>

Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>

Gerrit-CC: Chrome Security IPC Reviews <chrome-securi...@google.com>

Gerrit-CC: Heron Yang <hero...@google.com>

Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>

Gerrit-CC: James Maclean <wjma...@chromium.org>

Gerrit-CC: Mangesh Ghiware <mghi...@google.com>

Gerrit-CC: Peter Beverloo <pe...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: gwsq

Gerrit-Attention: Kenichi Ishibashi <ba...@chromium.org>

Gerrit-Attention: Giovanni Ortuno Urquidi <ort...@chromium.org>

Gerrit-Attention: Christopher Staite <christoph...@menlosecurity.com>

Gerrit-Comment-Date: Mon, 09 Feb 2026 17:55:25 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: No

[Giovanni Ortuno Urquidi (Gerrit)]

Attention needed from Alexander Cooper, Christopher Staite and Kenichi Ishibashi

Giovanni Ortuno Urquidi added 4 comments

File services/network/public/cpp/originating_process_id.h

Line 33, Patchset 3 (Latest): // Whether the originating process is the browser process.
bool is_browser() const;

// Get the renderer process ID for this, it is a bug to call this if
// |is_browser| returns true.
const RendererProcessId& renderer_process() const;

Giovanni Ortuno Urquidi . unresolved

More of a question than a request for change: how come we don't suffix these with `_id`?

File services/network/public/cpp/originating_process_id_mojom_traits.cc

Line 26, Patchset 3 (Latest): *out = network::OriginatingProcessId::browser();

Giovanni Ortuno Urquidi . unresolved

look like if the tag is kBrowserProcessId, we assume the data is valid. Can we change that to verifying that the data is actually valid?

Would the following work?
```
netowrk::mojom::BrowserProcessId browser_process;
if (!data.ReadBrowserProcessId(&browser_process)) {
  return false;
}
*out = network::OriginatingProcessId::browser();
```

Line 32, Patchset 3 (Latest): network::RendererProcessId renderer_process;

Giovanni Ortuno Urquidi . unresolved

optional nit: we're suffixing the types with Id, so it would make snse to also do that with variables names.

Line 33, Patchset 3 (Latest): data.GetRendererProcessIdDataView(&view);
if (!StructTraits<decltype(view), decltype(renderer_process)>::Read(
std::move(view), &renderer_process)) {
return false;
}

Giovanni Ortuno Urquidi . unresolved

why do we use the data view and Read instead of:
```
if (!data.ReadRenderProcessId(&renderer_process)) {
  return false;
}
*out = network::OriginatingProcessId::renderer(std::move(renderer_process));
```

Open in Gerrit

Related details

Attention is currently required from:

• Alexander Cooper
• Christopher Staite
• Kenichi Ishibashi

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I46e24cac5857a0ac4182991f4edbb5ffcf26ebac

Gerrit-Change-Number: 7557820

Gerrit-PatchSet: 3

Gerrit-Owner: Christopher Staite <christoph...@menlosecurity.com>

Gerrit-Reviewer: Alexander Cooper <alco...@chromium.org>

Gerrit-Reviewer: Giovanni Ortuno Urquidi <ort...@chromium.org>

Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>

Gerrit-CC: Chrome Security IPC Reviews <chrome-securi...@google.com>

Gerrit-CC: Heron Yang <hero...@google.com>

Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>

Gerrit-CC: James Maclean <wjma...@chromium.org>

Gerrit-CC: Mangesh Ghiware <mghi...@google.com>

Gerrit-CC: Peter Beverloo <pe...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: gwsq

Gerrit-Attention: Kenichi Ishibashi <ba...@chromium.org>

Gerrit-Attention: Christopher Staite <christoph...@menlosecurity.com>

Gerrit-Attention: Alexander Cooper <alco...@chromium.org>

Gerrit-Comment-Date: Mon, 09 Feb 2026 19:02:34 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Christopher Staite (Gerrit)]

Attention needed from Alexander Cooper, Giovanni Ortuno Urquidi and Kenichi Ishibashi

Christopher Staite added 4 comments

File services/network/public/cpp/originating_process_id.h

Line 33, Patchset 3 (Latest): // Whether the originating process is the browser process.
bool is_browser() const;

// Get the renderer process ID for this, it is a bug to call this if
// |is_browser| returns true.
const RendererProcessId& renderer_process() const;

Giovanni Ortuno Urquidi . resolved

More of a question than a request for change: how come we don't suffix these with `_id`?

Christopher Staite

You're absolutely right, I probably should.

File services/network/public/cpp/originating_process_id_mojom_traits.cc

Line 26, Patchset 3 (Latest): *out = network::OriginatingProcessId::browser();

Giovanni Ortuno Urquidi . resolved

look like if the tag is kBrowserProcessId, we assume the data is valid. Can we change that to verifying that the data is actually valid?

Would the following work?
```
netowrk::mojom::BrowserProcessId browser_process;
if (!data.ReadBrowserProcessId(&browser_process)) {
  return false;
}
*out = network::OriginatingProcessId::browser();
```

Christopher Staite

The struct is empty, so I don't think there's anything to read. But it sure doesn't hurt to add it.

Line 32, Patchset 3 (Latest): network::RendererProcessId renderer_process;

Giovanni Ortuno Urquidi . resolved

optional nit: we're suffixing the types with Id, so it would make snse to also do that with variables names.

Christopher Staite

Done

Line 33, Patchset 3 (Latest): data.GetRendererProcessIdDataView(&view);
if (!StructTraits<decltype(view), decltype(renderer_process)>::Read(
std::move(view), &renderer_process)) {
return false;
}

Giovanni Ortuno Urquidi . resolved

why do we use the data view and Read instead of:
```
if (!data.ReadRenderProcessId(&renderer_process)) {
  return false;
}
*out = network::OriginatingProcessId::renderer(std::move(renderer_process));
```

Christopher Staite

Because I didn't know that you could 😊

Open in Gerrit

Related details

Attention is currently required from:

• Alexander Cooper
• Giovanni Ortuno Urquidi
• Kenichi Ishibashi

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I46e24cac5857a0ac4182991f4edbb5ffcf26ebac

Gerrit-Change-Number: 7557820

Gerrit-PatchSet: 3

Gerrit-Owner: Christopher Staite <christoph...@menlosecurity.com>

Gerrit-Reviewer: Alexander Cooper <alco...@chromium.org>

Gerrit-Reviewer: Giovanni Ortuno Urquidi <ort...@chromium.org>

Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>

Gerrit-CC: Chrome Security IPC Reviews <chrome-securi...@google.com>

Gerrit-CC: Heron Yang <hero...@google.com>

Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>

Gerrit-CC: James Maclean <wjma...@chromium.org>

Gerrit-CC: Mangesh Ghiware <mghi...@google.com>

Gerrit-CC: Peter Beverloo <pe...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: gwsq

Gerrit-Attention: Kenichi Ishibashi <ba...@chromium.org>

Gerrit-Attention: Giovanni Ortuno Urquidi <ort...@chromium.org>

Gerrit-Attention: Alexander Cooper <alco...@chromium.org>

Gerrit-Comment-Date: Mon, 09 Feb 2026 20:05:18 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Giovanni Ortuno Urquidi <ort...@chromium.org>

[Giovanni Ortuno Urquidi (Gerrit)]

Attention needed from Alexander Cooper, Christopher Staite and Kenichi Ishibashi

Giovanni Ortuno Urquidi voted and added 2 comments

Votes added by Giovanni Ortuno Urquidi

Code-Review

+1

2 comments

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Giovanni Ortuno Urquidi . resolved

mojo lgtm % nit

File services/network/public/cpp/originating_process_id_mojom_traits.cc

Line 24, Patchset 4 (Latest): if (data.is_null()) {
return false;
}

Giovanni Ortuno Urquidi . unresolved

I believe this is checked by the bindings, so we should be able to assume the data is non-null[[1]](https://source.chromium.org/chromium/chromium/src/+/main:out/linux-Debug/gen/services/network/public/mojom/originating_process.mojom-shared.h;l=170;drc=57413c5806942e56350114a0ab9daa26de64b4bc).

Did you run into any cases where data is null here?

Open in Gerrit

Related details

Attention is currently required from:

• Alexander Cooper
• Christopher Staite
• Kenichi Ishibashi

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I46e24cac5857a0ac4182991f4edbb5ffcf26ebac

Gerrit-Change-Number: 7557820

Gerrit-PatchSet: 4

Gerrit-Owner: Christopher Staite <christoph...@menlosecurity.com>

Gerrit-Reviewer: Alexander Cooper <alco...@chromium.org>

Gerrit-Reviewer: Giovanni Ortuno Urquidi <ort...@chromium.org>

Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>

Gerrit-CC: Chrome Security IPC Reviews <chrome-securi...@google.com>

Gerrit-CC: Heron Yang <hero...@google.com>

Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>

Gerrit-CC: James Maclean <wjma...@chromium.org>

Gerrit-CC: Mangesh Ghiware <mghi...@google.com>

Gerrit-CC: Peter Beverloo <pe...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: gwsq

Gerrit-Attention: Kenichi Ishibashi <ba...@chromium.org>

Gerrit-Attention: Christopher Staite <christoph...@menlosecurity.com>

Gerrit-Attention: Alexander Cooper <alco...@chromium.org>

Gerrit-Comment-Date: Tue, 10 Feb 2026 16:36:01 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Christopher Staite (Gerrit)]

Attention needed from Alexander Cooper, Giovanni Ortuno Urquidi and Kenichi Ishibashi

Christopher Staite added 1 comment

File services/network/public/cpp/originating_process_id_mojom_traits.cc

Line 24, Patchset 4: if (data.is_null()) {
return false;
}

Giovanni Ortuno Urquidi . resolved

I believe this is checked by the bindings, so we should be able to assume the data is non-null[[1]](https://source.chromium.org/chromium/chromium/src/+/main:out/linux-Debug/gen/services/network/public/mojom/originating_process.mojom-shared.h;l=170;drc=57413c5806942e56350114a0ab9daa26de64b4bc).

Did you run into any cases where data is null here?

Christopher Staite

I did not. I saw the function existed and decided to add it. If it's checked in the bindings then I'm happy to revert.

Open in Gerrit

Related details

Attention is currently required from:

• Alexander Cooper
• Giovanni Ortuno Urquidi
• Kenichi Ishibashi

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I46e24cac5857a0ac4182991f4edbb5ffcf26ebac

Gerrit-Change-Number: 7557820

Gerrit-PatchSet: 4

Gerrit-Owner: Christopher Staite <christoph...@menlosecurity.com>

Gerrit-Reviewer: Alexander Cooper <alco...@chromium.org>

Gerrit-Reviewer: Giovanni Ortuno Urquidi <ort...@chromium.org>

Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>

Gerrit-CC: Chrome Security IPC Reviews <chrome-securi...@google.com>

Gerrit-CC: Heron Yang <hero...@google.com>

Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>

Gerrit-CC: James Maclean <wjma...@chromium.org>

Gerrit-CC: Mangesh Ghiware <mghi...@google.com>

Gerrit-CC: Peter Beverloo <pe...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: gwsq

Gerrit-Attention: Kenichi Ishibashi <ba...@chromium.org>

Gerrit-Attention: Giovanni Ortuno Urquidi <ort...@chromium.org>

Gerrit-Attention: Alexander Cooper <alco...@chromium.org>

Gerrit-Comment-Date: Tue, 10 Feb 2026 17:08:06 +0000

[Giovanni Ortuno Urquidi (Gerrit)]

Attention needed from Kenichi Ishibashi

Giovanni Ortuno Urquidi voted and added 1 comment

Votes added by Giovanni Ortuno Urquidi

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Giovanni Ortuno Urquidi . resolved

mojo slgtm

Open in Gerrit

Related details

Attention is currently required from:

• Kenichi Ishibashi

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I46e24cac5857a0ac4182991f4edbb5ffcf26ebac

Gerrit-Change-Number: 7557820

Gerrit-PatchSet: 5

Gerrit-Owner: Christopher Staite <christoph...@menlosecurity.com>

Gerrit-Reviewer: Alexander Cooper <alco...@chromium.org>

Gerrit-Reviewer: Giovanni Ortuno Urquidi <ort...@chromium.org>

Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>

Gerrit-CC: Chrome Security IPC Reviews <chrome-securi...@google.com>

Gerrit-CC: Heron Yang <hero...@google.com>

Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>

Gerrit-CC: James Maclean <wjma...@chromium.org>

Gerrit-CC: Mangesh Ghiware <mghi...@google.com>

Gerrit-CC: Peter Beverloo <pe...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: gwsq

Gerrit-Attention: Kenichi Ishibashi <ba...@chromium.org>

Gerrit-Comment-Date: Wed, 11 Feb 2026 15:07:42 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Kenichi Ishibashi (Gerrit)]

Attention needed from Christopher Staite

Kenichi Ishibashi voted and added 1 comment

Votes added by Kenichi Ishibashi

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Kenichi Ishibashi . resolved

lgtm

Open in Gerrit

Related details

Attention is currently required from:

• Christopher Staite

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I46e24cac5857a0ac4182991f4edbb5ffcf26ebac

Gerrit-Change-Number: 7557820

Gerrit-PatchSet: 5

Gerrit-Owner: Christopher Staite <christoph...@menlosecurity.com>

Gerrit-Reviewer: Alexander Cooper <alco...@chromium.org>

Gerrit-Reviewer: Giovanni Ortuno Urquidi <ort...@chromium.org>

Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>

Gerrit-CC: Chrome Security IPC Reviews <chrome-securi...@google.com>

Gerrit-CC: Heron Yang <hero...@google.com>

Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>

Gerrit-CC: James Maclean <wjma...@chromium.org>

Gerrit-CC: Mangesh Ghiware <mghi...@google.com>

Gerrit-CC: Peter Beverloo <pe...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: gwsq

Gerrit-Attention: Christopher Staite <christoph...@menlosecurity.com>

Gerrit-Comment-Date: Thu, 12 Feb 2026 01:24:48 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[gwsq (Gerrit)]

Attention needed from Alex Turner, Arthur Milchior, Bo Liu, David Roger, Gauthier Ambard and Takashi Toyoshima

Message from gwsq

Shadowed: arthurm...@google.com

Reviewer source(s):
arthurm...@google.com, dro...@chromium.org is from context(googleclient/chrome/chromium_gwsq/components/signin/config.gwsq)

Open in Gerrit

Related details

Attention is currently required from:

• Alex Turner
• Arthur Milchior
• Bo Liu
• David Roger
• Gauthier Ambard
• Takashi Toyoshima

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I46e24cac5857a0ac4182991f4edbb5ffcf26ebac

Gerrit-Change-Number: 7557820

Gerrit-PatchSet: 5

Gerrit-Owner: Christopher Staite <christoph...@menlosecurity.com>

Gerrit-Reviewer: Alex Turner <ale...@chromium.org>

Gerrit-Reviewer: Arthur Milchior <arthurm...@chromium.org>

Gerrit-Reviewer: Bo Liu <bo...@chromium.org>

Gerrit-Reviewer: David Roger <dro...@chromium.org>

Gerrit-Reviewer: Gauthier Ambard <gam...@chromium.org>

Gerrit-Reviewer: Giovanni Ortuno Urquidi <ort...@chromium.org>

Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>

Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>

Gerrit-CC: Alexander Cooper <alco...@chromium.org>

Gerrit-CC: Chrome Security IPC Reviews <chrome-securi...@google.com>

Gerrit-CC: Chrome Signin Team <chrome-sig...@google.com>

Gerrit-CC: Heron Yang <hero...@google.com>

Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>

Gerrit-CC: James Maclean <wjma...@chromium.org>

Gerrit-CC: Mangesh Ghiware <mghi...@google.com>

Gerrit-CC: Peter Beverloo <pe...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: gwsq

Gerrit-Attention: David Roger <dro...@chromium.org>

Gerrit-Attention: Takashi Toyoshima <toyo...@chromium.org>

Gerrit-Attention: Arthur Milchior <arthurm...@chromium.org>

Gerrit-Attention: Alex Turner <ale...@chromium.org>

Gerrit-Attention: Bo Liu <bo...@chromium.org>

Gerrit-Attention: Gauthier Ambard <gam...@chromium.org>

Gerrit-Comment-Date: Thu, 12 Feb 2026 11:13:35 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: No

[Arthur Milchior (Gerrit)]

Attention needed from Alex Turner, Bo Liu, Christian Dullweber, Christopher Staite, Dave Tapuska, David Roger, Elly FJ, Gauthier Ambard, James Cook, Ken Buchanan, Matt Mueller, Nathan Parker, Sean Topping and Takashi Toyoshima

Arthur Milchior added 1 comment

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Arthur Milchior . unresolved

I don’t know why I was added, there is no iles I own here.

FYI, the standard chrome way to do this (and probably the only way you can get it done due to the number of merge conflict git CL gets) is:

• you introduce `ChildProcessId`, and define `ChildProcess` as an alias for `ChildProcessId ` in a first CL
• You then use the shell command `git cl split` to split the CL in a lot of smaller CLs that can be more easily reviewed by the owners of various parts.
• If you still get merge conflict, you rebase those smaller conflicts
• once all are merged, you remove the alias

I’m sorry that this is much extra work. But even with owner override, the problem of merge conflict remains.

Open in Gerrit

Related details

Attention is currently required from:

• Alex Turner
• Bo Liu
• Christian Dullweber
• Christopher Staite
• Dave Tapuska
• David Roger
• Elly FJ
• Gauthier Ambard
• James Cook
• Ken Buchanan
• Matt Mueller
• Nathan Parker
• Sean Topping
• Takashi Toyoshima

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I46e24cac5857a0ac4182991f4edbb5ffcf26ebac

Gerrit-Change-Number: 7557820

Gerrit-PatchSet: 5

Gerrit-Owner: Christopher Staite <christoph...@menlosecurity.com>

Gerrit-Reviewer: Alex Turner <ale...@chromium.org>

Gerrit-Reviewer: Arthur Milchior <arthurm...@chromium.org>

Gerrit-Reviewer: Bo Liu <bo...@chromium.org>

Gerrit-Reviewer: Christian Dullweber <dull...@chromium.org>

Gerrit-Reviewer: Dave Tapuska <dtap...@chromium.org>

Gerrit-Reviewer: David Roger <dro...@chromium.org>

Gerrit-Reviewer: Elly FJ <elly...@chromium.org>

Gerrit-Reviewer: Gauthier Ambard <gam...@chromium.org>

Gerrit-Reviewer: Giovanni Ortuno Urquidi <ort...@chromium.org>

Gerrit-Reviewer: James Cook <jame...@chromium.org>

Gerrit-Reviewer: Ken Buchanan <ke...@chromium.org>

Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>

Gerrit-Reviewer: Matt Mueller <ma...@chromium.org>

Gerrit-Reviewer: Nathan Parker <npa...@chromium.org>

Gerrit-Reviewer: Sean Topping <seant...@chromium.org>

Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>

Gerrit-CC: Alexander Cooper <alco...@chromium.org>

Gerrit-CC: Chrome Security IPC Reviews <chrome-securi...@google.com>

Gerrit-CC: Chrome Signin Team <chrome-sig...@google.com>

Gerrit-CC: Heron Yang <hero...@google.com>

Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>

Gerrit-CC: James Maclean <wjma...@chromium.org>

Gerrit-CC: Mangesh Ghiware <mghi...@google.com>

Gerrit-CC: Peter Beverloo <pe...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: gwsq

Gerrit-Attention: James Cook <jame...@chromium.org>

Gerrit-Attention: Christopher Staite <christoph...@menlosecurity.com>

Gerrit-Attention: Alex Turner <ale...@chromium.org>

Gerrit-Attention: Bo Liu <bo...@chromium.org>

Gerrit-Attention: Christian Dullweber <dull...@chromium.org>

Gerrit-Attention: Dave Tapuska <dtap...@chromium.org>

Gerrit-Attention: David Roger <dro...@chromium.org>

Gerrit-Attention: Matt Mueller <ma...@chromium.org>

Gerrit-Attention: Takashi Toyoshima <toyo...@chromium.org>

Gerrit-Attention: Ken Buchanan <ke...@chromium.org>

Gerrit-Attention: Elly FJ <elly...@chromium.org>

Gerrit-Attention: Nathan Parker <npa...@chromium.org>

Gerrit-Attention: Sean Topping <seant...@chromium.org>

Gerrit-Attention: Gauthier Ambard <gam...@chromium.org>

Gerrit-Comment-Date: Thu, 12 Feb 2026 11:23:01 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Christian Dullweber (Gerrit)]

Attention needed from Alex Turner, Bo Liu, Christopher Staite, Dave Tapuska, David Roger, Elly FJ, Gauthier Ambard, James Cook, Ken Buchanan, Matt Mueller, Nathan Parker, Sean Topping and Takashi Toyoshima

Christian Dullweber voted and added 1 comment

Votes added by Christian Dullweber

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Christian Dullweber . resolved

components/legion lgtm

Open in Gerrit

Related details

Attention is currently required from:

• Alex Turner
• Bo Liu

Gerrit-Attention: Dave Tapuska <dtap...@chromium.org>

Gerrit-Attention: David Roger <dro...@chromium.org>

Gerrit-Attention: Matt Mueller <ma...@chromium.org>

Gerrit-Attention: Takashi Toyoshima <toyo...@chromium.org>

Gerrit-Attention: Ken Buchanan <ke...@chromium.org>

Gerrit-Attention: Elly FJ <elly...@chromium.org>

Gerrit-Attention: Nathan Parker <npa...@chromium.org>

Gerrit-Attention: Sean Topping <seant...@chromium.org>

Gerrit-Attention: Gauthier Ambard <gam...@chromium.org>

Gerrit-Comment-Date: Thu, 12 Feb 2026 12:11:38 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Christian Dullweber (Gerrit)]

Attention needed from Alex Turner, Bo Liu, Christopher Staite, Dave Tapuska, David Roger, Elly FJ, Gauthier Ambard, James Cook, Ken Buchanan, Matt Mueller, Nathan Parker, Sean Topping and Takashi Toyoshima

Christian Dullweber added 1 comment

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Christian Dullweber . unresolved

It might be easier to get this CL merged by splitting it up. Create an alias for the old name, then migrate call sites piece by piece before you remove the old name?

Gerrit-Comment-Date: Thu, 12 Feb 2026 12:12:49 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Christopher Staite (Gerrit)]

Christopher Staite added 2 comments

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Christian Dullweber . unresolved

It might be easier to get this CL merged by splitting it up. Create an alias for the old name, then migrate call sites piece by piece before you remove the old name?

Christopher Staite

That's a good idea. I'm not sure how well I can break it up due to the mojom rewriting. I'll take a look.

File-level comment, Patchset 5 (Latest):

Arthur Milchior . unresolved

I don’t know why I was added, there is no iles I own here.

FYI, the standard chrome way to do this (and probably the only way you can get it done due to the number of merge conflict git CL gets) is:

• you introduce `ChildProcessId`, and define `ChildProcess` as an alias for `ChildProcessId ` in a first CL
• You then use the shell command `git cl split` to split the CL in a lot of smaller CLs that can be more easily reviewed by the owners of various parts.
• If you still get merge conflict, you rebase those smaller conflicts
• once all are merged, you remove the alias

I’m sorry that this is much extra work. But even with owner override, the problem of merge conflict remains.

Christopher Staite

Thanks, I think you were auto-added as Chrome Signin Team for login_handler_unittest.cc. Thanks for the information.

Open in Gerrit

Related details

Attention set is empty

Gerrit-Comment-Date: Thu, 12 Feb 2026 12:23:50 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Arthur Milchior <arthurm...@chromium.org>

Comment-In-Reply-To: Christian Dullweber <dull...@chromium.org>

[Bo Liu (Gerrit)]

Attention needed from Christopher Staite

Bo Liu voted and added 1 comment

Votes added by Bo Liu

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Christian Dullweber . unresolved

It might be easier to get this CL merged by splitting it up. Create an alias for the old name, then migrate call sites piece by piece before you remove the old name?

Christopher Staite

That's a good idea. I'm not sure how well I can break it up due to the mojom rewriting. I'll take a look.

Bo Liu

Another possible route, find someone relevant with owner-override powers (and does timely reviews):
https://chromium.googlesource.com/chromium/src/+/HEAD/docs/code_review_owners.md#what-should-i-do-when-i-need-to-get-owners_override-for-one_off-cls

You can call out that this is basically a *mechanical* search and replace in the CL description.

Open in Gerrit

Related details

Attention is currently required from:

• Christopher Staite

Gerrit-Attention: Christopher Staite <christoph...@menlosecurity.com>

Gerrit-Comment-Date: Thu, 12 Feb 2026 15:37:18 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

Comment-In-Reply-To: Christopher Staite <christoph...@menlosecurity.com>

Comment-In-Reply-To: Christian Dullweber <dull...@chromium.org>

[Dave Tapuska (Gerrit)]

Attention needed from Christopher Staite

Dave Tapuska voted

Code-Review	+1
Owners-Override	+1

Open in Gerrit

Related details

Attention is currently required from:

• Christopher Staite

Submit Requirements:

• Code-Coverage
• Code-Owners

Gerrit-Comment-Date: Thu, 12 Feb 2026 15:51:46 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Dave Tapuska (Gerrit)]

Attention needed from Christopher Staite

Dave Tapuska added 1 comment

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Christian Dullweber . unresolved

It might be easier to get this CL merged by splitting it up. Create an alias for the old name, then migrate call sites piece by piece before you remove the old name?

Christopher Staite

That's a good idea. I'm not sure how well I can break it up due to the mojom rewriting. I'll take a look.

Bo Liu

Another possible route, find someone relevant with owner-override powers (and does timely reviews):
https://chromium.googlesource.com/chromium/src/+/HEAD/docs/code_review_owners.md#what-should-i-do-when-i-need-to-get-owners_override-for-one_off-cls

You can call out that this is basically a *mechanical* search and replace in the CL description.

Dave Tapuska

I have the power, and have reviewed the entire CL.

Gerrit-Comment-Date: Thu, 12 Feb 2026 15:52:19 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Bo Liu <bo...@chromium.org>

[Christopher Staite (Gerrit)]

Attention needed from Arthur Milchior, Bo Liu, Christian Dullweber, Dave Tapuska, Giovanni Ortuno Urquidi and Kenichi Ishibashi

Christopher Staite added 2 comments

Patchset-level comments

File-level comment, Patchset 5:

Christian Dullweber . resolved

It might be easier to get this CL merged by splitting it up. Create an alias for the old name, then migrate call sites piece by piece before you remove the old name?

Christopher Staite

That's a good idea. I'm not sure how well I can break it up due to the mojom rewriting. I'll take a look.

Bo Liu

Another possible route, find someone relevant with owner-override powers (and does timely reviews):
https://chromium.googlesource.com/chromium/src/+/HEAD/docs/code_review_owners.md#what-should-i-do-when-i-need-to-get-owners_override-for-one_off-cls

You can call out that this is basically a *mechanical* search and replace in the CL description.

Dave Tapuska

I have the power, and have reviewed the entire CL.

Christopher Staite

Thank you! I have rebased which hopefully fixed the merge conflict, there was no merge conflict detected locally by Git.

I will take the advise on how to approach this in future under my belt.

File-level comment, Patchset 5:

Arthur Milchior . resolved

I don’t know why I was added, there is no iles I own here.

FYI, the standard chrome way to do this (and probably the only way you can get it done due to the number of merge conflict git CL gets) is:

• you introduce `ChildProcessId`, and define `ChildProcess` as an alias for `ChildProcessId ` in a first CL
• You then use the shell command `git cl split` to split the CL in a lot of smaller CLs that can be more easily reviewed by the owners of various parts.
• If you still get merge conflict, you rebase those smaller conflicts
• once all are merged, you remove the alias

I’m sorry that this is much extra work. But even with owner override, the problem of merge conflict remains.

Christopher Staite

Thanks, I think you were auto-added as Chrome Signin Team for login_handler_unittest.cc. Thanks for the information.

Christopher Staite

Done

Open in Gerrit

Related details

Attention is currently required from:

• Arthur Milchior
• Bo Liu
• Christian Dullweber
• Dave Tapuska

• Giovanni Ortuno Urquidi
• Kenichi Ishibashi

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I46e24cac5857a0ac4182991f4edbb5ffcf26ebac

Gerrit-Change-Number: 7557820

Gerrit-PatchSet: 6

Gerrit-Attention: Kenichi Ishibashi <ba...@chromium.org>

Gerrit-Attention: Arthur Milchior <arthurm...@chromium.org>

Gerrit-Attention: Bo Liu <bo...@chromium.org>

Gerrit-Attention: Giovanni Ortuno Urquidi <ort...@chromium.org>

Gerrit-Attention: Christian Dullweber <dull...@chromium.org>

Gerrit-Attention: Dave Tapuska <dtap...@chromium.org>

Gerrit-Comment-Date: Thu, 12 Feb 2026 15:57:26 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Arthur Milchior <arthurm...@chromium.org>

Comment-In-Reply-To: Bo Liu <bo...@chromium.org>

Comment-In-Reply-To: Christopher Staite <christoph...@menlosecurity.com>

Comment-In-Reply-To: Christian Dullweber <dull...@chromium.org>

Comment-In-Reply-To: Dave Tapuska <dtap...@chromium.org>

[Dave Tapuska (Gerrit)]

Attention needed from Bo Liu, Christopher Staite, Giovanni Ortuno Urquidi and Kenichi Ishibashi

Dave Tapuska voted

Code-Review	+1
Owners-Override	+1

Open in Gerrit

Related details

Attention is currently required from:

• Bo Liu
• Christopher Staite

• Giovanni Ortuno Urquidi
• Kenichi Ishibashi

Submit Requirements:

• Code-Coverage
• Code-Owners

Gerrit-Attention: Christopher Staite <christoph...@menlosecurity.com>

Gerrit-Attention: Bo Liu <bo...@chromium.org>

Gerrit-Attention: Giovanni Ortuno Urquidi <ort...@chromium.org>

Gerrit-Comment-Date: Thu, 12 Feb 2026 15:59:51 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Nathan Parker (Gerrit)]

Attention needed from Bo Liu, Christopher Staite, Giovanni Ortuno Urquidi and Kenichi Ishibashi

Nathan Parker voted and added 1 comment

Votes added by Nathan Parker

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 6 (Latest):

Nathan Parker . resolved

LGTM for safe_browsing

Open in Gerrit

Related details

Attention is currently required from:

• Bo Liu
• Christopher Staite
• Giovanni Ortuno Urquidi
• Kenichi Ishibashi

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• Review-Enforcement

Gerrit-Comment-Date: Thu, 12 Feb 2026 18:02:10 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[James Cook (Gerrit)]

Attention needed from Bo Liu, Christopher Staite, Giovanni Ortuno Urquidi and Kenichi Ishibashi

James Cook voted and added 1 comment

Votes added by James Cook

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 6 (Latest):

James Cook . resolved

LGTM for *extensions*

Gerrit-Comment-Date: Thu, 12 Feb 2026 18:23:29 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Dave Tapuska (Gerrit)]

Attention needed from Bo Liu, Christopher Staite, Giovanni Ortuno Urquidi and Kenichi Ishibashi

Dave Tapuska voted Commit-Queue+2

Commit-Queue

+2

Gerrit-Comment-Date: Thu, 12 Feb 2026 18:28:27 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Kenichi Ishibashi (Gerrit)]

Attention needed from Bo Liu, Christopher Staite, Dave Tapuska and Giovanni Ortuno Urquidi

Kenichi Ishibashi voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Bo Liu
• Christopher Staite

• Dave Tapuska
• Giovanni Ortuno Urquidi

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Heron Yang <hero...@google.com>

Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>

Gerrit-CC: James Maclean <wjma...@chromium.org>

Gerrit-CC: Mangesh Ghiware <mghi...@google.com>

Gerrit-CC: Peter Beverloo <pe...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: gwsq

Gerrit-Attention: Christopher Staite <christoph...@menlosecurity.com>

Gerrit-Attention: Bo Liu <bo...@chromium.org>

Gerrit-Attention: Giovanni Ortuno Urquidi <ort...@chromium.org>

Gerrit-Attention: Dave Tapuska <dtap...@chromium.org>

Gerrit-Comment-Date: Fri, 13 Feb 2026 00:48:32 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Kenichi Ishibashi (Gerrit)]

Attention needed from Bo Liu, Christopher Staite, Dave Tapuska, Giovanni Ortuno Urquidi, James Cook and Nathan Parker

Kenichi Ishibashi voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Bo Liu
• Christopher Staite
• Dave Tapuska
• Giovanni Ortuno Urquidi

• James Cook
• Nathan Parker

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I46e24cac5857a0ac4182991f4edbb5ffcf26ebac

Gerrit-Change-Number: 7557820

Gerrit-PatchSet: 7

Gerrit-Attention: James Cook <jame...@chromium.org>

Gerrit-Attention: Christopher Staite <christoph...@menlosecurity.com>

Gerrit-Attention: Bo Liu <bo...@chromium.org>

Gerrit-Attention: Giovanni Ortuno Urquidi <ort...@chromium.org>

Gerrit-Attention: Nathan Parker <npa...@chromium.org>

Gerrit-Attention: Dave Tapuska <dtap...@chromium.org>

Gerrit-Comment-Date: Mon, 16 Feb 2026 00:40:17 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Arthur Milchior (Gerrit)]

Attention needed from Bo Liu, Christopher Staite, Dave Tapuska, Giovanni Ortuno Urquidi, James Cook and Nathan Parker

Arthur Milchior voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Bo Liu
• Christopher Staite
• Dave Tapuska
• Giovanni Ortuno Urquidi
• James Cook
• Nathan Parker

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• Review-Enforcement

Gerrit-Comment-Date: Mon, 16 Feb 2026 14:00:19 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Dave Tapuska (Gerrit)]

Attention needed from Bo Liu, Christopher Staite, Giovanni Ortuno Urquidi, James Cook and Nathan Parker

Dave Tapuska voted

Code-Review	+1
Owners-Override	+1

Open in Gerrit

Related details

Attention is currently required from:

• Bo Liu
• Christopher Staite

• Giovanni Ortuno Urquidi
• James Cook
• Nathan Parker

Submit Requirements:

• Code-Coverage
• Code-Owners

Gerrit-Comment-Date: Tue, 17 Feb 2026 14:52:19 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Dave Tapuska (Gerrit)]

Attention needed from Bo Liu, Christopher Staite, Giovanni Ortuno Urquidi, James Cook and Nathan Parker

Dave Tapuska voted Commit-Queue+2

Commit-Queue

+2

Gerrit-Comment-Date: Tue, 17 Feb 2026 14:52:34 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Arthur Milchior (Gerrit)]

Attention needed from Bo Liu, Christopher Staite, Dave Tapuska, Giovanni Ortuno Urquidi, James Cook, Kenichi Ishibashi and Nathan Parker

Arthur Milchior voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Bo Liu
• Christopher Staite
• Dave Tapuska

• Giovanni Ortuno Urquidi
• James Cook

• Kenichi Ishibashi
• Nathan Parker

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I46e24cac5857a0ac4182991f4edbb5ffcf26ebac

Gerrit-Change-Number: 7557820

Gerrit-PatchSet: 8

Gerrit-Attention: Kenichi Ishibashi <ba...@chromium.org>

Gerrit-Attention: Christopher Staite <christoph...@menlosecurity.com>

Gerrit-Attention: Bo Liu <bo...@chromium.org>

Gerrit-Attention: Giovanni Ortuno Urquidi <ort...@chromium.org>

Gerrit-Attention: Nathan Parker <npa...@chromium.org>

Gerrit-Attention: Dave Tapuska <dtap...@chromium.org>

Gerrit-Comment-Date: Tue, 17 Feb 2026 15:30:32 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[James Cook (Gerrit)]

Attention needed from Bo Liu, Christopher Staite, Dave Tapuska, Giovanni Ortuno Urquidi, Kenichi Ishibashi and Nathan Parker

James Cook voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Bo Liu
• Christopher Staite
• Dave Tapuska
• Giovanni Ortuno Urquidi

• Kenichi Ishibashi
• Nathan Parker

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• Review-Enforcement

Gerrit-Attention: Kenichi Ishibashi <ba...@chromium.org>

Gerrit-Attention: Christopher Staite <christoph...@menlosecurity.com>

Gerrit-Attention: Bo Liu <bo...@chromium.org>

Gerrit-Attention: Giovanni Ortuno Urquidi <ort...@chromium.org>

Gerrit-Attention: Nathan Parker <npa...@chromium.org>

Gerrit-Attention: Dave Tapuska <dtap...@chromium.org>

Gerrit-Comment-Date: Tue, 17 Feb 2026 18:24:32 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Kenichi Ishibashi (Gerrit)]

Attention needed from Bo Liu, Christopher Staite, Dave Tapuska, Giovanni Ortuno Urquidi and Nathan Parker

Kenichi Ishibashi voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Bo Liu
• Christopher Staite
• Dave Tapuska
• Giovanni Ortuno Urquidi

• Nathan Parker

Gerrit-Attention: Christopher Staite <christoph...@menlosecurity.com>

Gerrit-Attention: Bo Liu <bo...@chromium.org>

Gerrit-Attention: Giovanni Ortuno Urquidi <ort...@chromium.org>

Gerrit-Attention: Nathan Parker <npa...@chromium.org>

Gerrit-Attention: Dave Tapuska <dtap...@chromium.org>

Gerrit-Comment-Date: Wed, 18 Feb 2026 01:30:12 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Dave Tapuska (Gerrit)]

Attention needed from Bo Liu, Christopher Staite, Giovanni Ortuno Urquidi and Nathan Parker

Dave Tapuska voted

Code-Review	+1
Commit-Queue	+2
Owners-Override	+1

Open in Gerrit

Related details

Attention is currently required from:

• Bo Liu
• Christopher Staite

Gerrit-Comment-Date: Wed, 18 Feb 2026 14:18:21 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Chromium LUCI CQ (Gerrit)]

Chromium LUCI CQ submitted the change

Change information

Commit message:

Rename OriginatingProcess to OriginatingProcessId

In https://crrev.com/c/7498491 the new types network::OriginatingProcess
and network::RendererProcess were introduced to mirror
content::ChildProcessId.  However, since then in using these types it
has caused some confusion due to a poor choice of name.  These are not
functional types, simply IDs referring to a process.

This CL resolves that naming issue before this persists and renames
network::OriginatingProcess to network::OriginatingProcessId and
network::RendererProcess to network::RendererProcessId.  There is no
functional change, simply a type renaming.

Bug: 379869738

Change-Id: I46e24cac5857a0ac4182991f4edbb5ffcf26ebac

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7557820

Reviewed-by: Kenichi Ishibashi <ba...@chromium.org>

Reviewed-by: Dave Tapuska <dtap...@chromium.org>

Commit-Queue: Dave Tapuska <dtap...@chromium.org>

Reviewed-by: Arthur Milchior <arthurm...@chromium.org>

Reviewed-by: James Cook <jame...@chromium.org>

Owners-Override: Dave Tapuska <dtap...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1586511}

Files:

• M android_webview/browser/aw_browser_context.cc
• M chrome/browser/ash/bruschetta/bruschetta_network_context.cc
• M chrome/browser/chrome_content_browser_client.cc
• M chrome/browser/component_updater/crl_set_component_installer_unittest.cc
• M chrome/browser/extensions/api/web_request/web_request_apitest.cc
• M chrome/browser/net/system_network_context_manager.cc
• M chrome/browser/net/websocket_browsertest.cc
• M chrome/browser/ui/login/login_handler_unittest.cc
• M chromecast/browser/cast_network_contexts.cc
• M components/legion/websocket_client.cc
• M components/live_caption/google_api_translation_dispatcher.cc
• M components/net_log/net_export_file_writer_unittest.cc
• M components/page_load_metrics/browser/observers/ad_metrics/ads_page_load_metrics_observer.cc
• M components/page_load_metrics/browser/observers/ad_metrics/frame_tree_data.cc
• M components/page_load_metrics/browser/resource_tracker.cc
• M components/page_load_metrics/browser/resource_tracker_unittest.cc
• M components/safe_browsing/core/browser/utils/url_loader_factory_params.cc
• M content/browser/devtools/devtools_url_loader_interceptor.cc
• M content/browser/devtools/render_frame_devtools_agent_host.cc
• M content/browser/devtools/service_worker_devtools_agent_host.cc
• M content/browser/loader/navigation_url_loader_impl.cc
• M content/browser/network_service_browsertest.cc
• M content/browser/network_service_restart_browsertest.cc
• M content/browser/preloading/prefetch/prefetch_url_loader_factory_utils.cc
• M content/browser/renderer_host/render_frame_host_impl.cc
• M content/browser/service_worker/embedded_worker_instance.cc
• M content/browser/storage_partition_impl.cc
• M content/browser/storage_partition_impl.h
• M content/browser/storage_partition_impl_browsertest.cc
• M content/browser/storage_partition_impl_unittest.cc
• M content/browser/url_loader_factory_params_helper.cc
• M content/browser/websockets/websocket_connector_impl.cc
• M content/browser/webtransport/web_transport_connector_impl.cc
• M content/browser/worker_host/dedicated_worker_host.cc
• M content/browser/worker_host/shared_worker_host.cc
• M content/public/browser/global_request_id.cc
• M content/public/browser/global_request_id.h
• M content/public/common/child_process_id_util.cc
• M content/public/common/child_process_id_util.h
• M content/public/test/browser_test_utils.cc
• M device/fido/cable/fido_tunnel_device.cc
• M device/fido/cable/v2_authenticator.cc
• M device/fido/cable/v2_test_util.cc
• M device/fido/enclave/enclave_websocket_client.cc
• M extensions/browser/api/web_request/web_request_api.cc
• M extensions/browser/api/web_request/web_request_proxying_url_loader_factory.cc
• M google_apis/common/base_requests_unittest.cc
• M google_apis/drive/drive_api_requests_unittest.cc
• M google_apis/drive/drive_base_requests_server_unittest.cc
• M google_apis/drive/drive_base_requests_unittest.cc
• M google_apis/drive/files_list_request_runner_unittest.cc
• M google_apis/gcm/tools/mcs_probe.cc
• M ios/chrome/browser/profile/model/ios_chrome_io_thread.mm
• M ios/web/browser_state.mm
• M ios/web_view/internal/app/application_context.mm
• M services/cert_verifier/integration_tests/network_context_unittest.cc
• M services/cert_verifier/integration_tests/network_service_unittest.cc
• M services/network/cors/cors_url_loader.cc
• M services/network/cors/cors_url_loader.h
• M services/network/cors/cors_url_loader_factory.h
• M services/network/cors/cors_url_loader_factory_unittest.cc
• M services/network/cors/cors_url_loader_tao_unittest.cc
• M services/network/cors/cors_url_loader_test_util.cc
• M services/network/cors/cors_url_loader_test_util.h
• M services/network/cors/cors_url_loader_unittest.cc
• M services/network/cors/preflight_controller_unittest.cc
• M services/network/network_context.cc
• M services/network/network_context.h
• M services/network/network_context_unittest.cc
• M services/network/network_service.cc
• M services/network/network_service.h
• M services/network/network_service_unittest.cc
• M services/network/oblivious_http_request_handler.cc
• M services/network/public/cpp/BUILD.gn
• D services/network/public/cpp/originating_process.cc
• D services/network/public/cpp/originating_process.h
• A services/network/public/cpp/originating_process_id.cc
• A services/network/public/cpp/originating_process_id.h
• A services/network/public/cpp/originating_process_id_mojom_traits.cc
• A services/network/public/cpp/originating_process_id_mojom_traits.h
• A services/network/public/cpp/originating_process_id_mojom_traits_unittest.cc
• D services/network/public/cpp/originating_process_mojom_traits.cc
• D services/network/public/cpp/originating_process_mojom_traits.h
• D services/network/public/cpp/originating_process_mojom_traits_unittest.cc
• D services/network/public/cpp/renderer_process.h
• A services/network/public/cpp/renderer_process_id.h
• A services/network/public/cpp/renderer_process_id_mojom_traits.cc
• A services/network/public/cpp/renderer_process_id_mojom_traits.h
• A services/network/public/cpp/renderer_process_id_mojom_traits_unittest.cc
• D services/network/public/cpp/renderer_process_mojom_traits.cc
• D services/network/public/cpp/renderer_process_mojom_traits.h
• D services/network/public/cpp/renderer_process_mojom_traits_unittest.cc
• M services/network/public/cpp/simple_url_loader_unittest.cc
• M services/network/public/mojom/BUILD.gn
• M services/network/public/mojom/network_context.mojom
• M services/network/public/mojom/network_service.mojom
• R services/network/public/mojom/originating_process_id.mojom
• M services/network/sct_auditing/sct_auditing_handler.cc
• M services/network/test/test_network_context.h
• M services/network/test/test_shared_url_loader_factory.cc
• M services/network/transitional_url_loader_factory_owner.cc
• M services/network/url_loader_unittest.cc
• M services/network/websocket_factory.cc
• M services/network/websocket_factory.h
• M services/network/websocket_factory_unittest.cc
• M services/network/websocket_throttler.cc
• M services/network/websocket_throttler.h
• M services/network/websocket_throttler_unittest.cc
• M tools/aggregation_service/aggregation_service_tool_network_initializer.cc

Change size: XL

Delta: 109 files changed, 825 insertions(+), 764 deletions(-)

Branch: refs/heads/main

Submit Requirements:

• Code-Review: +1 by Arthur Milchior, +1 by Dave Tapuska, +1 by Kenichi Ishibashi, +1 by James Cook

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I46e24cac5857a0ac4182991f4edbb5ffcf26ebac

Gerrit-Change-Number: 7557820

Gerrit-PatchSet: 9

Gerrit-Owner: Christopher Staite <christoph...@menlosecurity.com>

Gerrit-Reviewer: Alex Turner <ale...@chromium.org>

Gerrit-Reviewer: Arthur Milchior <arthurm...@chromium.org>

Gerrit-Reviewer: Bo Liu <bo...@chromium.org>

Gerrit-Reviewer: Christian Dullweber <dull...@chromium.org>

Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Dave Tapuska <dtap...@chromium.org>

Gerrit-Reviewer: David Roger <dro...@chromium.org>

Gerrit-Reviewer: Elly FJ <elly...@chromium.org>

Gerrit-Reviewer: Gauthier Ambard <gam...@chromium.org>

Gerrit-Reviewer: Giovanni Ortuno Urquidi <ort...@chromium.org>

Gerrit-Reviewer: James Cook <jame...@chromium.org>

Gerrit-Reviewer: Ken Buchanan <ke...@chromium.org>

Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>

Gerrit-Reviewer: Matt Mueller <ma...@chromium.org>

Gerrit-Reviewer: Nathan Parker <npa...@chromium.org>

Gerrit-Reviewer: Sean Topping <seant...@chromium.org>

Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>

Gerrit-CC: Alexander Cooper <alco...@chromium.org>

Gerrit-CC: Chrome Security IPC Reviews <chrome-securi...@google.com>

Gerrit-CC: Chrome Signin Team <chrome-sig...@google.com>