WebDX: Rename TextDetect feature to TextDetection [chromium/src : main]

0 views
Skip to first unread message

Alvin Ji (Gerrit)

unread,
Feb 13, 2026, 3:08:50 PM (9 days ago) Feb 13
to Takashi Toyoshima, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
Attention needed from Takashi Toyoshima

Alvin Ji voted and added 1 comment

Votes added by Alvin Ji

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Alvin Ji . resolved

Hi Takashi,
PTAL and thanks!
Alvin

Open in Gerrit

Related details

Attention is currently required from:
  • Takashi Toyoshima
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ifff88778f0174c4a07e3380b60deb299836a4bbf
Gerrit-Change-Number: 7576084
Gerrit-PatchSet: 3
Gerrit-Owner: Alvin Ji <alv...@chromium.org>
Gerrit-Reviewer: Alvin Ji <alv...@chromium.org>
Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Attention: Takashi Toyoshima <toyo...@chromium.org>
Gerrit-Comment-Date: Fri, 13 Feb 2026 20:08:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Takashi Toyoshima (Gerrit)

unread,
Feb 15, 2026, 10:10:23 PM (6 days ago) Feb 15
to Alvin Ji, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
Attention needed from Alvin Ji

Takashi Toyoshima voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Alvin Ji
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ifff88778f0174c4a07e3380b60deb299836a4bbf
    Gerrit-Change-Number: 7576084
    Gerrit-PatchSet: 3
    Gerrit-Owner: Alvin Ji <alv...@chromium.org>
    Gerrit-Reviewer: Alvin Ji <alv...@chromium.org>
    Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Alvin Ji <alv...@chromium.org>
    Gerrit-Comment-Date: Mon, 16 Feb 2026 03:09:53 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Alvin Ji (Gerrit)

    unread,
    Feb 17, 2026, 12:03:22 PM (5 days ago) Feb 17
    to Takashi Toyoshima, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org

    Alvin Ji voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ifff88778f0174c4a07e3380b60deb299836a4bbf
    Gerrit-Change-Number: 7576084
    Gerrit-PatchSet: 3
    Gerrit-Owner: Alvin Ji <alv...@chromium.org>
    Gerrit-Reviewer: Alvin Ji <alv...@chromium.org>
    Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Comment-Date: Tue, 17 Feb 2026 17:03:14 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Feb 17, 2026, 1:05:07 PM (5 days ago) Feb 17
    to Alvin Ji, Takashi Toyoshima, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    WebDX: Rename TextDetect feature to TextDetection

    This CL renames the WebDXFeature::kTextDetect enum and its associated
    mappings to kTextDetection. The "web-features" project (which powers the
    WebDX features dashboard) will uses "text-detection" as the canonical
    identifier for the Text Detection API. This rename ensures that
    Chromium's telemetry identifier (derived from the enum name) matches the
    public dashboard's schema.
    Change-Id: Ifff88778f0174c4a07e3380b60deb299836a4bbf
    Bug: 484343382
    Commit-Queue: Alvin Ji <alv...@chromium.org>
    Reviewed-by: Takashi Toyoshima <toyo...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1585834}
    Files:
    • M components/page_load_metrics/browser/observers/use_counter/webdx_feature_maps.cc
    • M third_party/blink/public/mojom/use_counter/metrics/webdx_feature.mojom
    • M tools/metrics/histograms/metadata/blink/enums.xml
    Change size: XS
    Delta: 3 files changed, 3 insertions(+), 3 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Takashi Toyoshima
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ifff88778f0174c4a07e3380b60deb299836a4bbf
    Gerrit-Change-Number: 7576084
    Gerrit-PatchSet: 4
    Gerrit-Owner: Alvin Ji <alv...@chromium.org>
    Gerrit-Reviewer: Alvin Ji <alv...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
    open
    diffy
    satisfied_requirement

    Alvin Ji (Gerrit)

    unread,
    Feb 17, 2026, 5:02:06 PM (5 days ago) Feb 17
    to Chromium LUCI CQ, Takashi Toyoshima, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
    Attention needed from Takashi Toyoshima

    Alvin Ji added 1 comment

    Patchset-level comments
    File-level comment, Patchset 4 (Latest):
    Alvin Ji . resolved

    Thanks for the review!

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Takashi Toyoshima
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ifff88778f0174c4a07e3380b60deb299836a4bbf
    Gerrit-Change-Number: 7576084
    Gerrit-PatchSet: 4
    Gerrit-Owner: Alvin Ji <alv...@chromium.org>
    Gerrit-Reviewer: Alvin Ji <alv...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Takashi Toyoshima <toyo...@chromium.org>
    Gerrit-Comment-Date: Tue, 17 Feb 2026 22:02:00 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages