Break HistoryTabHelper dependency on other tab helpers [chromium/src : main]

0 views
Skip to first unread message

Mike Wittman (Gerrit)

unread,
Feb 20, 2026, 1:47:47 AM (2 days ago) Feb 20
to Mike Wittman, manuk hovanesian, Michal Mocny, Mike Wasserman, Chromium LUCI CQ, chromium...@chromium.org, bmcquad...@chromium.org, browser-comp...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, core-web-vita...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
Attention needed from Michal Mocny, Mike Wasserman and manuk hovanesian

Mike Wittman added 1 comment

Patchset-level comments
File-level comment, Patchset 10 (Latest):
Mike Wittman . resolved

PTAL

manukh: chrome/browser/history*
mmocny: chrome/browser/page_load_metrics/observers/core/ukm_page_load_metrics_observer_unittest.cc
msw: chrome/browser/ui/tab_helpers.cc

Open in Gerrit

Related details

Attention is currently required from:
  • Michal Mocny
  • Mike Wasserman
  • manuk hovanesian
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I94d0826ba4e37711ac541356011bb00dbe2ebd4d
Gerrit-Change-Number: 7577994
Gerrit-PatchSet: 10
Gerrit-Owner: Mike Wittman <wit...@chromium.org>
Gerrit-Reviewer: Michal Mocny <mmo...@chromium.org>
Gerrit-Reviewer: Mike Wasserman <m...@chromium.org>
Gerrit-Reviewer: Mike Wittman <wit...@chromium.org>
Gerrit-Reviewer: manuk hovanesian <man...@chromium.org>
Gerrit-Attention: Mike Wasserman <m...@chromium.org>
Gerrit-Attention: manuk hovanesian <man...@chromium.org>
Gerrit-Attention: Michal Mocny <mmo...@chromium.org>
Gerrit-Comment-Date: Fri, 20 Feb 2026 06:47:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Mike Wasserman (Gerrit)

unread,
Feb 20, 2026, 12:52:22 PM (2 days ago) Feb 20
to Mike Wittman, manuk hovanesian, Michal Mocny, Chromium LUCI CQ, chromium...@chromium.org, bmcquad...@chromium.org, browser-comp...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, core-web-vita...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
Attention needed from Michal Mocny, Mike Wittman and manuk hovanesian

Mike Wasserman voted and added 2 comments

Votes added by Mike Wasserman

Code-Review+1

2 comments

Patchset-level comments
Mike Wasserman . resolved

lgtm with optional suggestion

File chrome/browser/ui/tab_helpers.cc
Line 445, Patchset 10 (Latest): HistoryTabHelper::CreateForWebContents(web_contents);
{
HistoryTabHelper* history_tab_helper =
HistoryTabHelper::FromWebContents(web_contents);
Mike Wasserman . unresolved

optional minor nit: consider calling HistoryTabHelper::FromWebContents within the other helper factories (to keep this common file cleaner). Or maybe use GetOrCreateForWebContents here

Open in Gerrit

Related details

Attention is currently required from:
  • Michal Mocny
  • Mike Wittman
  • manuk hovanesian
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I94d0826ba4e37711ac541356011bb00dbe2ebd4d
    Gerrit-Change-Number: 7577994
    Gerrit-PatchSet: 10
    Gerrit-Owner: Mike Wittman <wit...@chromium.org>
    Gerrit-Reviewer: Michal Mocny <mmo...@chromium.org>
    Gerrit-Reviewer: Mike Wasserman <m...@chromium.org>
    Gerrit-Reviewer: Mike Wittman <wit...@chromium.org>
    Gerrit-Reviewer: manuk hovanesian <man...@chromium.org>
    Gerrit-Attention: Mike Wittman <wit...@chromium.org>
    Gerrit-Attention: manuk hovanesian <man...@chromium.org>
    Gerrit-Attention: Michal Mocny <mmo...@chromium.org>
    Gerrit-Comment-Date: Fri, 20 Feb 2026 17:52:14 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages