WaaP: Add WebUIToolbar-specific page load metrics. [chromium/src : main]
Eriko Kurimoto (Gerrit)
Eriko Kurimoto added 5 comments![]( "Open in Gerrit")
This CL updates PageLoadMetricsBrowserTest to accepts the metrics forEriko KurimotoCan you update the description to reflect latest changes?
Done
void InitialWebUIPageLoadMetricsObserver::OnComplete(Eriko KurimotoIf you'd like to record LCP, then you should implement `FlushMetricsOnAppEnterBackground()` as well e.g. https://source.chromium.org/chromium/chromium/src/+/main:components/page_load_metrics/browser/observers/core/uma_page_load_metrics_observer.cc;l=891;drc=49e1cafbef2b9f992ad925f2e5a2016808eceb77;bpv=1;bpt=1
Done
return;Eriko KurimotoSo if `InitialWebUIPageLoadMetricsObserver` is registered, we don't register `NonTabPageLoadMetricsObserver` anymore. But previously both observers can be registered at the same time. Why do we need this change?
The point of this cl is to record page load metrics dedicated to InitialWebUI separately. They are handled in InitialWebUIPageLoadMetircsObserver instead of NonTabPageLoadMetricsObserver which records general page load metrics. Removing it is necessary to avoid dup of the metrics.
But the previous change unintentionally dropped WebUI.TopChrome.RequestTop* so recovered it in the latest patch.
aggregates.Eriko KurimotoCould you add when it is recorded?
Done
Related details
- Shunya Shishido
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Eriko Kurimoto (Gerrit)
Eriko Kurimoto added 1 comment![]( "Open in Gerrit")
As this change seems to be conficting with our metrics change.
@sisid...@chromium.org I will notify you again when we re-start or abandon the cl. No need for review now.
Related details
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |