Move PDF-related services

166 views
Skip to first unread message

Chu-Hsuan Yang

unread,
Apr 16, 2024, 12:44:16 AM4/16/24
to services-dev

Hi team,


We are adding PDF-related features to ChromeOS Camera App and would like to move services from //chrome/services outside of //chrome due to a recent restriction prohibiting new //chrome dependencies for Ash code.

There are two services that we want to move:

  1. PDF Service: Implementation and Service. Currently, only Ash uses this service.

  2. To be added PDF Searchify Service: Design document and prototype CL. After discussions with the security team, we have decided to run a separate process for each PDF Searchify request. We expect that it can be used in the browser.

We believe that the PDF Service can be moved to //chromeos/ash/services, while the PDF Searchify service can be moved to //services. However, we are also considering if there is a suitable location for both services. 

Could you shed some light on where to move the services (current //chrome/browser/pdf/pdf_service.h and //chrome/browser/printing/pdf_searchify_service.h) and the implementations?


Please let me know if any further information is required.


Thanks,

Chu-Hsuan


Colin Blundell

unread,
Apr 22, 2024, 8:27:39 AM4/22/24
to Chu-Hsuan Yang, services-dev
Replies inline, thanks!

On Tue, Apr 16, 2024 at 6:44 AM Chu-Hsuan Yang <chuh...@chromium.org> wrote:

Hi team,


We are adding PDF-related features to ChromeOS Camera App and would like to move services from //chrome/services outside of //chrome due to a recent restriction prohibiting new //chrome dependencies for Ash code.

There are two services that we want to move:

  1. PDF Service: Implementation and Service. Currently, only Ash uses this service.

  2. To be added PDF Searchify Service: Design document and prototype CL. After discussions with the security team, we have decided to run a separate process for each PDF Searchify request. We expect that it can be used in the browser.

We believe that the PDF Service can be moved to //chromeos/ash/services,


This makes sense to me on the assumption that it is Ash-specific.
 

while the PDF Searchify service can be moved to //services.


//services is for "foundational services". From looking at the description of the functionality, PDF Searchify to me feels that it fits more the description of //components/services.
 

However, we are also considering if there is a suitable location for both services. 

Could you shed some light on where to move the services (current //chrome/browser/pdf/pdf_service.h and //chrome/browser/printing/pdf_searchify_service.h) and the implementations?


Please let me know if any further information is required.


Thanks,

Chu-Hsuan


--
You received this message because you are subscribed to the Google Groups "services-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to services-dev...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/services-dev/1333d545-250b-4a03-8f60-7d1359555291n%40chromium.org.

Chu-Hsuan Yang

unread,
Apr 23, 2024, 6:33:59 AM4/23/24
to services-dev, Colin Blundell, services-dev, Chu-Hsuan Yang
Thank you, Colin! We have created b/335118703 to track the migration.

To unsubscribe from this group and stop receiving emails from it, send an email to services-dev+unsubscribe@chromium.org.
Reply all
Reply to author
Forward
0 new messages