Issue 1506014 in chromium: [WPT] New failures introduced in external/wpt/sanitizer-api by import https://crrev.com/c/5066625

963 views
Skip to first unread message

wpt-autoroller via monorail

unread,
Dec 4, 2023, 7:09:10 AM12/4/23
to securi...@chromium.org
Status: Untriaged
Owner: ----
CC: securi...@chromium.org
Labels: Test-WebTest
Components: Blink>SecurityFeature>SanitizerAPI
Pri: 3
Type: Bug

New issue 1506014 by wpt-aut...@chops-service-accounts.iam.gserviceaccount.com: [WPT] New failures introduced in external/wpt/sanitizer-api by import https://crrev.com/c/5066625
https://bugs.chromium.org/p/chromium/issues/detail?id=1506014

WPT import https://crrev.com/c/5066625 introduced new failures in external/wpt/sanitizer-api:

List of new failures:
[ Linux-chrome ] external/wpt/sanitizer-api/sanitizer-config.https.html new failing tests: https://crrev.com/c/5066625/4/third_party/blink/web_tests/platform/linux-chrome/external/wpt/sanitizer-api/sanitizer-config.https-expected.txt

Expectations or baseline files [0] have been automatically added for the failing results to keep the bots green. Please investigate the new failures and triage as appropriate.

Upstream changes imported:
https://github.com/web-platform-tests/wpt/compare/6cd9dc38dfb6c25163802c08670a3cd7639b3553...b6a99e45a1c671e59ed046c20fa24731543b46b1
Update sanitizer tests.: https://github.com/web-platform-tests/wpt/commit/b6a99e45a1c671e59ed046c20fa24731543b46b1 [affecting this directory]
[CompositeClipPathAnimation] Allow worklet animations to avoid unnecessary frames: https://github.com/web-platform-tests/wpt/commit/57c9cc80fbfac825da2f4e2bdedea55828f7ce76
align-content for blocks: Implement for table-cell: https://github.com/web-platform-tests/wpt/commit/3be16fbe785436743f90ff3785c5413cad7e427d
Add WPT coverage for Storage Access API and WebSockets: https://github.com/web-platform-tests/wpt/commit/3b751348f557941d2052396013d1e4bf2e260109

[0]: https://chromium.googlesource.com/chromium/src/+/HEAD/docs/testing/web_test_expectations.md

This bug was filed automatically due to a new WPT test failure for which you are marked an OWNER. If you do not want to receive these reports, please add "wpt { notify: NO }" to the relevant DIR_METADATA file.

--
You received this message because:
1. You were specifically CC'd on the issue

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

Reply to this email to add a comment or make updates.

chlily via monorail

unread,
Dec 11, 2023, 11:33:22 AM12/11/23
to securi...@chromium.org
Updates:
Owner: l...@chromium.org
Status: Assigned

Comment #1 on issue 1506014 by chl...@chromium.org: [WPT] New failures introduced in external/wpt/sanitizer-api by import https://crrev.com/c/5066625
https://bugs.chromium.org/p/chromium/issues/detail?id=1506014#c1

[security shepherd]

+lyf: Could you please take a look at these wpt failures for Sanitizer API? Mozilla seems to have updated the tests to a new proposed WebIDL: https://bugzilla.mozilla.org/show_bug.cgi?id=1864838

phao via monorail

unread,
Dec 11, 2023, 11:33:23 AM12/11/23
to securi...@chromium.org
Updates:
Owner: voge...@chromium.org

Comment #2 on issue 1506014 by ph...@chromium.org: [WPT] New failures introduced in external/wpt/sanitizer-api by import https://crrev.com/c/5066625
https://bugs.chromium.org/p/chromium/issues/detail?id=1506014#c2

vogelheim@ would be a better owner for sanitizer bugs.

vogelheim via monorail

unread,
Dec 12, 2023, 7:58:00 AM12/12/23
to securi...@chromium.org

Comment #3 on issue 1506014 by voge...@chromium.org: [WPT] New failures introduced in external/wpt/sanitizer-api by import https://crrev.com/c/5066625
https://bugs.chromium.org/p/chromium/issues/detail?id=1506014#c3

- I'm indeed the right addressee.
- We recently removed the Sanitizer API from stable, https://groups.google.com/a/chromium.org/g/blink-dev/c/PNTt4oFXt8c/m/C1bS0ityBAAJ
- Thus, these tests presently do not test anything that is shipping in Chromium.

Background: The Sanitizer API is presently being re-written and re-spec-ed. We are comitted to implement the final result of this work. FF has gone ahead and written tests for the proposed-but-not-final API shape. That WPT tests and our implementation are (temporarily) out of sync is a necessary result of this.

I'm unsure what the proper procedure is: Close this as 'wontfix', or leave it open until we're implementing the new API shape. Leaving this open for now.
Reply all
Reply to author
Forward
0 new messages