Issue 1384773 in chromium: Remove expired histograms Scheduler.CancelableTaskTracker.TaskDuration, Scheduler.CancelableTaskTracker.TaskDuration2, Scheduler.CancelableTaskTracker.TaskStatus

[histogram-eraser via monorail]

Status: Untriaged
Owner: ----
CC: w...@chromium.org, schedu...@chromium.org
Labels: Hotlist-ExpiredHistograms-CodeHealthRotation
Components: Internals>TaskScheduling
Pri: 3
Type: Task

New issue 1384773 by histogra...@uma-hrd.google.com.iam.gserviceaccount.com: Remove expired histograms Scheduler.CancelableTaskTracker.TaskDuration, Scheduler.CancelableTaskTracker.TaskDuration2, Scheduler.CancelableTaskTracker.TaskStatus
https://bugs.chromium.org/p/chromium/issues/detail?id=1384773

The following histograms are marked as expired in histograms.xml but still exist in the codebase:
- Scheduler.CancelableTaskTracker.TaskDuration (expired as of 2020-05-01)
- Scheduler.CancelableTaskTracker.TaskDuration2 (expired as of 2021-04-04)
- Scheduler.CancelableTaskTracker.TaskStatus (expired as of 2021-04-04)

The following code locations were found:

base/task/cancelable_task_tracker.cc:53:
"Scheduler.CancelableTaskTracker.TaskDuration2_" suffix, \
base/task/cancelable_task_tracker.cc:220:
UMA_HISTOGRAM_ENUMERATION("Scheduler.CancelableTaskTracker.TaskStatus",

As these histograms are expired, no data for them gets collected. To reduce technical debt, the logging code for these histograms should be removed, including any supporting code. This is the recommended course of action for the majority of such histograms.

In rare cases, a histogram's code should be kept around, such as for debugging purposes. Such histograms must be clearly annotated in histograms.xml per the following instructions:
https://chromium.googlesource.com/chromium/src/+/HEAD/tools/metrics/histograms/README.md#Intentionally-expired-histograms

If you're an owner of any of the histograms, please triage this bug and either:
- Mark the bug as Available to confirm that the histograms can be removed.
- Annotate the histograms as intentionally expired (see above) and update the bug.

Available bugs will be added to the Code Health Rotation to have the code cleaned up by participants in the rotation.

If the bug is left in the Untriaged state without any activity by histogram owners, it will be marked as Available after approximately two weeks.

--
You received this message because:
1. You were specifically CC'd on the issue

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

Reply to this email to add a comment or make updates.

[danieltwhite via monorail]

Updates:
Owner: daniel...@chromium.org
Status: Started

Comment #2 on issue 1384773 by daniel...@google.com: Remove expired histograms Scheduler.CancelableTaskTracker.TaskDuration, Scheduler.CancelableTaskTracker.TaskDuration2, Scheduler.CancelableTaskTracker.TaskStatus
https://bugs.chromium.org/p/chromium/issues/detail?id=1384773#c2

(No comment was entered for this change.)

[danieltwhite via monorail]

Comment #3 on issue 1384773 by daniel...@google.com: Remove expired histograms Scheduler.CancelableTaskTracker.TaskDuration, Scheduler.CancelableTaskTracker.TaskDuration2, Scheduler.CancelableTaskTracker.TaskStatus
https://bugs.chromium.org/p/chromium/issues/detail?id=1384773#c3

Scheduler.CancelableTaskTracker.TaskDuration seems to already have been removed. However, Scheduler.CancelableTaskTracker.TaskDuration2 and Scheduler.CancelableTaskTracker.TaskStatus still need to be removed.

[Git Watcher via monorail]

Comment #4 on issue 1384773 by Git Watcher: Remove expired histograms Scheduler.CancelableTaskTracker.TaskDuration, Scheduler.CancelableTaskTracker.TaskDuration2, Scheduler.CancelableTaskTracker.TaskStatus
https://bugs.chromium.org/p/chromium/issues/detail?id=1384773#c4

The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/403028f22d2c2adac66d9b7484e20544aa4a890d

commit 403028f22d2c2adac66d9b7484e20544aa4a890d
Author: Daniel White <daniel...@google.com>
Date: Mon Apr 17 19:39:57 2023

Removed Expired Scheduler Histograms

In this CL, the expired histograms
Scheduler.CancelableTaskTracker.TaskDuration2 and
Scheduler.CancelableTaskTracker.TaskDuration2 were removed.

The declarations for the histograms that are removed in this CL were originally removed by crrev.com/c/4405743

Bug: 1384773
Change-Id: I9e3c7ec52344eab9c2c37b23f3ad504aa395b4d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4434949
Reviewed-by: Alexander Timin <alt...@chromium.org>
Commit-Queue: Daniel White <daniel...@google.com>
Cr-Commit-Position: refs/heads/main@{#1131434}

[modify] https://crrev.com/403028f22d2c2adac66d9b7484e20544aa4a890d/tools/metrics/histograms/metadata/scheduler/histograms.xml
[modify] https://crrev.com/403028f22d2c2adac66d9b7484e20544aa4a890d/tools/metrics/histograms/metadata/histogram_suffixes_list.xml

[danieltwhite via monorail]

Updates:
Status: Fixed

Comment #5 on issue 1384773 by daniel...@google.com: Remove expired histograms Scheduler.CancelableTaskTracker.TaskDuration, Scheduler.CancelableTaskTracker.TaskDuration2, Scheduler.CancelableTaskTracker.TaskStatus
https://bugs.chromium.org/p/chromium/issues/detail?id=1384773#c5

(No comment was entered for this change.)