[cc] Do not throttle the browser compositor [chromium/src : main]

0 views
Skip to first unread message

Benoit Lize (Gerrit)

unread,
May 7, 2026, 9:34:51 PM (4 days ago) May 7
to Jonathan Ross, Chromium LUCI CQ, chromium...@chromium.org, cc-...@chromium.org, schedule...@chromium.org
Attention needed from Jonathan Ross

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Jonathan Ross
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib378c5ead5575d70231bd2eb22a3e47f213d9f09
Gerrit-Change-Number: 7828149
Gerrit-PatchSet: 2
Gerrit-Owner: Benoit Lize <li...@chromium.org>
Gerrit-Reviewer: Benoit Lize <li...@chromium.org>
Gerrit-Reviewer: Jonathan Ross <jon...@chromium.org>
Gerrit-Attention: Jonathan Ross <jon...@chromium.org>
Gerrit-Comment-Date: Fri, 08 May 2026 01:34:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Jonathan Ross (Gerrit)

unread,
May 8, 2026, 1:16:40 AM (3 days ago) May 8
to Benoit Lize, Chromium LUCI CQ, chromium...@chromium.org, cc-...@chromium.org, schedule...@chromium.org
Attention needed from Benoit Lize

Jonathan Ross voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Benoit Lize
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib378c5ead5575d70231bd2eb22a3e47f213d9f09
Gerrit-Change-Number: 7828149
Gerrit-PatchSet: 2
Gerrit-Owner: Benoit Lize <li...@chromium.org>
Gerrit-Reviewer: Benoit Lize <li...@chromium.org>
Gerrit-Reviewer: Jonathan Ross <jon...@chromium.org>
Gerrit-Attention: Benoit Lize <li...@chromium.org>
Gerrit-Comment-Date: Fri, 08 May 2026 05:16:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Benoit Lize (Gerrit)

unread,
May 8, 2026, 12:15:47 PM (3 days ago) May 8
to Jonathan Ross, Chromium LUCI CQ, chromium...@chromium.org, cc-...@chromium.org, schedule...@chromium.org

Benoit Lize voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib378c5ead5575d70231bd2eb22a3e47f213d9f09
Gerrit-Change-Number: 7828149
Gerrit-PatchSet: 2
Gerrit-Owner: Benoit Lize <li...@chromium.org>
Gerrit-Reviewer: Benoit Lize <li...@chromium.org>
Gerrit-Reviewer: Jonathan Ross <jon...@chromium.org>
Gerrit-Comment-Date: Fri, 08 May 2026 16:15:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
May 8, 2026, 12:19:04 PM (3 days ago) May 8
to Benoit Lize, Jonathan Ross, chromium...@chromium.org, cc-...@chromium.org, schedule...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[cc] Do not throttle the browser compositor

Framerate throttling is intended for content, not chrome (the UI
terminology, not the layer and product). Prior to this CL, it was also
applying to the browser UI.

This CL uses the existing ways to identify the browser compositor in
//cc/scheduler to opt-out the browser compositor. This allows views
animation to run at the nominal framerate.
Bug: 379678455
Change-Id: Ib378c5ead5575d70231bd2eb22a3e47f213d9f09
Reviewed-by: Jonathan Ross <jon...@chromium.org>
Commit-Queue: Benoit Lize <li...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1627701}
Files:
  • M cc/scheduler/scheduler_state_machine.cc
Change size: XS
Delta: 1 file changed, 8 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Jonathan Ross
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib378c5ead5575d70231bd2eb22a3e47f213d9f09
Gerrit-Change-Number: 7828149
Gerrit-PatchSet: 3
Gerrit-Owner: Benoit Lize <li...@chromium.org>
Gerrit-Reviewer: Benoit Lize <li...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Jonathan Ross <jon...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages