Ensure that NotifyMemoryPressure is called on the main thread [chromium/src : main]
0 views
Skip to first unread message
Patrick Monette (Gerrit)
Nov 5, 2025, 1:17:31 PM11/5/25
to Francois Pierre Doray, Tsuyoshi Horo, Guobin Wu, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, chikamu...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, scheduler-...@chromium.org
Attention needed from Francois Pierre Doray
Patrick Monette added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Francois Pierre Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Francois Pierre Doray (Gerrit)
Nov 10, 2025, 9:38:56 AM11/10/25
to Patrick Monette, Tsuyoshi Horo, Guobin Wu, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, chikamu...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, scheduler-...@chromium.org
Attention needed from Patrick Monette
Francois Pierre Doray added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/platform/scheduler/main_thread/memory_purge_manager.cc
Line 192, Patchset 7 (Latest):
auto& main_thread_default =Francois Pierre Doray . unresolved
Is it possible that [this](https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/controller/user_level_memory_pressure_signal_generator.cc;l=155-156;drc=af2de7c0679ba70ae08b6e5898f919655fad1a31) also runs from the "renderer main thread", which is not the process' main thread in single-process mode? In that case, what do you think of moving this code to a helper method in MemoryPressureListenerRegistry? (e.g. MemoryPressureListenerRegistry::NotifyMemoryPressureFromAnyThread).
Related details
Attention is currently required from:
- Patrick Monette
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Patrick Monette (Gerrit)
Nov 10, 2025, 1:22:32 PM11/10/25
to Francois Pierre Doray, Tsuyoshi Horo, Guobin Wu, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, chikamu...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, scheduler-...@chromium.org
Attention needed from Francois Pierre Doray
Patrick Monette added 2 comments![]( "Open in Gerrit")
Patchset-level comments
File third_party/blink/renderer/platform/scheduler/main_thread/memory_purge_manager.cc
Is it possible that [this](https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/controller/user_level_memory_pressure_signal_generator.cc;l=155-156;drc=af2de7c0679ba70ae08b6e5898f919655fad1a31) also runs from the "renderer main thread", which is not the process' main thread in single-process mode? In that case, what do you think of moving this code to a helper method in MemoryPressureListenerRegistry? (e.g. MemoryPressureListenerRegistry::NotifyMemoryPressureFromAnyThread).
Attention is currently required from:
- Francois Pierre Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Francois Pierre Doray (Gerrit)
Nov 10, 2025, 1:56:02 PM11/10/25
to Patrick Monette, Tsuyoshi Horo, Guobin Wu, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, chikamu...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, scheduler-...@chromium.org
Attention needed from Patrick Monette
Francois Pierre Doray voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Patrick Monette
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Patrick Monette (Gerrit)
Nov 10, 2025, 1:58:50 PM11/10/25
to Ian Kilpatrick, Francois Pierre Doray, Tsuyoshi Horo, Guobin Wu, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, chikamu...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, scheduler-...@chromium.org
Attention needed from Ian Kilpatrick
Patrick Monette voted and added 1 comment![]( "Open in Gerrit")
Votes added by Patrick Monette
| Auto-Submit | +1 |
1 comment
Patchset-level comments
Patrick Monette . resolved
+Ian for third_party/blink/renderer/controller/
PTAL
Related details
Attention is currently required from:
- Ian Kilpatrick
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ian Kilpatrick (Gerrit)
Nov 10, 2025, 10:18:46 PM11/10/25
to Patrick Monette, Francois Pierre Doray, Tsuyoshi Horo, Guobin Wu, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, chikamu...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, scheduler-...@chromium.org
Attention needed from Patrick Monette
Ian Kilpatrick voted![]( "Open in Gerrit")
Attention is currently required from:
- Patrick Monette
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Nov 10, 2025, 10:22:25 PM11/10/25
to Patrick Monette, Ian Kilpatrick, Francois Pierre Doray, Tsuyoshi Horo, Guobin Wu, chromium...@chromium.org, blink-...@chromium.org, chikamu...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, scheduler-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Ensure that NotifyMemoryPressure is called on the main thread
Bug: 457269074
Change-Id: Ica1018a9da746a626fdc466b9343724dd2bfd74a
Commit-Queue: Ian Kilpatrick <ikilp...@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilp...@chromium.org>
Reviewed-by: Francois Pierre Doray <fdo...@chromium.org>
Auto-Submit: Patrick Monette <pmon...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1542932}
Files:
- M base/memory/memory_pressure_listener_registry.cc
- M base/memory/memory_pressure_listener_registry.h
- M third_party/blink/renderer/controller/user_level_memory_pressure_signal_generator.cc
- M third_party/blink/renderer/platform/scheduler/main_thread/memory_purge_manager.cc
- M third_party/blink/renderer/platform/scheduler/main_thread/page_scheduler_impl_unittest.cc
Change size: S
Delta: 5 files changed, 38 insertions(+), 10 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Ian Kilpatrick, +1 by Francois Pierre Doray
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Junichi Uekawa (Gerrit)
Jan 28, 2026, 6:45:42 PMJan 28
to Chromium LUCI CQ, Patrick Monette, Ian Kilpatrick, Francois Pierre Doray, Tsuyoshi Horo, Guobin Wu, chromium...@chromium.org, blink-...@chromium.org, chikamu...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, scheduler-...@chromium.org
Attention needed from Patrick Monette
Junichi Uekawa added 1 comment![]( "Open in Gerrit")
File base/memory/memory_pressure_listener_registry.h
Line 28, Patchset 9 (Latest):
static void NotifyMemoryPressure(MemoryPressureLevel memory_pressure_level);Junichi Uekawa . unresolved
I wish there was a compile time check. Could this have been annotated with sequence checker so that we could know at compile time?
b/478376900
Related details
Attention is currently required from:
- Patrick Monette
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Patrick Monette (Gerrit)
Mar 30, 2026, 4:16:57 PM (3 days ago) Mar 30
to Chromium LUCI CQ, Junichi Uekawa, Ian Kilpatrick, Francois Pierre Doray, Tsuyoshi Horo, Guobin Wu, chromium...@chromium.org, blink-...@chromium.org, chikamu...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, scheduler-...@chromium.org
Patrick Monette added 1 comment![]( "Open in Gerrit")
File base/memory/memory_pressure_listener_registry.h
Line 28, Patchset 9 (Latest):
static void NotifyMemoryPressure(MemoryPressureLevel memory_pressure_level);Junichi Uekawa . resolved
I wish there was a compile time check. Could this have been annotated with sequence checker so that we could know at compile time?
b/478376900
Patrick Monette
A sequence checker check (DCHECK_CALLED_ON_VALID_SEQUENCE()) is inherently at run-time. There's a check inside that it's called on the right thread so any issues going forward should be found quickly
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages