Groups

Remove the align-wakeups flag, along with its adjacent features. The flag was not launched and has become deprecated. [chromium/src : main]

0 views

Skip to first unread message

Franco Pieri (Gerrit)

unread,

Feb 4, 2026, 6:05:30 PMFeb 4

to Erik Chen, Etienne Pierre-Doray, Arthur Sonzogni, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Sadrul Chowdhury, scheduler-...@chromium.org, kinuko...@chromium.org, blink-re...@chromium.org, chikamu...@chromium.org, feature-me...@chromium.org, video-networking...@google.com, tommyw+w...@chromium.org, android-web...@chromium.org, asvitki...@chromium.org, blink-...@chromium.org, fdoray...@chromium.org, gab+...@chromium.org, jessemcke...@google.com, jmedle...@chromium.org, mac-r...@chromium.org, performance-m...@chromium.org, roblia...@chromium.org, scheduler...@chromium.org, web-schedulin...@chromium.org

Attention needed from Arthur Sonzogni and Etienne Pierre-Doray

Franco Pieri added 1 comment

Commit Message

Line 9, Patchset 13:Change-Id: I8d8f796a03875ea4c6f2fc67541984a5dd240c84

Arthur Sonzogni . resolved

Is there any bug ID associated with this?
What is the purpose of this patch? To cleanup dead features? Could you please add a description of the purpose?

Franco Pieri

Sorry! I added more detail, along with the CL's corresponding bug.

Related details

Attention is currently required from:

Arthur Sonzogni
Etienne Pierre-Doray

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Diffy

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Etienne Pierre-Doray (Gerrit)

unread,

Feb 6, 2026, 10:20:09 AMFeb 6

to Franco Pieri, Erik Chen, Arthur Sonzogni, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Sadrul Chowdhury, scheduler-...@chromium.org, kinuko...@chromium.org, blink-re...@chromium.org, chikamu...@chromium.org, feature-me...@chromium.org, video-networking...@google.com, tommyw+w...@chromium.org, android-web...@chromium.org, asvitki...@chromium.org, blink-...@chromium.org, fdoray...@chromium.org, gab+...@chromium.org, jessemcke...@google.com, jmedle...@chromium.org, mac-r...@chromium.org, performance-m...@chromium.org, roblia...@chromium.org, scheduler...@chromium.org, web-schedulin...@chromium.org

Attention needed from Franco Pieri

Etienne Pierre-Doray added 5 comments

File base/message_loop/message_pump.cc

Line 227, Patchset 14 (Latest):

  // On Windows, we can rely on the low-res clock if we want the wakeup within
  // kMinLowResolutionThresholdMs (16ms).
  const TimeDelta leeway = GetLeewayForCurrentThread();
  if (leeway > Milliseconds(Time::kMinLowResolutionThresholdMs)) {
    TimeTicks aligned_run_time =
        earliest_time.SnappedToNextTick(TimeTicks(), leeway);
    return std::min(aligned_run_time, latest_time);
  }

Etienne Pierre-Doray . unresolved

Remove this since GetAlignWakeUpsEnabled() was always false.

Line 246, Patchset 14 (Parent):

  // For some threads, there might be an override of the leeway, so check it
  // first.

Etienne Pierre-Doray . unresolved

Let's keep this comment

File base/message_loop/message_pump_apple.mm

Line 190, Patchset 14 (Latest):

  if (g_timer_slack.load(std::memory_order_relaxed) &&
      !next_work_info.delayed_run_time.is_max() &&
      delayed_work_leeway_ != next_work_info.leeway) {
    if (!next_work_info.leeway.is_zero()) {
      // Specify slack based on |next_work_info|.
      CFRunLoopTimerSetTolerance(delayed_work_timer_.get(),
                                 next_work_info.leeway.InSecondsF());
    } else {
      CFRunLoopTimerSetTolerance(delayed_work_timer_.get(), 0);
    }
    delayed_work_leeway_ = next_work_info.leeway;
  }

Etienne Pierre-Doray . unresolved

Remove this since GetAlignWakeUpsEnabled() was always false

File base/message_loop/message_pump_kqueue.cc

Line 263, Patchset 14 (Latest):

  if (g_timer_slack.load(std::memory_order_relaxed)) {
    return earliest_time;
  }

Etienne Pierre-Doray . unresolved

Remove this since GetAlignWakeUpsEnabled() was always false.
This then makes MessagePumpKqueue::AdjustDelayedRunTime override unnecessary which can also be removed.

File third_party/blink/renderer/core/scheduler/dom_timer.cc

Line 65, Patchset 14 (Latest):

  return base::FeatureList::IsEnabled(
             features::kLowerHighResolutionTimerThreshold)
             ? base::Milliseconds(4)
             : base::Milliseconds(32);

Etienne Pierre-Doray . unresolved

Since GetAlignWakeUpsEnabled() was always false, this should just return base::Milliseconds(32);

Related details

Attention is currently required from:

Franco Pieri

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Diffy

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Franco Pieri (Gerrit)

unread,

Feb 12, 2026, 12:26:27 PM (10 days ago) Feb 12

to Erik Chen, Etienne Pierre-Doray, Arthur Sonzogni, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Sadrul Chowdhury, scheduler-...@chromium.org, kinuko...@chromium.org, blink-re...@chromium.org, chikamu...@chromium.org, feature-me...@chromium.org, video-networking...@google.com, tommyw+w...@chromium.org, android-web...@chromium.org, asvitki...@chromium.org, blink-...@chromium.org, fdoray...@chromium.org, gab+...@chromium.org, jessemcke...@google.com, jmedle...@chromium.org, mac-r...@chromium.org, performance-m...@chromium.org, roblia...@chromium.org, scheduler...@chromium.org, web-schedulin...@chromium.org

Attention needed from Etienne Pierre-Doray

Franco Pieri voted and added 5 comments

Votes added by Franco Pieri

Commit-Queue

+1

5 comments

File base/message_loop/message_pump.cc

Line 227, Patchset 14: // On Windows, we can rely on the low-res clock if we want the wakeup within


  // kMinLowResolutionThresholdMs (16ms).
  const TimeDelta leeway = GetLeewayForCurrentThread();
  if (leeway > Milliseconds(Time::kMinLowResolutionThresholdMs)) {
    TimeTicks aligned_run_time =
        earliest_time.SnappedToNextTick(TimeTicks(), leeway);
    return std::min(aligned_run_time, latest_time);
  }

Etienne Pierre-Doray . resolved

Remove this since GetAlignWakeUpsEnabled() was always false.

Franco Pieri

Done

Line 246, Patchset 14 (Parent):

  // For some threads, there might be an override of the leeway, so check it
  // first.

Etienne Pierre-Doray . resolved

Let's keep this comment

Franco Pieri

Done

File base/message_loop/message_pump_apple.mm

Line 190, Patchset 14: if (g_timer_slack.load(std::memory_order_relaxed) &&


      !next_work_info.delayed_run_time.is_max() &&
      delayed_work_leeway_ != next_work_info.leeway) {
    if (!next_work_info.leeway.is_zero()) {
      // Specify slack based on |next_work_info|.
      CFRunLoopTimerSetTolerance(delayed_work_timer_.get(),
                                 next_work_info.leeway.InSecondsF());
    } else {
      CFRunLoopTimerSetTolerance(delayed_work_timer_.get(), 0);
    }
    delayed_work_leeway_ = next_work_info.leeway;
  }

Etienne Pierre-Doray . resolved

Remove this since GetAlignWakeUpsEnabled() was always false

Franco Pieri

Done

File base/message_loop/message_pump_kqueue.cc

Line 263, Patchset 14:

  if (g_timer_slack.load(std::memory_order_relaxed)) {
    return earliest_time;
  }

Etienne Pierre-Doray . resolved

Remove this since GetAlignWakeUpsEnabled() was always false.
This then makes MessagePumpKqueue::AdjustDelayedRunTime override unnecessary which can also be removed.

Franco Pieri

Done

File third_party/blink/renderer/core/scheduler/dom_timer.cc

Line 65, Patchset 14: return base::FeatureList::IsEnabled(


             features::kLowerHighResolutionTimerThreshold)
             ? base::Milliseconds(4)
             : base::Milliseconds(32);

Etienne Pierre-Doray . resolved

Since GetAlignWakeUpsEnabled() was always false, this should just return base::Milliseconds(32);

Franco Pieri

Done

Related details

Attention is currently required from:

Etienne Pierre-Doray

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Diffy

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages

Search

Clear search

Close search

Google apps

Main menu