Rename ios_cronet_buildflags to cronet_buildflags and use it in jni_android.cc. [chromium/src : main]

0 views
Skip to first unread message

Etienne Dechamps (Gerrit)

unread,
Mar 25, 2026, 12:04:39 PM (8 days ago) Mar 25
to Mohannad Farrag, Sadrul Chowdhury, AyeAye, Chromium LUCI CQ, Etienne Dechamps, Andrew Grieve, scheduler...@chromium.org, lizeb...@chromium.org, pasko...@chromium.org, torne...@chromium.org, agriev...@chromium.org, yfriedm...@chromium.org, nyquis...@chromium.org
Attention needed from Andrew Grieve and Mohannad Farrag

Etienne Dechamps added 2 comments

Commit Message
Line 15, Patchset 4 (Latest):Bug: 496131361
Change-Id: I8a7ef0c47c0d2604b185352b08984e60cc8b0281
Etienne Dechamps . unresolved

Please add Cronet trybots here.

File base/BUILD.gn
Line 164, Patchset 4 (Latest):buildflag_header("cronet_buildflags") {
header = "cronet_buildflags.h"
header_dir = "base"
flags = [ "CRONET_BUILD=$is_cronet_build" ]
}
Etienne Dechamps . unresolved

Consider doing this move in a separate CL and in that CL also converge with `//net:cronet_buildflags`: https://source.chromium.org/chromium/chromium/src/+/main:net/BUILD.gn;l=141-145;drc=3ea53a2e6850a26f60a126437446a6e6235e2fe3

Open in Gerrit

Related details

Attention is currently required from:
  • Andrew Grieve
  • Mohannad Farrag
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8a7ef0c47c0d2604b185352b08984e60cc8b0281
Gerrit-Change-Number: 7700853
Gerrit-PatchSet: 4
Gerrit-Owner: Mohannad Farrag <aym...@google.com>
Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
Gerrit-Reviewer: Etienne Dechamps <edec...@google.com>
Gerrit-Reviewer: Mohannad Farrag <aym...@google.com>
Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
Gerrit-Attention: Andrew Grieve <agr...@chromium.org>
Gerrit-Attention: Mohannad Farrag <aym...@google.com>
Gerrit-Comment-Date: Wed, 25 Mar 2026 16:04:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Andrew Grieve (Gerrit)

unread,
Mar 25, 2026, 12:07:21 PM (8 days ago) Mar 25
to Mohannad Farrag, Andrew Grieve, Sadrul Chowdhury, AyeAye, Chromium LUCI CQ, Etienne Dechamps, scheduler...@chromium.org, lizeb...@chromium.org, pasko...@chromium.org, torne...@chromium.org, agriev...@chromium.org, yfriedm...@chromium.org, nyquis...@chromium.org
Attention needed from Mohannad Farrag

Andrew Grieve voted and added 1 comment

Votes added by Andrew Grieve

Code-Review+1
Owners-Override+1

1 comment

File base/BUILD.gn
Line 164, Patchset 4 (Latest):buildflag_header("cronet_buildflags") {
header = "cronet_buildflags.h"
header_dir = "base"
flags = [ "CRONET_BUILD=$is_cronet_build" ]
}
Etienne Dechamps . unresolved

Consider doing this move in a separate CL and in that CL also converge with `//net:cronet_buildflags`: https://source.chromium.org/chromium/chromium/src/+/main:net/BUILD.gn;l=141-145;drc=3ea53a2e6850a26f60a126437446a6e6235e2fe3

Andrew Grieve

Or do that in a follow-up?

Open in Gerrit

Related details

Attention is currently required from:
  • Mohannad Farrag
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8a7ef0c47c0d2604b185352b08984e60cc8b0281
Gerrit-Change-Number: 7700853
Gerrit-PatchSet: 4
Gerrit-Owner: Mohannad Farrag <aym...@google.com>
Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
Gerrit-Reviewer: Etienne Dechamps <edec...@google.com>
Gerrit-Reviewer: Mohannad Farrag <aym...@google.com>
Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
Gerrit-Attention: Mohannad Farrag <aym...@google.com>
Gerrit-Comment-Date: Wed, 25 Mar 2026 16:07:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Etienne Dechamps <edec...@google.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Mohannad Farrag (Gerrit)

unread,
Mar 25, 2026, 12:10:06 PM (8 days ago) Mar 25
to Andrew Grieve, Sadrul Chowdhury, AyeAye, Chromium LUCI CQ, Etienne Dechamps, scheduler...@chromium.org, lizeb...@chromium.org, pasko...@chromium.org, torne...@chromium.org, agriev...@chromium.org, yfriedm...@chromium.org, nyquis...@chromium.org
Attention needed from Andrew Grieve and Etienne Dechamps

Mohannad Farrag added 1 comment

File base/BUILD.gn
Line 164, Patchset 4:buildflag_header("cronet_buildflags") {

header = "cronet_buildflags.h"
header_dir = "base"
flags = [ "CRONET_BUILD=$is_cronet_build" ]
}
Etienne Dechamps . resolved

Consider doing this move in a separate CL and in that CL also converge with `//net:cronet_buildflags`: https://source.chromium.org/chromium/chromium/src/+/main:net/BUILD.gn;l=141-145;drc=3ea53a2e6850a26f60a126437446a6e6235e2fe3

Mohannad Farrag

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Andrew Grieve
  • Etienne Dechamps
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I8a7ef0c47c0d2604b185352b08984e60cc8b0281
    Gerrit-Change-Number: 7700853
    Gerrit-PatchSet: 5
    Gerrit-Owner: Mohannad Farrag <aym...@google.com>
    Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
    Gerrit-Reviewer: Etienne Dechamps <edec...@google.com>
    Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
    Gerrit-Attention: Andrew Grieve <agr...@chromium.org>
    Gerrit-Attention: Etienne Dechamps <edec...@google.com>
    Gerrit-Comment-Date: Wed, 25 Mar 2026 16:09:51 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Etienne Dechamps <edec...@google.com>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Mohannad Farrag (Gerrit)

    unread,
    Mar 25, 2026, 12:11:35 PM (8 days ago) Mar 25
    to Andrew Grieve, Sadrul Chowdhury, AyeAye, Chromium LUCI CQ, Etienne Dechamps, scheduler...@chromium.org, lizeb...@chromium.org, pasko...@chromium.org, torne...@chromium.org, agriev...@chromium.org, yfriedm...@chromium.org, nyquis...@chromium.org
    Attention needed from Andrew Grieve and Etienne Dechamps

    Mohannad Farrag voted and added 1 comment

    Votes added by Mohannad Farrag

    Auto-Submit+1
    Commit-Queue+1

    1 comment

    Commit Message
    Line 15, Patchset 4:Bug: 496131361
    Change-Id: I8a7ef0c47c0d2604b185352b08984e60cc8b0281
    Etienne Dechamps . resolved

    Please add Cronet trybots here.

    Mohannad Farrag

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Andrew Grieve
    • Etienne Dechamps
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I8a7ef0c47c0d2604b185352b08984e60cc8b0281
      Gerrit-Change-Number: 7700853
      Gerrit-PatchSet: 6
      Gerrit-Owner: Mohannad Farrag <aym...@google.com>
      Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
      Gerrit-Reviewer: Etienne Dechamps <edec...@google.com>
      Gerrit-Reviewer: Mohannad Farrag <aym...@google.com>
      Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
      Gerrit-Attention: Andrew Grieve <agr...@chromium.org>
      Gerrit-Attention: Etienne Dechamps <edec...@google.com>
      Gerrit-Comment-Date: Wed, 25 Mar 2026 16:11:23 +0000
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Mohannad Farrag (Gerrit)

      unread,
      Mar 25, 2026, 12:12:22 PM (8 days ago) Mar 25
      to Andrew Grieve, Sadrul Chowdhury, AyeAye, Chromium LUCI CQ, Etienne Dechamps, scheduler...@chromium.org, lizeb...@chromium.org, pasko...@chromium.org, torne...@chromium.org, agriev...@chromium.org, yfriedm...@chromium.org, nyquis...@chromium.org
      Attention needed from Andrew Grieve and Etienne Dechamps

      Mohannad Farrag added 1 comment

      File base/BUILD.gn
      Line 164, Patchset 4:buildflag_header("cronet_buildflags") {
      header = "cronet_buildflags.h"
      header_dir = "base"
      flags = [ "CRONET_BUILD=$is_cronet_build" ]
      }
      Etienne Dechamps . resolved

      Consider doing this move in a separate CL and in that CL also converge with `//net:cronet_buildflags`: https://source.chromium.org/chromium/chromium/src/+/main:net/BUILD.gn;l=141-145;drc=3ea53a2e6850a26f60a126437446a6e6235e2fe3

      Mohannad Farrag

      Done

      Mohannad Farrag

      I'll do that in a follow-up then.

      Gerrit-Comment-Date: Wed, 25 Mar 2026 16:12:10 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Mohannad Farrag <aym...@google.com>
      Comment-In-Reply-To: Etienne Dechamps <edec...@google.com>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Etienne Dechamps (Gerrit)

      unread,
      Mar 27, 2026, 6:00:58 AM (6 days ago) Mar 27
      to Mohannad Farrag, Etienne Dechamps, Andrew Grieve, Sadrul Chowdhury, AyeAye, Chromium LUCI CQ, scheduler...@chromium.org, lizeb...@chromium.org, pasko...@chromium.org, torne...@chromium.org, agriev...@chromium.org, yfriedm...@chromium.org, nyquis...@chromium.org
      Attention needed from Andrew Grieve and Mohannad Farrag

      Etienne Dechamps voted and added 1 comment

      Votes added by Etienne Dechamps

      Code-Review+1

      1 comment

      File base/BUILD.gn
      Line 164, Patchset 4:buildflag_header("cronet_buildflags") {
      header = "cronet_buildflags.h"
      header_dir = "base"
      flags = [ "CRONET_BUILD=$is_cronet_build" ]
      }
      Etienne Dechamps . resolved

      Consider doing this move in a separate CL and in that CL also converge with `//net:cronet_buildflags`: https://source.chromium.org/chromium/chromium/src/+/main:net/BUILD.gn;l=141-145;drc=3ea53a2e6850a26f60a126437446a6e6235e2fe3

      Mohannad Farrag

      Done

      Mohannad Farrag

      I'll do that in a follow-up then.

      Etienne Dechamps

      I don't think it's ideal to order CLs that way because now this CL is making things worse (you are referring to `base/message_loop` from `base/android/jni_android.cc` which is ugly). I'm not going to die on this hill though.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Andrew Grieve
      • Mohannad Farrag
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I8a7ef0c47c0d2604b185352b08984e60cc8b0281
        Gerrit-Change-Number: 7700853
        Gerrit-PatchSet: 6
        Gerrit-Owner: Mohannad Farrag <aym...@google.com>
        Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
        Gerrit-Reviewer: Etienne Dechamps <edec...@google.com>
        Gerrit-Reviewer: Mohannad Farrag <aym...@google.com>
        Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
        Gerrit-Attention: Andrew Grieve <agr...@chromium.org>
        Gerrit-Attention: Mohannad Farrag <aym...@google.com>
        Gerrit-Comment-Date: Fri, 27 Mar 2026 10:00:32 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy
        Reply all
        Reply to author
        Forward
        0 new messages