Avoid querying affinity/ADPF mode on ineligible hardware [chromium/src : main]
0 views
Skip to first unread message
Richard Townsend (Gerrit)
Feb 4, 2026, 5:01:24 PMFeb 4
to AyeAye, Chromium LUCI CQ, kinuko...@chromium.org, chikamu...@chromium.org, blink-...@chromium.org, scheduler-...@chromium.org
Richard Townsend voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Richard Townsend (Gerrit)
Feb 4, 2026, 6:42:21 PMFeb 4
to Francois Pierre Doray, AyeAye, Chromium LUCI CQ, kinuko...@chromium.org, chikamu...@chromium.org, blink-...@chromium.org, scheduler-...@chromium.org
Attention needed from Francois Pierre Doray
Richard Townsend added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 4 (Latest):
Richard Townsend . resolved
Hi François,
PTAL at this quick fixup to the PerformanceHelper that prepares it slightly better for the final form of the Finch trial (I can ping you a link internally).
Best
Richard
Related details
Attention is currently required from:
- Francois Pierre Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Francois Pierre Doray (Gerrit)
Feb 6, 2026, 9:11:30 AMFeb 6
to Richard Townsend, AyeAye, Chromium LUCI CQ, kinuko...@chromium.org, chikamu...@chromium.org, blink-...@chromium.org, scheduler-...@chromium.org
Attention needed from Richard Townsend
Francois Pierre Doray voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Richard Townsend
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Richard Townsend (Gerrit)
Feb 6, 2026, 9:13:22 AMFeb 6
to Francois Pierre Doray, AyeAye, Chromium LUCI CQ, kinuko...@chromium.org, chikamu...@chromium.org, blink-...@chromium.org, scheduler-...@chromium.org
Richard Townsend voted and added 1 comment![]( "Open in Gerrit")
Votes added by Richard Townsend
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Richard Townsend . resolved
Thanks for the review,
Best
Richard
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Feb 6, 2026, 10:18:59 AMFeb 6
to Richard Townsend, Francois Pierre Doray, AyeAye, kinuko...@chromium.org, chikamu...@chromium.org, blink-...@chromium.org, scheduler-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Avoid querying affinity/ADPF mode on ineligible hardware
Because the Finch trial may not be targeted to specific hardware as
originally planned, avoid accessing the base::Feature state until it's
determined that the device can handle affinity/efficient hints. This
should increase statistical power by keeping ineligible hardware out of
the experiment arms.
Bug: 464505581
Change-Id: I223a07226256128490057848e8d260037ba4b013
Reviewed-by: Francois Pierre Doray <fdo...@chromium.org>
Commit-Queue: Richard Townsend <ritow...@google.com>
Cr-Commit-Position: refs/heads/main@{#1580824}
Files:
- M third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc
Change size: S
Delta: 1 file changed, 32 insertions(+), 7 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Francois Pierre Doray
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages