[iOS][Web] Add CallAsyncJavaScriptFunction to WebFrame API [chromium/src : main]

0 views
Skip to first unread message

Alexandra Pereira (Gerrit)

unread,
Apr 30, 2026, 6:14:34 PM (11 days ago) Apr 30
to Mike Dougherty, Kenneth R Christiansen, Menard, Alexis, Hongchan Choi, Christian Biesinger, Rijubrata Bhaumik, Dirk Schulze, Lin, Wanming, srirama chandra sekhar, Jerome Jiang, Javier Fernandez, Sinan Sahin, Peter Williamson, Avi Drissman, Nate Chapin, Khushal Sagar, Nikhil Nayunigari, Linyu He, Shu Yang, Kevin Babbitt, Hiroki Nakagawa, Heron Yang, Kevin McNee, Charles Hager, Mark Schillaci, Andrew Rayskiy, (Julie)Jeongeun Kim, Sadrul Chowdhury, Moe Adel, Henrique Ferreiro, Kenneth Rohde Christiansen, Arnaud Mandy, Jiewei Qian, Stephen Chenney, Hu, Ningxin, Raphael Kubo da Costa, Chromium Metrics Reviews, Mirko Bonadei, Luna Lu, Hirokazu Honda, Thorsten Kober, Fredrik Söderquist, Hans Wennborg, Tommy Li, Josh Karlin, Anurag Simgeker, Michael Moss, Kentaro Hara, Zijie He, Yao Xiao, Zewen Li, Daniel Cheng, James Maclean, Peter Beverloo, Simon Hangl, Wang, Wei4, Mangesh Ghiware, Enterprise Policy Reviews, James Su, Lei Zhang, Olga Gerchikov, Neil Coronado, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, AyeAye Python Dispatcher, chromium...@chromium.org, ortuno...@chromium.org, blink-re...@chromium.org, khorimoto+w...@chromium.org, zelin+watch-we...@chromium.org, browser-comp...@chromium.org, phoglun...@chromium.org, blink-re...@chromium.org, siashah+au...@chromium.org, tranbaod...@chromium.org, horo+...@chromium.org, filesapp...@chromium.org, tracing...@chromium.org, cfredri...@chromium.org, mbarowsky+watc...@chromium.org, crost...@chromium.org, chromium-a...@chromium.org, blink-revie...@chromium.org, chrome-intelligence-te...@google.com, lingqi...@chromium.org, jdonnel...@chromium.org, lucasrada...@google.com, stanfie...@google.com, hansberry+wat...@chromium.org, suetfei+wa...@google.com, kainin...@chromium.org, yyhyyh+watch-inpu...@google.com, estali...@chromium.org, penghuan...@chromium.org, crostin...@chromium.org, fuchsia...@chromium.org, nona+...@chromium.org, chromiumme...@microsoft.com, cros-report...@google.com, philli...@chromium.org, rainhar...@chromium.org, chadduffin+w...@chromium.org, mfoltz+wa...@chromium.org, cblume+im...@chromium.org, ddrone...@google.com, kinuko+...@chromium.org, odejesu...@chromium.org, mcasas+med...@chromium.org, cros-enterpris...@chromium.org, gangwu...@chromium.org, aixba+wat...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, rayanka...@chromium.org, blink-revi...@chromium.org, navigation...@chromium.org, ananyasee...@google.com, crmulli...@chromium.org, iwells...@chromium.org, ajayramamurthy...@google.com, rginda...@chromium.org, webap...@microsoft.com, print-revi...@chromium.org, titoua...@chromium.org, thiabaud+watch-d...@google.com, vinnypersky+...@google.com, prerenderi...@chromium.org, emircan+watch...@chromium.org, lizeb+watch...@chromium.org, menghua...@google.com, bmcquad...@chromium.org, loading-rev...@chromium.org, crisrael+wa...@google.com, tbansal+...@chromium.org, eme-r...@chromium.org, yhanada+...@chromium.org, telemetr...@chromium.org, speed-metrics...@chromium.org, devtools-re...@chromium.org, mattsimm...@chromium.org, dominicc+...@chromium.org, jackshira+wat...@google.com, scheduler-...@chromium.org, geoffla...@chromium.org, arthursonzog...@chromium.org, hsuregan+wa...@chromium.org, borealis-re...@google.com, aleventh...@chromium.org, feature-v...@chromium.org, ydago...@chromium.org, lens-chrome...@google.com, asvitkine...@chromium.org, zol...@webkit.org, blink-re...@chromium.org, media-wi...@chromium.org, kinuko...@chromium.org, fmalit...@chromium.org, donnd...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org, jonmann+wat...@chromium.org, kenjibah...@chromium.org, jorgel...@chromium.org, blink-rev...@chromium.org, gcasto+w...@chromium.org, derinel+wat...@google.com, cros-print...@google.com, dmblac...@google.com, pkotwic...@chromium.org, dmurph+watch...@chromium.org, jackshira+wa...@google.com, marq+...@chromium.org, blink-revie...@chromium.org, dfried...@chromium.org, edgesto...@microsoft.com, wangdanny+watch-in...@google.com, gavin...@chromium.org, network-ser...@chromium.org, chromotin...@chromium.org, martijn...@martijnc.be, ayman...@chromium.org, dtapuska+...@chromium.org, roblia...@chromium.org, pmonett...@chromium.org, chrome-gr...@chromium.org, pdf-r...@chromium.org, hansberry+wa...@chromium.org, blink-re...@chromium.org, asumane...@google.com, yuzo+...@chromium.org, fgal...@chromium.org, hansberry+wa...@chromium.org, hais+wat...@google.com, kinuko...@chromium.org, nickdiego+wa...@igalia.com, npm+...@chromium.org, ajayramamurthy...@google.com, ajwong...@chromium.org, blink-reviews-p...@chromium.org, japhet+...@chromium.org, armalhotra+a...@google.com, spang...@chromium.org, blink-rev...@chromium.org, kinuko+ser...@chromium.org, xiangdongkong+...@google.com, kyungjunle...@google.com, chrome-intell...@chromium.org, antoniosarto...@chromium.org, storage...@chromium.org, cc-...@chromium.org, headless...@chromium.org, mattreyno...@chromium.org, vasilii+watchlis...@chromium.org, jimmyxgong+watch...@chromium.org, shend...@chromium.org, ashleynewson+w...@chromium.org, dclasson+w...@google.com, sky+...@chromium.org, mar...@chromium.org, zackha...@chromium.org, ajayramamurthy+w...@google.com, net-r...@chromium.org, trewin...@google.com, wnwen...@chromium.org, joeantonetti+...@google.com, dibyapal+wa...@chromium.org, michaelchec...@google.com, dcheng+c...@chromium.org, michaelcheco+watch-i...@google.com, arc-review...@google.com, thefro...@chromium.org, tgupta...@chromium.org, enne...@chromium.org, blink-revie...@chromium.org, ender...@chromium.org, hidehik...@chromium.org, chromeos-ca...@google.com, fenced-fra...@chromium.org, grt+...@chromium.org, dtseng+c...@chromium.org, meilian...@chromium.org, tburkar...@chromium.org, vakh+safe_br...@chromium.org, chromeos-gfx-...@google.com, shuche...@chromium.org, ejcaruso+wa...@chromium.org, lwinston+watc...@google.com, pdr+svgw...@chromium.org, loading...@chromium.org, chrstn...@google.com, rrsilva+wat...@google.com, chrome-tab-group-en...@google.com, jkeitel+watch-...@google.com, lize...@chromium.org, loyso...@chromium.org, jackshira+wa...@google.com, niharm...@google.com, shimazu+se...@chromium.org, boujan...@google.com, davidj...@chromium.org, wfh+...@chromium.org, mreichhoff+watc...@chromium.org, xinghui...@chromium.org, mgiuca...@chromium.org, xlythe+wa...@google.com, dfalcant...@chromium.org, mek+w...@chromium.org, gavinp...@chromium.org, chrome-regionalc...@google.com, hirokisa...@chromium.org, jonmann+watc...@chromium.org, shgar+aut...@google.com, crisrael+wa...@google.com, subresource-f...@chromium.org, mtomas...@chromium.org, hayato...@chromium.org, blink-...@chromium.org, mbarowsky+watc...@chromium.org, droger+w...@chromium.org, yigu+...@chromium.org, asvitki...@chromium.org, cbe-cep-eng...@google.com, language...@chromium.org, mfoltz+wa...@chromium.org, yongshun+...@google.com, crisrael+w...@google.com, dmurph+watc...@chromium.org, webauthn...@chromium.org, bartek...@chromium.org, video-networking...@google.com, siyua+aut...@chromium.org, dennyh...@google.com, chfreme...@chromium.org, dmurph+watchin...@chromium.org, csharrison+...@chromium.org, fgorsk...@chromium.org, sloboda...@chromium.org, rkgibso...@chromium.org, aashna...@google.com, blink-rev...@chromium.org, extension...@chromium.org, jophba...@chromium.org, tbarzi...@chromium.org, mercer...@google.com, eic+...@google.com, josiah...@chromium.org, peilinwa...@google.com, dmurph+wa...@chromium.org, dtraino...@chromium.org, anastas...@google.com, joeantonetti+wa...@google.com, devtools...@chromium.org, srahim...@chromium.org, csharris...@chromium.org, dtseng...@chromium.org, jdeblas...@chromium.org, dullweb...@chromium.org, ricea...@chromium.org, yuezhang...@chromium.org, shannc...@chromium.org, rsleev...@chromium.org, ashleydp+fe...@google.com, byronle...@chromium.org, chungshe...@google.com, knollr+wat...@chromium.org, jackshira+w...@google.com, ozone-...@chromium.org, mfoltz+wa...@chromium.org, mac-r...@chromium.org, stevenjb+wa...@chromium.org, julietlevesque...@google.com, feature-me...@chromium.org, mkwst+w...@chromium.org, akingsb+wat...@google.com, ios-web-view...@google.com, ramyagopa...@google.com, chrome-b...@google.com, loading-re...@chromium.org, dmurph+watchi...@chromium.org, torne...@chromium.org, bling-ai-foundatio...@google.com, yusufo...@chromium.org, loading-rev...@chromium.org, yhanada...@chromium.org, blink-rev...@chromium.org, francisjp...@google.com, pushi+watc...@google.com, fserb...@chromium.org, keithle...@chromium.org, oshima...@chromium.org, cwalle...@chromium.org, mdjone...@chromium.org, blink-work...@chromium.org, eric.c...@apple.com, longbowei+fe...@google.com, cros-setti...@google.com, jiajunz+wa...@google.com, abigailbk...@google.com, ntp-dev...@chromium.org, print-rev...@chromium.org, creis...@chromium.org, chili...@chromium.org, jeffreycohen+watc...@chromium.org, dtapuska+ch...@chromium.org, blink-revi...@chromium.org, core-web-vita...@chromium.org, drott...@chromium.org, roagarw...@chromium.org, nyquis...@chromium.org, omnibox-...@chromium.org, tmartino+tran...@chromium.org, shimazu...@chromium.org, johnche...@chromium.org, twelling...@chromium.org, iclella...@chromium.org, agriev...@chromium.org, yfriedm...@chromium.org, jasonrobe...@google.com, translat...@chromium.org, jmedle...@chromium.org, vaapi-...@chromium.org, jonmann+wa...@chromium.org, kuragin+web-ap...@chromium.org, cros-essential...@chromium.org, halliwe...@chromium.org, servicewor...@chromium.org, drott+bl...@chromium.org, cblume...@chromium.org, max+watc...@igalia.com, performance-m...@chromium.org, tommyw+w...@chromium.org, blink-revi...@chromium.org, hanxi...@chromium.org, security-...@chromium.org, permissio...@chromium.org, weiluanw...@google.com, katie...@chromium.org, harringt...@chromium.org, dmurph+wat...@chromium.org, hansberry+w...@chromium.org, ios-revie...@chromium.org, nektar...@chromium.org, pasko...@chromium.org, khmel...@chromium.org, petewi...@chromium.org, jz...@chromium.org, jshin...@chromium.org, toyosh...@chromium.org, msrame...@chromium.org, cros-ed...@google.com, christia...@chromium.org, jatapiaro+wat...@google.com, gavinp...@chromium.org, nator...@chromium.org, jackshira+w...@google.com, rmcelra...@chromium.org, thegreenf...@chromium.org, twifka...@chromium.org, wychen...@chromium.org, croissant-...@chromium.org, lizeb...@chromium.org, jinsukk...@chromium.org, hansenmichael...@google.com, chromeos-kio...@google.com, pushi+wat...@google.com, speed-metr...@chromium.org, jessemcke...@google.com, osaul+aut...@google.com, gavin...@chromium.org, apavlo...@chromium.org, ajayramamurth...@google.com, web-schedulin...@chromium.org, yyhyyh+fee...@google.com, chikamu...@chromium.org, bnc+...@chromium.org, nicolas...@chromium.org, yhiran...@chromium.org, nwoked...@chromium.org, xiaohui...@chromium.org, kouhe...@chromium.org, media-cro...@chromium.org, wangdanny+fe...@google.com, alexmo...@chromium.org, webapks-...@chromium.org, accessibility-a...@google.com, gogeral...@chromium.org, dewitt...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org
Attention needed from Mike Dougherty

Alexandra Pereira added 1 comment

Patchset-level comments
File-level comment, Patchset 12 (Latest):
Alexandra Pereira . resolved

Hi Mike, finally the call function. PTAL and thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Mike Dougherty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0917f68bfe28b832dada5999ad5d1c41185f6057
Gerrit-Change-Number: 7796039
Gerrit-PatchSet: 12
Gerrit-Owner: Alexandra Pereira <alexa...@google.com>
Gerrit-Reviewer: Alexandra Pereira <alexa...@google.com>
Gerrit-Reviewer: Mike Dougherty <mich...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Anurag Simgeker <anurags...@google.com>
Gerrit-CC: Arnaud Mandy <arnaud...@intel.com>
Gerrit-CC: Avi Drissman <a...@chromium.org>
Gerrit-CC: AyeAye Python Dispatcher <android-build-ayeay...@system.gserviceaccount.com>
Gerrit-CC: Charles Hager <clh...@google.com>
Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Daniel Cheng <dch...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Fredrik Söderquist <f...@opera.com>
Gerrit-CC: Hans Wennborg <ha...@chromium.org>
Gerrit-CC: Henrique Ferreiro <hfer...@igalia.com>
Gerrit-CC: Heron Yang <hero...@google.com>
Gerrit-CC: Hirokazu Honda <hi...@chromium.org>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Hongchan Choi <hong...@chromium.org>
Gerrit-CC: Hu, Ningxin <ningx...@intel.com>
Gerrit-CC: James Maclean <wjma...@chromium.org>
Gerrit-CC: James Su <su...@chromium.org>
Gerrit-CC: Javier Fernandez <jfern...@igalia.com>
Gerrit-CC: Jerome Jiang <ji...@chromium.org>
Gerrit-CC: Jiewei Qian <q...@chromium.org>
Gerrit-CC: Josh Karlin <jka...@chromium.org>
Gerrit-CC: Kenneth R Christiansen <kenneth.r.c...@intel.com>
Gerrit-CC: Kenneth Rohde Christiansen <kenneth.ch...@gmail.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Kevin McNee <mc...@chromium.org>
Gerrit-CC: Khushal Sagar <khusha...@chromium.org>
Gerrit-CC: Lei Zhang <the...@chromium.org>
Gerrit-CC: Lin, Wanming <wanmi...@intel.com>
Gerrit-CC: Linyu He <lin...@google.com>
Gerrit-CC: Luna Lu <loon...@chromium.org>
Gerrit-CC: Mangesh Ghiware <mghi...@google.com>
Gerrit-CC: Mark Schillaci <mschi...@google.com>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Michael Moss <mm...@chromium.org>
Gerrit-CC: Michael Wilson <mjwi...@chromium.org>
Gerrit-CC: Mirko Bonadei <mbon...@chromium.org>
Gerrit-CC: Moe Adel <ad...@google.com>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Neil Coronado <ne...@google.com>
Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Peter Williamson <pet...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
Gerrit-CC: Shu Yang <shu...@google.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: Sinan Sahin <sinan...@google.com>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-CC: Thorsten Kober <thor...@google.com>
Gerrit-CC: Tommy Li <tomm...@chromium.org>
Gerrit-CC: Wang, Wei4 <wei4...@intel.com>
Gerrit-CC: Yao Xiao <yao...@chromium.org>
Gerrit-CC: Zewen Li <zew...@google.com>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
Gerrit-Attention: Mike Dougherty <mich...@chromium.org>
Gerrit-Comment-Date: Thu, 30 Apr 2026 22:14:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Takuto Ikuta (Gerrit)

unread,
Apr 30, 2026, 10:22:15 PM (11 days ago) Apr 30
to Alexandra Pereira, chrome-b...@google.com, Mike Dougherty, Kenneth R Christiansen, Menard, Alexis, Hongchan Choi, Christian Biesinger, Rijubrata Bhaumik, Dirk Schulze, Lin, Wanming, srirama chandra sekhar, Jerome Jiang, Javier Fernandez, Sinan Sahin, Peter Williamson, Avi Drissman, Nate Chapin, Khushal Sagar, Nikhil Nayunigari, Linyu He, Shu Yang, Kevin Babbitt, Hiroki Nakagawa, Heron Yang, Kevin McNee, Charles Hager, Mark Schillaci, Andrew Rayskiy, (Julie)Jeongeun Kim, Sadrul Chowdhury, Moe Adel, Henrique Ferreiro, Kenneth Rohde Christiansen, Arnaud Mandy, Jiewei Qian, Stephen Chenney, Hu, Ningxin, Raphael Kubo da Costa, Chromium Metrics Reviews, Mirko Bonadei, Luna Lu, Hirokazu Honda, Thorsten Kober, Fredrik Söderquist, Hans Wennborg, Tommy Li, Josh Karlin, Anurag Simgeker, Michael Moss, Kentaro Hara, Zijie He, Yao Xiao, Zewen Li, Daniel Cheng, James Maclean, Peter Beverloo, Simon Hangl, Wang, Wei4, Mangesh Ghiware, Enterprise Policy Reviews, James Su, Lei Zhang, Olga Gerchikov, Neil Coronado, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, AyeAye Python Dispatcher, chromium...@chromium.org, ortuno...@chromium.org, blink-re...@chromium.org, khorimoto+w...@chromium.org, zelin+watch-we...@chromium.org, browser-comp...@chromium.org, phoglun...@chromium.org, blink-re...@chromium.org, siashah+au...@chromium.org, tranbaod...@chromium.org, horo+...@chromium.org, filesapp...@chromium.org, tracing...@chromium.org, cfredri...@chromium.org, mbarowsky+watc...@chromium.org, crost...@chromium.org, chromium-a...@chromium.org, blink-revie...@chromium.org, chrome-intelligence-te...@google.com, lingqi...@chromium.org, jdonnel...@chromium.org, lucasrada...@google.com, stanfie...@google.com, hansberry+wat...@chromium.org, suetfei+wa...@google.com, kainin...@chromium.org, yyhyyh+watch-inpu...@google.com, estali...@chromium.org, penghuan...@chromium.org, crostin...@chromium.org, fuchsia...@chromium.org, nona+...@chromium.org, chromiumme...@microsoft.com, cros-report...@google.com, philli...@chromium.org, rainhar...@chromium.org, chadduffin+w...@chromium.org, mfoltz+wa...@chromium.org, cblume+im...@chromium.org, ddrone...@google.com, kinuko+...@chromium.org, odejesu...@chromium.org, mcasas+med...@chromium.org, cros-enterpris...@chromium.org, gangwu...@chromium.org, aixba+wat...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, rayanka...@chromium.org, blink-revi...@chromium.org, navigation...@chromium.org, ananyasee...@google.com, crmulli...@chromium.org, iwells...@chromium.org, ajayramamurthy...@google.com, rginda...@chromium.org, webap...@microsoft.com, print-revi...@chromium.org, titoua...@chromium.org, thiabaud+watch-d...@google.com, vinnypersky+...@google.com, prerenderi...@chromium.org, emircan+watch...@chromium.org, lizeb+watch...@chromium.org, menghua...@google.com, bmcquad...@chromium.org, loading-rev...@chromium.org, crisrael+wa...@google.com, tbansal+...@chromium.org, eme-r...@chromium.org, yhanada+...@chromium.org, telemetr...@chromium.org, speed-metrics...@chromium.org, devtools-re...@chromium.org, mattsimm...@chromium.org, dominicc+...@chromium.org, jackshira+wat...@google.com, scheduler-...@chromium.org, geoffla...@chromium.org, arthursonzog...@chromium.org, hsuregan+wa...@chromium.org, borealis-re...@google.com, aleventh...@chromium.org, feature-v...@chromium.org, ydago...@chromium.org, lens-chrome...@google.com, asvitkine...@chromium.org, zol...@webkit.org, blink-re...@chromium.org, media-wi...@chromium.org, kinuko...@chromium.org, fmalit...@chromium.org, donnd...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org, jonmann+wat...@chromium.org, kenjibah...@chromium.org, jorgel...@chromium.org, blink-rev...@chromium.org, gcasto+w...@chromium.org, derinel+wat...@google.com, cros-print...@google.com, dmblac...@google.com, pkotwic...@chromium.org, dmurph+watch...@chromium.org, jackshira+wa...@google.com, marq+...@chromium.org, blink-revie...@chromium.org, dfried...@chromium.org, edgesto...@microsoft.com, wangdanny+watch-in...@google.com, gavin...@chromium.org, network-ser...@chromium.org, chromotin...@chromium.org, martijn...@martijnc.be, ayman...@chromium.org, dtapuska+...@chromium.org, roblia...@chromium.org, pmonett...@chromium.org, chrome-gr...@chromium.org, pdf-r...@chromium.org, hansberry+wa...@chromium.org, blink-re...@chromium.org, asumane...@google.com, yuzo+...@chromium.org, fgal...@chromium.org, hansberry+wa...@chromium.org, hais+wat...@google.com, kinuko...@chromium.org, nickdiego+wa...@igalia.com, npm+...@chromium.org, ajayramamurthy...@google.com, ajwong...@chromium.org, blink-reviews-p...@chromium.org, japhet+...@chromium.org, armalhotra+a...@google.com, spang...@chromium.org, blink-rev...@chromium.org, kinuko+ser...@chromium.org, xiangdongkong+...@google.com, kyungjunle...@google.com, chrome-intell...@chromium.org, antoniosarto...@chromium.org, storage...@chromium.org, cc-...@chromium.org, headless...@chromium.org, mattreyno...@chromium.org, vasilii+watchlis...@chromium.org, jimmyxgong+watch...@chromium.org, shend...@chromium.org, ashleynewson+w...@chromium.org, dclasson+w...@google.com, sky+...@chromium.org, mar...@chromium.org, zackha...@chromium.org, ajayramamurthy+w...@google.com, net-r...@chromium.org, trewin...@google.com, wnwen...@chromium.org, joeantonetti+...@google.com, dibyapal+wa...@chromium.org, michaelchec...@google.com, dcheng+c...@chromium.org, michaelcheco+watch-i...@google.com, arc-review...@google.com, thefro...@chromium.org, tgupta...@chromium.org, enne...@chromium.org, blink-revie...@chromium.org, ender...@chromium.org, hidehik...@chromium.org, chromeos-ca...@google.com, fenced-fra...@chromium.org, grt+...@chromium.org, dtseng+c...@chromium.org, meilian...@chromium.org, tburkar...@chromium.org, vakh+safe_br...@chromium.org, chromeos-gfx-...@google.com, shuche...@chromium.org, ejcaruso+wa...@chromium.org, lwinston+watc...@google.com, pdr+svgw...@chromium.org, loading...@chromium.org, chrstn...@google.com, rrsilva+wat...@google.com, chrome-tab-group-en...@google.com, jkeitel+watch-...@google.com, lize...@chromium.org, loyso...@chromium.org, jackshira+wa...@google.com, niharm...@google.com, shimazu+se...@chromium.org, boujan...@google.com, davidj...@chromium.org, wfh+...@chromium.org, mreichhoff+watc...@chromium.org, xinghui...@chromium.org, mgiuca...@chromium.org, xlythe+wa...@google.com, dfalcant...@chromium.org, mek+w...@chromium.org, gavinp...@chromium.org, chrome-regionalc...@google.com, hirokisa...@chromium.org, jonmann+watc...@chromium.org, shgar+aut...@google.com, crisrael+wa...@google.com, subresource-f...@chromium.org, mtomas...@chromium.org, hayato...@chromium.org, blink-...@chromium.org, mbarowsky+watc...@chromium.org, droger+w...@chromium.org, yigu+...@chromium.org, asvitki...@chromium.org, cbe-cep-eng...@google.com, language...@chromium.org, mfoltz+wa...@chromium.org, yongshun+...@google.com, crisrael+w...@google.com, dmurph+watc...@chromium.org, webauthn...@chromium.org, bartek...@chromium.org, video-networking...@google.com, siyua+aut...@chromium.org, dennyh...@google.com, chfreme...@chromium.org, dmurph+watchin...@chromium.org, csharrison+...@chromium.org, fgorsk...@chromium.org, sloboda...@chromium.org, rkgibso...@chromium.org, aashna...@google.com, blink-rev...@chromium.org, extension...@chromium.org, jophba...@chromium.org, tbarzi...@chromium.org, mercer...@google.com, eic+...@google.com, josiah...@chromium.org, peilinwa...@google.com, dmurph+wa...@chromium.org, dtraino...@chromium.org, anastas...@google.com, joeantonetti+wa...@google.com, devtools...@chromium.org, srahim...@chromium.org, csharris...@chromium.org, dtseng...@chromium.org, jdeblas...@chromium.org, dullweb...@chromium.org, ricea...@chromium.org, yuezhang...@chromium.org, shannc...@chromium.org, rsleev...@chromium.org, ashleydp+fe...@google.com, byronle...@chromium.org, chungshe...@google.com, knollr+wat...@chromium.org, jackshira+w...@google.com, ozone-...@chromium.org, mfoltz+wa...@chromium.org, mac-r...@chromium.org, stevenjb+wa...@chromium.org, julietlevesque...@google.com, feature-me...@chromium.org, mkwst+w...@chromium.org, akingsb+wat...@google.com, ios-web-view...@google.com, ramyagopa...@google.com, loading-re...@chromium.org, dmurph+watchi...@chromium.org, torne...@chromium.org, bling-ai-foundatio...@google.com, yusufo...@chromium.org, loading-rev...@chromium.org, yhanada...@chromium.org, blink-rev...@chromium.org, francisjp...@google.com, pushi+watc...@google.com, fserb...@chromium.org, keithle...@chromium.org, oshima...@chromium.org, cwalle...@chromium.org, mdjone...@chromium.org, blink-work...@chromium.org, eric.c...@apple.com, longbowei+fe...@google.com, cros-setti...@google.com, jiajunz+wa...@google.com, abigailbk...@google.com, ntp-dev...@chromium.org, print-rev...@chromium.org, creis...@chromium.org, chili...@chromium.org, jeffreycohen+watc...@chromium.org, dtapuska+ch...@chromium.org, blink-revi...@chromium.org, core-web-vita...@chromium.org, drott...@chromium.org, roagarw...@chromium.org, nyquis...@chromium.org, omnibox-...@chromium.org, tmartino+tran...@chromium.org, shimazu...@chromium.org, johnche...@chromium.org, twelling...@chromium.org, iclella...@chromium.org, agriev...@chromium.org, yfriedm...@chromium.org, jasonrobe...@google.com, translat...@chromium.org, jmedle...@chromium.org, vaapi-...@chromium.org, jonmann+wa...@chromium.org, kuragin+web-ap...@chromium.org, cros-essential...@chromium.org, halliwe...@chromium.org, servicewor...@chromium.org, drott+bl...@chromium.org, cblume...@chromium.org, max+watc...@igalia.com, performance-m...@chromium.org, tommyw+w...@chromium.org, blink-revi...@chromium.org, hanxi...@chromium.org, security-...@chromium.org, permissio...@chromium.org, weiluanw...@google.com, katie...@chromium.org, harringt...@chromium.org, dmurph+wat...@chromium.org, hansberry+w...@chromium.org, ios-revie...@chromium.org, nektar...@chromium.org, pasko...@chromium.org, khmel...@chromium.org, petewi...@chromium.org, jz...@chromium.org, jshin...@chromium.org, toyosh...@chromium.org, msrame...@chromium.org, cros-ed...@google.com, christia...@chromium.org, jatapiaro+wat...@google.com, gavinp...@chromium.org, nator...@chromium.org, jackshira+w...@google.com, rmcelra...@chromium.org, thegreenf...@chromium.org, twifka...@chromium.org, wychen...@chromium.org, croissant-...@chromium.org, lizeb...@chromium.org, jinsukk...@chromium.org, hansenmichael...@google.com, chromeos-kio...@google.com, pushi+wat...@google.com, speed-metr...@chromium.org, jessemcke...@google.com, osaul+aut...@google.com, gavin...@chromium.org, apavlo...@chromium.org, ajayramamurth...@google.com, web-schedulin...@chromium.org, yyhyyh+fee...@google.com, chikamu...@chromium.org, bnc+...@chromium.org, nicolas...@chromium.org, yhiran...@chromium.org, nwoked...@chromium.org, xiaohui...@chromium.org, kouhe...@chromium.org, media-cro...@chromium.org, wangdanny+fe...@google.com, alexmo...@chromium.org, webapks-...@chromium.org, accessibility-a...@google.com, gogeral...@chromium.org, dewitt...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, Takuto Ikuta
Attention needed from Mike Dougherty

Takuto Ikuta removed chrome-b...@google.com from this change

Deleted Reviewers:
Open in Gerrit

Related details

Attention is currently required from:
  • Mike Dougherty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: deleteReviewer
satisfied_requirement
unsatisfied_requirement
open
diffy

Mike Dougherty (Gerrit)

unread,
May 5, 2026, 1:46:01 PM (6 days ago) May 5
to Alexandra Pereira, Kenneth R Christiansen, Menard, Alexis, Hongchan Choi, Christian Biesinger, Rijubrata Bhaumik, Dirk Schulze, Lin, Wanming, srirama chandra sekhar, Jerome Jiang, Javier Fernandez, Sinan Sahin, Peter Williamson, Avi Drissman, Nate Chapin, Khushal Sagar, Nikhil Nayunigari, Linyu He, Shu Yang, Kevin Babbitt, Hiroki Nakagawa, Heron Yang, Kevin McNee, Charles Hager, Mark Schillaci, Andrew Rayskiy, (Julie)Jeongeun Kim, Sadrul Chowdhury, Moe Adel, Henrique Ferreiro, Kenneth Rohde Christiansen, Arnaud Mandy, Jiewei Qian, Stephen Chenney, Hu, Ningxin, Raphael Kubo da Costa, Chromium Metrics Reviews, Mirko Bonadei, Luna Lu, Hirokazu Honda, Thorsten Kober, Fredrik Söderquist, Hans Wennborg, Tommy Li, Josh Karlin, Anurag Simgeker, Michael Moss, Kentaro Hara, Zijie He, Yao Xiao, Zewen Li, Daniel Cheng, James Maclean, Peter Beverloo, Simon Hangl, Wang, Wei4, Mangesh Ghiware, Enterprise Policy Reviews, James Su, Lei Zhang, Olga Gerchikov, Neil Coronado, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, AyeAye Python Dispatcher, chromium...@chromium.org, ortuno...@chromium.org, blink-re...@chromium.org, khorimoto+w...@chromium.org, zelin+watch-we...@chromium.org, browser-comp...@chromium.org, phoglun...@chromium.org, blink-re...@chromium.org, siashah+au...@chromium.org, tranbaod...@chromium.org, horo+...@chromium.org, filesapp...@chromium.org, tracing...@chromium.org, cfredri...@chromium.org, mbarowsky+watc...@chromium.org, crost...@chromium.org, chromium-a...@chromium.org, blink-revie...@chromium.org, chrome-intelligence-te...@google.com, lingqi...@chromium.org, jdonnel...@chromium.org, lucasrada...@google.com, stanfie...@google.com, hansberry+wat...@chromium.org, suetfei+wa...@google.com, kainin...@chromium.org, yyhyyh+watch-inpu...@google.com, estali...@chromium.org, penghuan...@chromium.org, crostin...@chromium.org, fuchsia...@chromium.org, nona+...@chromium.org, chromiumme...@microsoft.com, cros-report...@google.com, philli...@chromium.org, rainhar...@chromium.org, chadduffin+w...@chromium.org, mfoltz+wa...@chromium.org, cblume+im...@chromium.org, ddrone...@google.com, kinuko+...@chromium.org, odejesu...@chromium.org, mcasas+med...@chromium.org, cros-enterpris...@chromium.org, gangwu...@chromium.org, aixba+wat...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, rayanka...@chromium.org, blink-revi...@chromium.org, navigation...@chromium.org, ananyasee...@google.com, crmulli...@chromium.org, iwells...@chromium.org, ajayramamurthy...@google.com, rginda...@chromium.org, webap...@microsoft.com, print-revi...@chromium.org, titoua...@chromium.org, thiabaud+watch-d...@google.com, vinnypersky+...@google.com, prerenderi...@chromium.org, emircan+watch...@chromium.org, lizeb+watch...@chromium.org, menghua...@google.com, bmcquad...@chromium.org, loading-rev...@chromium.org, crisrael+wa...@google.com, tbansal+...@chromium.org, eme-r...@chromium.org, yhanada+...@chromium.org, telemetr...@chromium.org, speed-metrics...@chromium.org, devtools-re...@chromium.org, mattsimm...@chromium.org, dominicc+...@chromium.org, jackshira+wat...@google.com, scheduler-...@chromium.org, geoffla...@chromium.org, arthursonzog...@chromium.org, hsuregan+wa...@chromium.org, borealis-re...@google.com, aleventh...@chromium.org, feature-v...@chromium.org, ydago...@chromium.org, lens-chrome...@google.com, asvitkine...@chromium.org, zol...@webkit.org, blink-re...@chromium.org, media-wi...@chromium.org, kinuko...@chromium.org, fmalit...@chromium.org, donnd...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org, jonmann+wat...@chromium.org, kenjibah...@chromium.org, jorgel...@chromium.org, blink-rev...@chromium.org, gcasto+w...@chromium.org, derinel+wat...@google.com, cros-print...@google.com, dmblac...@google.com, pkotwic...@chromium.org, dmurph+watch...@chromium.org, jackshira+wa...@google.com, marq+...@chromium.org, blink-revie...@chromium.org, dfried...@chromium.org, edgesto...@microsoft.com, wangdanny+watch-in...@google.com, gavin...@chromium.org, network-ser...@chromium.org, chromotin...@chromium.org, martijn...@martijnc.be, ayman...@chromium.org, dtapuska+...@chromium.org, roblia...@chromium.org, pmonett...@chromium.org, chrome-gr...@chromium.org, pdf-r...@chromium.org, hansberry+wa...@chromium.org, blink-re...@chromium.org, asumane...@google.com, yuzo+...@chromium.org, fgal...@chromium.org, hansberry+wa...@chromium.org, hais+wat...@google.com, kinuko...@chromium.org, nickdiego+wa...@igalia.com, npm+...@chromium.org, ajayramamurthy...@google.com, ajwong...@chromium.org, blink-reviews-p...@chromium.org, japhet+...@chromium.org, armalhotra+a...@google.com, spang...@chromium.org, blink-rev...@chromium.org, kinuko+ser...@chromium.org, xiangdongkong+...@google.com, kyungjunle...@google.com, chrome-intell...@chromium.org, antoniosarto...@chromium.org, storage...@chromium.org, cc-...@chromium.org, headless...@chromium.org, mattreyno...@chromium.org, vasilii+watchlis...@chromium.org, jimmyxgong+watch...@chromium.org, shend...@chromium.org, ashleynewson+w...@chromium.org, dclasson+w...@google.com, sky+...@chromium.org, mar...@chromium.org, zackha...@chromium.org, ajayramamurthy+w...@google.com, net-r...@chromium.org, trewin...@google.com, wnwen...@chromium.org, joeantonetti+...@google.com, dibyapal+wa...@chromium.org, michaelchec...@google.com, dcheng+c...@chromium.org, michaelcheco+watch-i...@google.com, arc-review...@google.com, thefro...@chromium.org, tgupta...@chromium.org, enne...@chromium.org, blink-revie...@chromium.org, ender...@chromium.org, hidehik...@chromium.org, chromeos-ca...@google.com, fenced-fra...@chromium.org, grt+...@chromium.org, dtseng+c...@chromium.org, meilian...@chromium.org, tburkar...@chromium.org, vakh+safe_br...@chromium.org, chromeos-gfx-...@google.com, shuche...@chromium.org, ejcaruso+wa...@chromium.org, lwinston+watc...@google.com, pdr+svgw...@chromium.org, loading...@chromium.org, chrstn...@google.com, rrsilva+wat...@google.com, chrome-tab-group-en...@google.com, jkeitel+watch-...@google.com, lize...@chromium.org, loyso...@chromium.org, jackshira+wa...@google.com, niharm...@google.com, shimazu+se...@chromium.org, boujan...@google.com, davidj...@chromium.org, wfh+...@chromium.org, mreichhoff+watc...@chromium.org, xinghui...@chromium.org, mgiuca...@chromium.org, xlythe+wa...@google.com, dfalcant...@chromium.org, mek+w...@chromium.org, gavinp...@chromium.org, chrome-regionalc...@google.com, hirokisa...@chromium.org, jonmann+watc...@chromium.org, shgar+aut...@google.com, crisrael+wa...@google.com, subresource-f...@chromium.org, mtomas...@chromium.org, hayato...@chromium.org, blink-...@chromium.org, mbarowsky+watc...@chromium.org, droger+w...@chromium.org, yigu+...@chromium.org, asvitki...@chromium.org, cbe-cep-eng...@google.com, language...@chromium.org, mfoltz+wa...@chromium.org, yongshun+...@google.com, crisrael+w...@google.com, dmurph+watc...@chromium.org, webauthn...@chromium.org, bartek...@chromium.org, video-networking...@google.com, siyua+aut...@chromium.org, dennyh...@google.com, chfreme...@chromium.org, dmurph+watchin...@chromium.org, csharrison+...@chromium.org, fgorsk...@chromium.org, sloboda...@chromium.org, rkgibso...@chromium.org, aashna...@google.com, blink-rev...@chromium.org, extension...@chromium.org, jophba...@chromium.org, tbarzi...@chromium.org, mercer...@google.com, eic+...@google.com, josiah...@chromium.org, peilinwa...@google.com, dmurph+wa...@chromium.org, dtraino...@chromium.org, anastas...@google.com, joeantonetti+wa...@google.com, devtools...@chromium.org, srahim...@chromium.org, csharris...@chromium.org, dtseng...@chromium.org, jdeblas...@chromium.org, dullweb...@chromium.org, ricea...@chromium.org, yuezhang...@chromium.org, shannc...@chromium.org, rsleev...@chromium.org, ashleydp+fe...@google.com, byronle...@chromium.org, chungshe...@google.com, knollr+wat...@chromium.org, jackshira+w...@google.com, ozone-...@chromium.org, mfoltz+wa...@chromium.org, mac-r...@chromium.org, stevenjb+wa...@chromium.org, julietlevesque...@google.com, feature-me...@chromium.org, mkwst+w...@chromium.org, akingsb+wat...@google.com, ios-web-view...@google.com, ramyagopa...@google.com, loading-re...@chromium.org, dmurph+watchi...@chromium.org, torne...@chromium.org, bling-ai-foundatio...@google.com, yusufo...@chromium.org, loading-rev...@chromium.org, yhanada...@chromium.org, blink-rev...@chromium.org, francisjp...@google.com, pushi+watc...@google.com, fserb...@chromium.org, keithle...@chromium.org, oshima...@chromium.org, cwalle...@chromium.org, mdjone...@chromium.org, blink-work...@chromium.org, eric.c...@apple.com, longbowei+fe...@google.com, cros-setti...@google.com, jiajunz+wa...@google.com, abigailbk...@google.com, ntp-dev...@chromium.org, print-rev...@chromium.org, creis...@chromium.org, chili...@chromium.org, jeffreycohen+watc...@chromium.org, dtapuska+ch...@chromium.org, blink-revi...@chromium.org, core-web-vita...@chromium.org, drott...@chromium.org, roagarw...@chromium.org, nyquis...@chromium.org, omnibox-...@chromium.org, tmartino+tran...@chromium.org, shimazu...@chromium.org, johnche...@chromium.org, twelling...@chromium.org, iclella...@chromium.org, agriev...@chromium.org, yfriedm...@chromium.org, jasonrobe...@google.com, translat...@chromium.org, jmedle...@chromium.org, vaapi-...@chromium.org, jonmann+wa...@chromium.org, kuragin+web-ap...@chromium.org, cros-essential...@chromium.org, halliwe...@chromium.org, servicewor...@chromium.org, drott+bl...@chromium.org, cblume...@chromium.org, max+watc...@igalia.com, performance-m...@chromium.org, tommyw+w...@chromium.org, blink-revi...@chromium.org, hanxi...@chromium.org, security-...@chromium.org, permissio...@chromium.org, weiluanw...@google.com, katie...@chromium.org, harringt...@chromium.org, dmurph+wat...@chromium.org, hansberry+w...@chromium.org, ios-revie...@chromium.org, nektar...@chromium.org, pasko...@chromium.org, khmel...@chromium.org, petewi...@chromium.org, jz...@chromium.org, jshin...@chromium.org, toyosh...@chromium.org, msrame...@chromium.org, cros-ed...@google.com, christia...@chromium.org, jatapiaro+wat...@google.com, gavinp...@chromium.org, nator...@chromium.org, jackshira+w...@google.com, rmcelra...@chromium.org, thegreenf...@chromium.org, twifka...@chromium.org, wychen...@chromium.org, croissant-...@chromium.org, lizeb...@chromium.org, jinsukk...@chromium.org, hansenmichael...@google.com, chromeos-kio...@google.com, pushi+wat...@google.com, speed-metr...@chromium.org, jessemcke...@google.com, osaul+aut...@google.com, gavin...@chromium.org, apavlo...@chromium.org, ajayramamurth...@google.com, web-schedulin...@chromium.org, yyhyyh+fee...@google.com, chikamu...@chromium.org, bnc+...@chromium.org, nicolas...@chromium.org, yhiran...@chromium.org, nwoked...@chromium.org, xiaohui...@chromium.org, kouhe...@chromium.org, media-cro...@chromium.org, wangdanny+fe...@google.com, alexmo...@chromium.org, webapks-...@chromium.org, accessibility-a...@google.com, gogeral...@chromium.org, dewitt...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org
Attention needed from Alexandra Pereira

Mike Dougherty voted and added 3 comments

Votes added by Mike Dougherty

Code-Review+1

3 comments

File ios/web/js_messaging/web_frame_internal.h
Line 65, Patchset 13 (Latest): // Calls the JavaScript function `name` asynchronously in `content_world`.
Mike Dougherty . unresolved

nit: The call to JS isn't really async, but rather it calls a function which can include async JS.

Line 56, Patchset 13 (Latest): // `CallAsyncJavaScriptFunctionInContentWorld` family of functions instead to
Mike Dougherty . unresolved

there is only one, so replace with "function"

File ios/web/public/js_messaging/web_frame.h
Line 104, Patchset 13 (Latest): // Calls the JavaScript function `name` asynchronously in the frame context.
Mike Dougherty . unresolved

same comment as above: "nit: The call to JS isn't really async, but rather it calls a function which can include async JS."

Open in Gerrit

Related details

Attention is currently required from:
  • Alexandra Pereira
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0917f68bfe28b832dada5999ad5d1c41185f6057
Gerrit-Change-Number: 7796039
Gerrit-PatchSet: 13
Gerrit-Attention: Alexandra Pereira <alexa...@google.com>
Gerrit-Comment-Date: Tue, 05 May 2026 17:45:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Alexandra Pereira (Gerrit)

unread,
May 5, 2026, 3:47:08 PM (6 days ago) May 5
to Mike Dougherty, Kenneth R Christiansen, Menard, Alexis, Hongchan Choi, Christian Biesinger, Rijubrata Bhaumik, Dirk Schulze, Lin, Wanming, srirama chandra sekhar, Jerome Jiang, Javier Fernandez, Sinan Sahin, Peter Williamson, Avi Drissman, Nate Chapin, Khushal Sagar, Nikhil Nayunigari, Linyu He, Shu Yang, Kevin Babbitt, Hiroki Nakagawa, Heron Yang, Kevin McNee, Charles Hager, Mark Schillaci, Andrew Rayskiy, (Julie)Jeongeun Kim, Sadrul Chowdhury, Moe Adel, Henrique Ferreiro, Kenneth Rohde Christiansen, Arnaud Mandy, Jiewei Qian, Stephen Chenney, Hu, Ningxin, Raphael Kubo da Costa, Chromium Metrics Reviews, Mirko Bonadei, Luna Lu, Hirokazu Honda, Thorsten Kober, Fredrik Söderquist, Hans Wennborg, Tommy Li, Josh Karlin, Anurag Simgeker, Michael Moss, Kentaro Hara, Zijie He, Yao Xiao, Zewen Li, Daniel Cheng, James Maclean, Peter Beverloo, Simon Hangl, Wang, Wei4, Mangesh Ghiware, Enterprise Policy Reviews, James Su, Lei Zhang, Olga Gerchikov, Neil Coronado, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, AyeAye Python Dispatcher, chromium...@chromium.org, ortuno...@chromium.org, blink-re...@chromium.org, khorimoto+w...@chromium.org, zelin+watch-we...@chromium.org, browser-comp...@chromium.org, phoglun...@chromium.org, blink-re...@chromium.org, siashah+au...@chromium.org, tranbaod...@chromium.org, horo+...@chromium.org, filesapp...@chromium.org, tracing...@chromium.org, cfredri...@chromium.org, mbarowsky+watc...@chromium.org, crost...@chromium.org, chromium-a...@chromium.org, blink-revie...@chromium.org, chrome-intelligence-te...@google.com, lingqi...@chromium.org, jdonnel...@chromium.org, lucasrada...@google.com, stanfie...@google.com, hansberry+wat...@chromium.org, suetfei+wa...@google.com, kainin...@chromium.org, yyhyyh+watch-inpu...@google.com, estali...@chromium.org, penghuan...@chromium.org, crostin...@chromium.org, fuchsia...@chromium.org, nona+...@chromium.org, chromiumme...@microsoft.com, cros-report...@google.com, philli...@chromium.org, rainhar...@chromium.org, chadduffin+w...@chromium.org, mfoltz+wa...@chromium.org, cblume+im...@chromium.org, ddrone...@google.com, kinuko+...@chromium.org, odejesu...@chromium.org, mcasas+med...@chromium.org, cros-enterpris...@chromium.org, gangwu...@chromium.org, aixba+wat...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, rayanka...@chromium.org, blink-revi...@chromium.org, navigation...@chromium.org, ananyasee...@google.com, crmulli...@chromium.org, iwells...@chromium.org, ajayramamurthy...@google.com, rginda...@chromium.org, webap...@microsoft.com, print-revi...@chromium.org, titoua...@chromium.org, thiabaud+watch-d...@google.com, vinnypersky+...@google.com, prerenderi...@chromium.org, emircan+watch...@chromium.org, lizeb+watch...@chromium.org, menghua...@google.com, bmcquad...@chromium.org, loading-rev...@chromium.org, crisrael+wa...@google.com, tbansal+...@chromium.org, eme-r...@chromium.org, yhanada+...@chromium.org, telemetr...@chromium.org, speed-metrics...@chromium.org, devtools-re...@chromium.org, mattsimm...@chromium.org, dominicc+...@chromium.org, jackshira+wat...@google.com, scheduler-...@chromium.org, geoffla...@chromium.org, arthursonzog...@chromium.org, hsuregan+wa...@chromium.org, borealis-re...@google.com, aleventh...@chromium.org, feature-v...@chromium.org, ydago...@chromium.org, lens-chrome...@google.com, asvitkine...@chromium.org, zol...@webkit.org, blink-re...@chromium.org, media-wi...@chromium.org, kinuko...@chromium.org, fmalit...@chromium.org, donnd...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org, jonmann+wat...@chromium.org, kenjibah...@chromium.org, jorgel...@chromium.org, blink-rev...@chromium.org, gcasto+w...@chromium.org, derinel+wat...@google.com, cros-print...@google.com, dmblac...@google.com, pkotwic...@chromium.org, dmurph+watch...@chromium.org, jackshira+wa...@google.com, marq+...@chromium.org, blink-revie...@chromium.org, dfried...@chromium.org, edgesto...@microsoft.com, wangdanny+watch-in...@google.com, gavin...@chromium.org, network-ser...@chromium.org, chromotin...@chromium.org, martijn...@martijnc.be, ayman...@chromium.org, dtapuska+...@chromium.org, roblia...@chromium.org, pmonett...@chromium.org, chrome-gr...@chromium.org, pdf-r...@chromium.org, hansberry+wa...@chromium.org, blink-re...@chromium.org, asumane...@google.com, yuzo+...@chromium.org, fgal...@chromium.org, hansberry+wa...@chromium.org, hais+wat...@google.com, kinuko...@chromium.org, nickdiego+wa...@igalia.com, npm+...@chromium.org, ajayramamurthy...@google.com, ajwong...@chromium.org, blink-reviews-p...@chromium.org, japhet+...@chromium.org, armalhotra+a...@google.com, spang...@chromium.org, blink-rev...@chromium.org, kinuko+ser...@chromium.org, xiangdongkong+...@google.com, kyungjunle...@google.com, chrome-intell...@chromium.org, antoniosarto...@chromium.org, storage...@chromium.org, cc-...@chromium.org, headless...@chromium.org, mattreyno...@chromium.org, vasilii+watchlis...@chromium.org, jimmyxgong+watch...@chromium.org, shend...@chromium.org, ashleynewson+w...@chromium.org, dclasson+w...@google.com, sky+...@chromium.org, mar...@chromium.org, zackha...@chromium.org, ajayramamurthy+w...@google.com, net-r...@chromium.org, trewin...@google.com, wnwen...@chromium.org, joeantonetti+...@google.com, dibyapal+wa...@chromium.org, michaelchec...@google.com, dcheng+c...@chromium.org, michaelcheco+watch-i...@google.com, arc-review...@google.com, thefro...@chromium.org, tgupta...@chromium.org, enne...@chromium.org, blink-revie...@chromium.org, ender...@chromium.org, hidehik...@chromium.org, chromeos-ca...@google.com, fenced-fra...@chromium.org, grt+...@chromium.org, dtseng+c...@chromium.org, meilian...@chromium.org, tburkar...@chromium.org, vakh+safe_br...@chromium.org, chromeos-gfx-...@google.com, shuche...@chromium.org, ejcaruso+wa...@chromium.org, lwinston+watc...@google.com, pdr+svgw...@chromium.org, loading...@chromium.org, chrstn...@google.com, rrsilva+wat...@google.com, chrome-tab-group-en...@google.com, jkeitel+watch-...@google.com, lize...@chromium.org, loyso...@chromium.org, jackshira+wa...@google.com, niharm...@google.com, shimazu+se...@chromium.org, boujan...@google.com, davidj...@chromium.org, wfh+...@chromium.org, mreichhoff+watc...@chromium.org, xinghui...@chromium.org, mgiuca...@chromium.org, xlythe+wa...@google.com, dfalcant...@chromium.org, mek+w...@chromium.org, gavinp...@chromium.org, chrome-regionalc...@google.com, hirokisa...@chromium.org, jonmann+watc...@chromium.org, shgar+aut...@google.com, crisrael+wa...@google.com, subresource-f...@chromium.org, mtomas...@chromium.org, hayato...@chromium.org, blink-...@chromium.org, mbarowsky+watc...@chromium.org, droger+w...@chromium.org, yigu+...@chromium.org, asvitki...@chromium.org, cbe-cep-eng...@google.com, language...@chromium.org, mfoltz+wa...@chromium.org, yongshun+...@google.com, crisrael+w...@google.com, dmurph+watc...@chromium.org, webauthn...@chromium.org, bartek...@chromium.org, video-networking...@google.com, siyua+aut...@chromium.org, dennyh...@google.com, chfreme...@chromium.org, dmurph+watchin...@chromium.org, csharrison+...@chromium.org, fgorsk...@chromium.org, sloboda...@chromium.org, rkgibso...@chromium.org, aashna...@google.com, blink-rev...@chromium.org, extension...@chromium.org, jophba...@chromium.org, tbarzi...@chromium.org, mercer...@google.com, eic+...@google.com, josiah...@chromium.org, peilinwa...@google.com, dmurph+wa...@chromium.org, dtraino...@chromium.org, anastas...@google.com, joeantonetti+wa...@google.com, devtools...@chromium.org, srahim...@chromium.org, csharris...@chromium.org, dtseng...@chromium.org, jdeblas...@chromium.org, dullweb...@chromium.org, ricea...@chromium.org, yuezhang...@chromium.org, shannc...@chromium.org, rsleev...@chromium.org, ashleydp+fe...@google.com, byronle...@chromium.org, chungshe...@google.com, knollr+wat...@chromium.org, jackshira+w...@google.com, ozone-...@chromium.org, mfoltz+wa...@chromium.org, mac-r...@chromium.org, stevenjb+wa...@chromium.org, julietlevesque...@google.com, feature-me...@chromium.org, mkwst+w...@chromium.org, akingsb+wat...@google.com, ios-web-view...@google.com, ramyagopa...@google.com, loading-re...@chromium.org, dmurph+watchi...@chromium.org, torne...@chromium.org, bling-ai-foundatio...@google.com, yusufo...@chromium.org, loading-rev...@chromium.org, yhanada...@chromium.org, blink-rev...@chromium.org, francisjp...@google.com, pushi+watc...@google.com, fserb...@chromium.org, keithle...@chromium.org, oshima...@chromium.org, cwalle...@chromium.org, mdjone...@chromium.org, blink-work...@chromium.org, eric.c...@apple.com, longbowei+fe...@google.com, cros-setti...@google.com, jiajunz+wa...@google.com, abigailbk...@google.com, ntp-dev...@chromium.org, print-rev...@chromium.org, creis...@chromium.org, chili...@chromium.org, jeffreycohen+watc...@chromium.org, dtapuska+ch...@chromium.org, blink-revi...@chromium.org, core-web-vita...@chromium.org, drott...@chromium.org, roagarw...@chromium.org, nyquis...@chromium.org, omnibox-...@chromium.org, tmartino+tran...@chromium.org, shimazu...@chromium.org, johnche...@chromium.org, twelling...@chromium.org, iclella...@chromium.org, agriev...@chromium.org, yfriedm...@chromium.org, jasonrobe...@google.com, translat...@chromium.org, jmedle...@chromium.org, vaapi-...@chromium.org, jonmann+wa...@chromium.org, kuragin+web-ap...@chromium.org, cros-essential...@chromium.org, halliwe...@chromium.org, servicewor...@chromium.org, drott+bl...@chromium.org, cblume...@chromium.org, max+watc...@igalia.com, performance-m...@chromium.org, tommyw+w...@chromium.org, blink-revi...@chromium.org, hanxi...@chromium.org, security-...@chromium.org, permissio...@chromium.org, weiluanw...@google.com, katie...@chromium.org, harringt...@chromium.org, dmurph+wat...@chromium.org, hansberry+w...@chromium.org, ios-revie...@chromium.org, nektar...@chromium.org, pasko...@chromium.org, khmel...@chromium.org, petewi...@chromium.org, jz...@chromium.org, jshin...@chromium.org, toyosh...@chromium.org, msrame...@chromium.org, cros-ed...@google.com, christia...@chromium.org, jatapiaro+wat...@google.com, gavinp...@chromium.org, nator...@chromium.org, jackshira+w...@google.com, rmcelra...@chromium.org, thegreenf...@chromium.org, twifka...@chromium.org, wychen...@chromium.org, croissant-...@chromium.org, lizeb...@chromium.org, jinsukk...@chromium.org, hansenmichael...@google.com, chromeos-kio...@google.com, pushi+wat...@google.com, speed-metr...@chromium.org, jessemcke...@google.com, osaul+aut...@google.com, gavin...@chromium.org, apavlo...@chromium.org, ajayramamurth...@google.com, web-schedulin...@chromium.org, yyhyyh+fee...@google.com, chikamu...@chromium.org, bnc+...@chromium.org, nicolas...@chromium.org, yhiran...@chromium.org, nwoked...@chromium.org, xiaohui...@chromium.org, kouhe...@chromium.org, media-cro...@chromium.org, wangdanny+fe...@google.com, alexmo...@chromium.org, webapks-...@chromium.org, accessibility-a...@google.com, gogeral...@chromium.org, dewitt...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org

Alexandra Pereira voted and added 3 comments

Votes added by Alexandra Pereira

Commit-Queue+2

3 comments

File ios/web/js_messaging/web_frame_internal.h
Line 65, Patchset 13: // Calls the JavaScript function `name` asynchronously in `content_world`.
Mike Dougherty . resolved

nit: The call to JS isn't really async, but rather it calls a function which can include async JS.

Alexandra Pereira

Done

Line 56, Patchset 13: // `CallAsyncJavaScriptFunctionInContentWorld` family of functions instead to
Mike Dougherty . resolved

there is only one, so replace with "function"

Alexandra Pereira

Done

File ios/web/public/js_messaging/web_frame.h
Line 104, Patchset 13: // Calls the JavaScript function `name` asynchronously in the frame context.
Mike Dougherty . resolved

same comment as above: "nit: The call to JS isn't really async, but rather it calls a function which can include async JS."

Alexandra Pereira

Done

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I0917f68bfe28b832dada5999ad5d1c41185f6057
    Gerrit-Change-Number: 7796039
    Gerrit-PatchSet: 14
    Gerrit-Comment-Date: Tue, 05 May 2026 19:47:00 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Mike Dougherty <mich...@chromium.org>
    satisfied_requirement
    open
    diffy

    Alexandra Pereira (Gerrit)

    unread,
    May 6, 2026, 10:10:27 AM (5 days ago) May 6
    to Mike Dougherty, Kenneth R Christiansen, Menard, Alexis, Hongchan Choi, Christian Biesinger, Rijubrata Bhaumik, Dirk Schulze, Lin, Wanming, srirama chandra sekhar, Jerome Jiang, Javier Fernandez, Sinan Sahin, Peter Williamson, Avi Drissman, Nate Chapin, Khushal Sagar, Nikhil Nayunigari, Linyu He, Shu Yang, Kevin Babbitt, Hiroki Nakagawa, Heron Yang, Kevin McNee, Charles Hager, Mark Schillaci, Andrew Rayskiy, (Julie)Jeongeun Kim, Sadrul Chowdhury, Moe Adel, Henrique Ferreiro, Kenneth Rohde Christiansen, Arnaud Mandy, Jiewei Qian, Stephen Chenney, Hu, Ningxin, Raphael Kubo da Costa, Chromium Metrics Reviews, Mirko Bonadei, Luna Lu, Hirokazu Honda, Thorsten Kober, Fredrik Söderquist, Hans Wennborg, Tommy Li, Josh Karlin, Anurag Simgeker, Michael Moss, Kentaro Hara, Zijie He, Yao Xiao, Zewen Li, Daniel Cheng, James Maclean, Peter Beverloo, Simon Hangl, Wang, Wei4, Mangesh Ghiware, Enterprise Policy Reviews, James Su, Lei Zhang, Olga Gerchikov, Neil Coronado, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, AyeAye Python Dispatcher, chromium...@chromium.org, ortuno...@chromium.org, blink-re...@chromium.org, khorimoto+w...@chromium.org, zelin+watch-we...@chromium.org, browser-comp...@chromium.org, phoglun...@chromium.org, blink-re...@chromium.org, siashah+au...@chromium.org, tranbaod...@chromium.org, horo+...@chromium.org, filesapp...@chromium.org, tracing...@chromium.org, cfredri...@chromium.org, mbarowsky+watc...@chromium.org, crost...@chromium.org, chromium-a...@chromium.org, blink-revie...@chromium.org, chrome-intelligence-te...@google.com, lingqi...@chromium.org, jdonnel...@chromium.org, lucasrada...@google.com, stanfie...@google.com, hansberry+wat...@chromium.org, suetfei+wa...@google.com, kainin...@chromium.org, yyhyyh+watch-inpu...@google.com, estali...@chromium.org, penghuan...@chromium.org, crostin...@chromium.org, fuchsia...@chromium.org, nona+...@chromium.org, chromiumme...@microsoft.com, cros-report...@google.com, philli...@chromium.org, rainhar...@chromium.org, chadduffin+w...@chromium.org, mfoltz+wa...@chromium.org, cblume+im...@chromium.org, ddrone...@google.com, kinuko+...@chromium.org, odejesu...@chromium.org, mcasas+med...@chromium.org, cros-enterpris...@chromium.org, gangwu...@chromium.org, aixba+wat...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, rayanka...@chromium.org, blink-revi...@chromium.org, navigation...@chromium.org, ananyasee...@google.com, crmulli...@chromium.org, iwells...@chromium.org, ajayramamurthy...@google.com, rginda...@chromium.org, webap...@microsoft.com, print-revi...@chromium.org, titoua...@chromium.org, thiabaud+watch-d...@google.com, vinnypersky+...@google.com, prerenderi...@chromium.org, emircan+watch...@chromium.org, lizeb+watch...@chromium.org, menghua...@google.com, bmcquad...@chromium.org, loading-rev...@chromium.org, crisrael+wa...@google.com, tbansal+...@chromium.org, eme-r...@chromium.org, yhanada+...@chromium.org, telemetr...@chromium.org, speed-metrics...@chromium.org, devtools-re...@chromium.org, mattsimm...@chromium.org, dominicc+...@chromium.org, jackshira+wat...@google.com, scheduler-...@chromium.org, geoffla...@chromium.org, arthursonzog...@chromium.org, hsuregan+wa...@chromium.org, borealis-re...@google.com, aleventh...@chromium.org, feature-v...@chromium.org, ydago...@chromium.org, lens-chrome...@google.com, asvitkine...@chromium.org, zol...@webkit.org, blink-re...@chromium.org, media-wi...@chromium.org, kinuko...@chromium.org, fmalit...@chromium.org, donnd...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org, jonmann+wat...@chromium.org, kenjibah...@chromium.org, jorgel...@chromium.org, blink-rev...@chromium.org, gcasto+w...@chromium.org, derinel+wat...@google.com, cros-print...@google.com, dmblac...@google.com, pkotwic...@chromium.org, dmurph+watch...@chromium.org, jackshira+wa...@google.com, marq+...@chromium.org, blink-revie...@chromium.org, dfried...@chromium.org, edgesto...@microsoft.com, wangdanny+watch-in...@google.com, gavin...@chromium.org, network-ser...@chromium.org, chromotin...@chromium.org, martijn...@martijnc.be, ayman...@chromium.org, dtapuska+...@chromium.org, roblia...@chromium.org, pmonett...@chromium.org, chrome-gr...@chromium.org, pdf-r...@chromium.org, hansberry+wa...@chromium.org, blink-re...@chromium.org, asumane...@google.com, yuzo+...@chromium.org, fgal...@chromium.org, hansberry+wa...@chromium.org, hais+wat...@google.com, kinuko...@chromium.org, nickdiego+wa...@igalia.com, npm+...@chromium.org, ajayramamurthy...@google.com, ajwong...@chromium.org, blink-reviews-p...@chromium.org, japhet+...@chromium.org, armalhotra+a...@google.com, spang...@chromium.org, blink-rev...@chromium.org, kinuko+ser...@chromium.org, xiangdongkong+...@google.com, kyungjunle...@google.com, chrome-intell...@chromium.org, antoniosarto...@chromium.org, storage...@chromium.org, cc-...@chromium.org, headless...@chromium.org, mattreyno...@chromium.org, vasilii+watchlis...@chromium.org, jimmyxgong+watch...@chromium.org, shend...@chromium.org, ashleynewson+w...@chromium.org, dclasson+w...@google.com, sky+...@chromium.org, mar...@chromium.org, zackha...@chromium.org, ajayramamurthy+w...@google.com, net-r...@chromium.org, trewin...@google.com, wnwen...@chromium.org, joeantonetti+...@google.com, dibyapal+wa...@chromium.org, michaelchec...@google.com, dcheng+c...@chromium.org, michaelcheco+watch-i...@google.com, arc-review...@google.com, thefro...@chromium.org, tgupta...@chromium.org, enne...@chromium.org, blink-revie...@chromium.org, ender...@chromium.org, hidehik...@chromium.org, chromeos-ca...@google.com, fenced-fra...@chromium.org, grt+...@chromium.org, dtseng+c...@chromium.org, meilian...@chromium.org, tburkar...@chromium.org, vakh+safe_br...@chromium.org, chromeos-gfx-...@google.com, shuche...@chromium.org, ejcaruso+wa...@chromium.org, lwinston+watc...@google.com, pdr+svgw...@chromium.org, loading...@chromium.org, chrstn...@google.com, rrsilva+wat...@google.com, chrome-tab-group-en...@google.com, jkeitel+watch-...@google.com, lize...@chromium.org, loyso...@chromium.org, jackshira+wa...@google.com, niharm...@google.com, shimazu+se...@chromium.org, boujan...@google.com, davidj...@chromium.org, wfh+...@chromium.org, mreichhoff+watc...@chromium.org, xinghui...@chromium.org, mgiuca...@chromium.org, xlythe+wa...@google.com, dfalcant...@chromium.org, mek+w...@chromium.org, gavinp...@chromium.org, chrome-regionalc...@google.com, hirokisa...@chromium.org, jonmann+watc...@chromium.org, shgar+aut...@google.com, crisrael+wa...@google.com, subresource-f...@chromium.org, mtomas...@chromium.org, hayato...@chromium.org, blink-...@chromium.org, mbarowsky+watc...@chromium.org, droger+w...@chromium.org, yigu+...@chromium.org, asvitki...@chromium.org, cbe-cep-eng...@google.com, language...@chromium.org, mfoltz+wa...@chromium.org, yongshun+...@google.com, crisrael+w...@google.com, dmurph+watc...@chromium.org, webauthn...@chromium.org, bartek...@chromium.org, video-networking...@google.com, siyua+aut...@chromium.org, dennyh...@google.com, chfreme...@chromium.org, dmurph+watchin...@chromium.org, csharrison+...@chromium.org, fgorsk...@chromium.org, sloboda...@chromium.org, rkgibso...@chromium.org, aashna...@google.com, blink-rev...@chromium.org, extension...@chromium.org, jophba...@chromium.org, tbarzi...@chromium.org, mercer...@google.com, eic+...@google.com, josiah...@chromium.org, peilinwa...@google.com, dmurph+wa...@chromium.org, dtraino...@chromium.org, anastas...@google.com, joeantonetti+wa...@google.com, devtools...@chromium.org, srahim...@chromium.org, csharris...@chromium.org, dtseng...@chromium.org, jdeblas...@chromium.org, dullweb...@chromium.org, ricea...@chromium.org, yuezhang...@chromium.org, shannc...@chromium.org, rsleev...@chromium.org, ashleydp+fe...@google.com, byronle...@chromium.org, chungshe...@google.com, knollr+wat...@chromium.org, jackshira+w...@google.com, ozone-...@chromium.org, mfoltz+wa...@chromium.org, mac-r...@chromium.org, stevenjb+wa...@chromium.org, julietlevesque...@google.com, feature-me...@chromium.org, mkwst+w...@chromium.org, akingsb+wat...@google.com, ios-web-view...@google.com, ramyagopa...@google.com, loading-re...@chromium.org, dmurph+watchi...@chromium.org, torne...@chromium.org, bling-ai-foundatio...@google.com, yusufo...@chromium.org, loading-rev...@chromium.org, yhanada...@chromium.org, blink-rev...@chromium.org, francisjp...@google.com, pushi+watc...@google.com, fserb...@chromium.org, keithle...@chromium.org, oshima...@chromium.org, cwalle...@chromium.org, mdjone...@chromium.org, blink-work...@chromium.org, eric.c...@apple.com, longbowei+fe...@google.com, cros-setti...@google.com, jiajunz+wa...@google.com, abigailbk...@google.com, ntp-dev...@chromium.org, print-rev...@chromium.org, creis...@chromium.org, chili...@chromium.org, jeffreycohen+watc...@chromium.org, dtapuska+ch...@chromium.org, blink-revi...@chromium.org, core-web-vita...@chromium.org, drott...@chromium.org, roagarw...@chromium.org, nyquis...@chromium.org, omnibox-...@chromium.org, tmartino+tran...@chromium.org, shimazu...@chromium.org, johnche...@chromium.org, twelling...@chromium.org, iclella...@chromium.org, agriev...@chromium.org, yfriedm...@chromium.org, jasonrobe...@google.com, translat...@chromium.org, jmedle...@chromium.org, vaapi-...@chromium.org, jonmann+wa...@chromium.org, kuragin+web-ap...@chromium.org, cros-essential...@chromium.org, halliwe...@chromium.org, servicewor...@chromium.org, drott+bl...@chromium.org, cblume...@chromium.org, max+watc...@igalia.com, performance-m...@chromium.org, tommyw+w...@chromium.org, blink-revi...@chromium.org, hanxi...@chromium.org, security-...@chromium.org, permissio...@chromium.org, weiluanw...@google.com, katie...@chromium.org, harringt...@chromium.org, dmurph+wat...@chromium.org, hansberry+w...@chromium.org, ios-revie...@chromium.org, nektar...@chromium.org, pasko...@chromium.org, khmel...@chromium.org, petewi...@chromium.org, jz...@chromium.org, jshin...@chromium.org, toyosh...@chromium.org, msrame...@chromium.org, cros-ed...@google.com, christia...@chromium.org, jatapiaro+wat...@google.com, gavinp...@chromium.org, nator...@chromium.org, jackshira+w...@google.com, rmcelra...@chromium.org, thegreenf...@chromium.org, twifka...@chromium.org, wychen...@chromium.org, croissant-...@chromium.org, lizeb...@chromium.org, jinsukk...@chromium.org, hansenmichael...@google.com, chromeos-kio...@google.com, pushi+wat...@google.com, speed-metr...@chromium.org, jessemcke...@google.com, osaul+aut...@google.com, gavin...@chromium.org, apavlo...@chromium.org, ajayramamurth...@google.com, web-schedulin...@chromium.org, yyhyyh+fee...@google.com, chikamu...@chromium.org, bnc+...@chromium.org, nicolas...@chromium.org, yhiran...@chromium.org, nwoked...@chromium.org, xiaohui...@chromium.org, kouhe...@chromium.org, media-cro...@chromium.org, wangdanny+fe...@google.com, alexmo...@chromium.org, webapks-...@chromium.org, accessibility-a...@google.com, gogeral...@chromium.org, dewitt...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org

    Alexandra Pereira voted Commit-Queue+2

    Commit-Queue+2
    Gerrit-Comment-Date: Wed, 06 May 2026 14:10:17 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    May 6, 2026, 10:13:49 AM (5 days ago) May 6
    to Alexandra Pereira, Mike Dougherty, Akihiro Ota, Kenneth R Christiansen, Menard, Alexis, Hongchan Choi, Christian Biesinger, Rijubrata Bhaumik, Dirk Schulze, Lin, Wanming, srirama chandra sekhar, Jerome Jiang, Javier Fernandez, Sinan Sahin, Peter Williamson, Avi Drissman, Nate Chapin, Khushal Sagar, Nikhil Nayunigari, Linyu He, Shu Yang, Kevin Babbitt, Hiroki Nakagawa, Heron Yang, Kevin McNee, Charles Hager, Mark Schillaci, Andrew Rayskiy, (Julie)Jeongeun Kim, Sadrul Chowdhury, Moe Adel, Henrique Ferreiro, Kenneth Rohde Christiansen, Arnaud Mandy, Jiewei Qian, Stephen Chenney, Hu, Ningxin, Raphael Kubo da Costa, Chromium Metrics Reviews, Mirko Bonadei, Luna Lu, Hirokazu Honda, Thorsten Kober, Fredrik Söderquist, Hans Wennborg, Tommy Li, Josh Karlin, Anurag Simgeker, Michael Moss, Kentaro Hara, Zijie He, Yao Xiao, Zewen Li, Daniel Cheng, James Maclean, Peter Beverloo, Simon Hangl, Wang, Wei4, Mangesh Ghiware, Enterprise Policy Reviews, James Su, Lei Zhang, Olga Gerchikov, Neil Coronado, android-bu...@system.gserviceaccount.com, AyeAye Python Dispatcher, chromium...@chromium.org, ortuno...@chromium.org, blink-re...@chromium.org, khorimoto+w...@chromium.org, zelin+watch-we...@chromium.org, browser-comp...@chromium.org, phoglun...@chromium.org, blink-re...@chromium.org, siashah+au...@chromium.org, tranbaod...@chromium.org, horo+...@chromium.org, filesapp...@chromium.org, tracing...@chromium.org, cfredri...@chromium.org, mbarowsky+watc...@chromium.org, crost...@chromium.org, chromium-a...@chromium.org, blink-revie...@chromium.org, chrome-intelligence-te...@google.com, lingqi...@chromium.org, jdonnel...@chromium.org, lucasrada...@google.com, stanfie...@google.com, hansberry+wat...@chromium.org, suetfei+wa...@google.com, kainin...@chromium.org, yyhyyh+watch-inpu...@google.com, estali...@chromium.org, penghuan...@chromium.org, crostin...@chromium.org, fuchsia...@chromium.org, nona+...@chromium.org, chromiumme...@microsoft.com, cros-report...@google.com, philli...@chromium.org, rainhar...@chromium.org, chadduffin+w...@chromium.org, mfoltz+wa...@chromium.org, cblume+im...@chromium.org, ddrone...@google.com, kinuko+...@chromium.org, odejesu...@chromium.org, mcasas+med...@chromium.org, cros-enterpris...@chromium.org, gangwu...@chromium.org, aixba+wat...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, rayanka...@chromium.org, blink-revi...@chromium.org, navigation...@chromium.org, ananyasee...@google.com, crmulli...@chromium.org, iwells...@chromium.org, ajayramamurthy...@google.com, rginda...@chromium.org, webap...@microsoft.com, print-revi...@chromium.org, titoua...@chromium.org, thiabaud+watch-d...@google.com, vinnypersky+...@google.com, prerenderi...@chromium.org, emircan+watch...@chromium.org, lizeb+watch...@chromium.org, menghua...@google.com, bmcquad...@chromium.org, loading-rev...@chromium.org, crisrael+wa...@google.com, tbansal+...@chromium.org, eme-r...@chromium.org, yhanada+...@chromium.org, telemetr...@chromium.org, speed-metrics...@chromium.org, devtools-re...@chromium.org, mattsimm...@chromium.org, dominicc+...@chromium.org, jackshira+wat...@google.com, scheduler-...@chromium.org, geoffla...@chromium.org, arthursonzog...@chromium.org, hsuregan+wa...@chromium.org, borealis-re...@google.com, aleventh...@chromium.org, feature-v...@chromium.org, ydago...@chromium.org, lens-chrome...@google.com, asvitkine...@chromium.org, zol...@webkit.org, blink-re...@chromium.org, media-wi...@chromium.org, kinuko...@chromium.org, fmalit...@chromium.org, donnd...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org, jonmann+wat...@chromium.org, kenjibah...@chromium.org, jorgel...@chromium.org, blink-rev...@chromium.org, gcasto+w...@chromium.org, derinel+wat...@google.com, cros-print...@google.com, dmblac...@google.com, pkotwic...@chromium.org, dmurph+watch...@chromium.org, jackshira+wa...@google.com, marq+...@chromium.org, blink-revie...@chromium.org, dfried...@chromium.org, edgesto...@microsoft.com, wangdanny+watch-in...@google.com, gavin...@chromium.org, network-ser...@chromium.org, chromotin...@chromium.org, martijn...@martijnc.be, ayman...@chromium.org, dtapuska+...@chromium.org, roblia...@chromium.org, pmonett...@chromium.org, chrome-gr...@chromium.org, pdf-r...@chromium.org, hansberry+wa...@chromium.org, blink-re...@chromium.org, asumane...@google.com, yuzo+...@chromium.org, fgal...@chromium.org, hansberry+wa...@chromium.org, hais+wat...@google.com, kinuko...@chromium.org, nickdiego+wa...@igalia.com, npm+...@chromium.org, ajayramamurthy...@google.com, ajwong...@chromium.org, blink-reviews-p...@chromium.org, japhet+...@chromium.org, armalhotra+a...@google.com, spang...@chromium.org, blink-rev...@chromium.org, kinuko+ser...@chromium.org, xiangdongkong+...@google.com, kyungjunle...@google.com, chrome-intell...@chromium.org, antoniosarto...@chromium.org, storage...@chromium.org, cc-...@chromium.org, headless...@chromium.org, mattreyno...@chromium.org, vasilii+watchlis...@chromium.org, jimmyxgong+watch...@chromium.org, shend...@chromium.org, ashleynewson+w...@chromium.org, dclasson+w...@google.com, sky+...@chromium.org, mar...@chromium.org, zackha...@chromium.org, ajayramamurthy+w...@google.com, net-r...@chromium.org, trewin...@google.com, wnwen...@chromium.org, joeantonetti+...@google.com, dibyapal+wa...@chromium.org, michaelchec...@google.com, dcheng+c...@chromium.org, michaelcheco+watch-i...@google.com, arc-review...@google.com, thefro...@chromium.org, tgupta...@chromium.org, enne...@chromium.org, blink-revie...@chromium.org, ender...@chromium.org, hidehik...@chromium.org, chromeos-ca...@google.com, fenced-fra...@chromium.org, grt+...@chromium.org, dtseng+c...@chromium.org, meilian...@chromium.org, tburkar...@chromium.org, vakh+safe_br...@chromium.org, chromeos-gfx-...@google.com, shuche...@chromium.org, ejcaruso+wa...@chromium.org, lwinston+watc...@google.com, pdr+svgw...@chromium.org, loading...@chromium.org, chrstn...@google.com, rrsilva+wat...@google.com, chrome-tab-group-en...@google.com, jkeitel+watch-...@google.com, lize...@chromium.org, loyso...@chromium.org, jackshira+wa...@google.com, niharm...@google.com, shimazu+se...@chromium.org, boujan...@google.com, davidj...@chromium.org, wfh+...@chromium.org, mreichhoff+watc...@chromium.org, xinghui...@chromium.org, mgiuca...@chromium.org, xlythe+wa...@google.com, dfalcant...@chromium.org, mek+w...@chromium.org, gavinp...@chromium.org, chrome-regionalc...@google.com, hirokisa...@chromium.org, jonmann+watc...@chromium.org, shgar+aut...@google.com, crisrael+wa...@google.com, subresource-f...@chromium.org, mtomas...@chromium.org, hayato...@chromium.org, blink-...@chromium.org, mbarowsky+watc...@chromium.org, droger+w...@chromium.org, yigu+...@chromium.org, asvitki...@chromium.org, cbe-cep-eng...@google.com, language...@chromium.org, mfoltz+wa...@chromium.org, yongshun+...@google.com, crisrael+w...@google.com, dmurph+watc...@chromium.org, webauthn...@chromium.org, bartek...@chromium.org, video-networking...@google.com, siyua+aut...@chromium.org, dennyh...@google.com, chfreme...@chromium.org, dmurph+watchin...@chromium.org, csharrison+...@chromium.org, fgorsk...@chromium.org, sloboda...@chromium.org, rkgibso...@chromium.org, aashna...@google.com, blink-rev...@chromium.org, extension...@chromium.org, jophba...@chromium.org, tbarzi...@chromium.org, mercer...@google.com, eic+...@google.com, josiah...@chromium.org, peilinwa...@google.com, dmurph+wa...@chromium.org, dtraino...@chromium.org, anastas...@google.com, joeantonetti+wa...@google.com, devtools...@chromium.org, srahim...@chromium.org, csharris...@chromium.org, dtseng...@chromium.org, jdeblas...@chromium.org, dullweb...@chromium.org, ricea...@chromium.org, yuezhang...@chromium.org, shannc...@chromium.org, rsleev...@chromium.org, ashleydp+fe...@google.com, byronle...@chromium.org, chungshe...@google.com, knollr+wat...@chromium.org, jackshira+w...@google.com, ozone-...@chromium.org, mfoltz+wa...@chromium.org, mac-r...@chromium.org, stevenjb+wa...@chromium.org, julietlevesque...@google.com, feature-me...@chromium.org, mkwst+w...@chromium.org, akingsb+wat...@google.com, ios-web-view...@google.com, ramyagopa...@google.com, loading-re...@chromium.org, dmurph+watchi...@chromium.org, torne...@chromium.org, bling-ai-foundatio...@google.com, yusufo...@chromium.org, loading-rev...@chromium.org, yhanada...@chromium.org, blink-rev...@chromium.org, francisjp...@google.com, pushi+watc...@google.com, fserb...@chromium.org, keithle...@chromium.org, oshima...@chromium.org, cwalle...@chromium.org, mdjone...@chromium.org, blink-work...@chromium.org, eric.c...@apple.com, longbowei+fe...@google.com, cros-setti...@google.com, jiajunz+wa...@google.com, abigailbk...@google.com, ntp-dev...@chromium.org, print-rev...@chromium.org, creis...@chromium.org, chili...@chromium.org, jeffreycohen+watc...@chromium.org, dtapuska+ch...@chromium.org, blink-revi...@chromium.org, core-web-vita...@chromium.org, drott...@chromium.org, roagarw...@chromium.org, nyquis...@chromium.org, omnibox-...@chromium.org, tmartino+tran...@chromium.org, shimazu...@chromium.org, johnche...@chromium.org, twelling...@chromium.org, iclella...@chromium.org, agriev...@chromium.org, yfriedm...@chromium.org, jasonrobe...@google.com, translat...@chromium.org, jmedle...@chromium.org, vaapi-...@chromium.org, jonmann+wa...@chromium.org, kuragin+web-ap...@chromium.org, cros-essential...@chromium.org, halliwe...@chromium.org, servicewor...@chromium.org, drott+bl...@chromium.org, cblume...@chromium.org, max+watc...@igalia.com, performance-m...@chromium.org, tommyw+w...@chromium.org, blink-revi...@chromium.org, hanxi...@chromium.org, security-...@chromium.org, permissio...@chromium.org, weiluanw...@google.com, katie...@chromium.org, harringt...@chromium.org, dmurph+wat...@chromium.org, hansberry+w...@chromium.org, ios-revie...@chromium.org, nektar...@chromium.org, pasko...@chromium.org, khmel...@chromium.org, petewi...@chromium.org, jz...@chromium.org, jshin...@chromium.org, toyosh...@chromium.org, msrame...@chromium.org, cros-ed...@google.com, christia...@chromium.org, jatapiaro+wat...@google.com, gavinp...@chromium.org, nator...@chromium.org, jackshira+w...@google.com, rmcelra...@chromium.org, thegreenf...@chromium.org, twifka...@chromium.org, wychen...@chromium.org, croissant-...@chromium.org, lizeb...@chromium.org, jinsukk...@chromium.org, hansenmichael...@google.com, chromeos-kio...@google.com, pushi+wat...@google.com, speed-metr...@chromium.org, jessemcke...@google.com, osaul+aut...@google.com, gavin...@chromium.org, apavlo...@chromium.org, ajayramamurth...@google.com, web-schedulin...@chromium.org, yyhyyh+fee...@google.com, chikamu...@chromium.org, bnc+...@chromium.org, nicolas...@chromium.org, yhiran...@chromium.org, nwoked...@chromium.org, xiaohui...@chromium.org, kouhe...@chromium.org, media-cro...@chromium.org, wangdanny+fe...@google.com, alexmo...@chromium.org, webapks-...@chromium.org, accessibility-a...@google.com, gogeral...@chromium.org, dewitt...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org

    Chromium LUCI CQ submitted the change with unreviewed changes

    Unreviewed changes

    13 is the latest approved patch-set.
    The change was submitted with unreviewed changes in the following files:

    ```
    The name of the file: ios/web/public/js_messaging/web_frame.h
    Insertions: 5, Deletions: 3.

    The diff is too large to show. Please review the diff.
    ```
    ```
    The name of the file: ios/web/js_messaging/web_frame_internal.h
    Insertions: 6, Deletions: 4.

    The diff is too large to show. Please review the diff.
    ```

    Change information

    Commit message:
    [iOS][Web] Add CallAsyncJavaScriptFunction to WebFrame API

    This CL introduces `CallAsyncJavaScriptFunction` and
    `CallAsyncJavaScriptFunctionInContentWorld` to the WebFrame API. These
    methods allow native code to call JavaScript functions asynchronously,
    including those that return Promises.
    Bug: 496168031
    Change-Id: I0917f68bfe28b832dada5999ad5d1c41185f6057
    Commit-Queue: Alexandra Pereira <alexa...@google.com>
    Reviewed-by: Mike Dougherty <mich...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1626153}
    Files:
    Change size: L
    Delta: 10 files changed, 341 insertions(+), 2 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Mike Dougherty
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I0917f68bfe28b832dada5999ad5d1c41185f6057
    Gerrit-Change-Number: 7796039
    Gerrit-PatchSet: 15
    Gerrit-Owner: Alexandra Pereira <alexa...@google.com>
    Gerrit-Reviewer: Alexandra Pereira <alexa...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Mike Dougherty <mich...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    Gerrit-CC: Anurag Simgeker <anurags...@google.com>
    Gerrit-CC: Arnaud Mandy <arnaud...@intel.com>
    Gerrit-CC: Avi Drissman <a...@chromium.org>
    Gerrit-CC: AyeAye Python Dispatcher <android-build-ayeay...@system.gserviceaccount.com>
    Gerrit-CC: Charles Hager <clh...@google.com>
    Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages