[blink/scheduler] Don't over trigger policy update with aggressive busy looping [chromium/src : main]

0 views
Skip to first unread message

Benoit Lize (Gerrit)

unread,
Mar 31, 2026, 7:05:43 AM (2 days ago) Mar 31
to Etienne Pierre-Doray, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, chikamu...@chromium.org, kinuko...@chromium.org, scheduler-...@chromium.org
Attention needed from Etienne Pierre-Doray

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Etienne Pierre-Doray
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia7cb46484d9a1d7a5782b3420234834fae530ca7
Gerrit-Change-Number: 7705952
Gerrit-PatchSet: 1
Gerrit-Owner: Benoit Lize <li...@chromium.org>
Gerrit-Reviewer: Benoit Lize <li...@chromium.org>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Attention: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Comment-Date: Tue, 31 Mar 2026 11:05:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Etienne Pierre-Doray (Gerrit)

unread,
Apr 1, 2026, 10:20:31 AM (yesterday) Apr 1
to Benoit Lize, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, chikamu...@chromium.org, kinuko...@chromium.org, scheduler-...@chromium.org
Attention needed from Benoit Lize

Etienne Pierre-Doray voted and added 1 comment

Votes added by Etienne Pierre-Doray

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Etienne Pierre-Doray . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Benoit Lize
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia7cb46484d9a1d7a5782b3420234834fae530ca7
Gerrit-Change-Number: 7705952
Gerrit-PatchSet: 1
Gerrit-Owner: Benoit Lize <li...@chromium.org>
Gerrit-Reviewer: Benoit Lize <li...@chromium.org>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Attention: Benoit Lize <li...@chromium.org>
Gerrit-Comment-Date: Wed, 01 Apr 2026 14:20:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Benoit Lize (Gerrit)

unread,
Apr 1, 2026, 10:21:52 AM (yesterday) Apr 1
to Etienne Pierre-Doray, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, chikamu...@chromium.org, kinuko...@chromium.org, scheduler-...@chromium.org

Benoit Lize voted and added 1 comment

Votes added by Benoit Lize

Commit-Queue+2

1 comment

Patchset-level comments
Benoit Lize . resolved

Thanks!

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia7cb46484d9a1d7a5782b3420234834fae530ca7
Gerrit-Change-Number: 7705952
Gerrit-PatchSet: 1
Gerrit-Owner: Benoit Lize <li...@chromium.org>
Gerrit-Reviewer: Benoit Lize <li...@chromium.org>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Comment-Date: Wed, 01 Apr 2026 14:21:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Apr 1, 2026, 12:42:01 PM (yesterday) Apr 1
to Benoit Lize, Etienne Pierre-Doray, chromium...@chromium.org, blink-...@chromium.org, chikamu...@chromium.org, kinuko...@chromium.org, scheduler-...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[blink/scheduler] Don't over trigger policy update with aggressive busy looping

When kBusyLoopAggressiveAfterCommittedLoad is enabled, for 500ms after each
committed load, each task will trigger a policy update, to potentially exit this
mode. This is showing to be costly in the field. Instead, post a task to end the
aggressive mode.
Bug: 485239634
Change-Id: Ia7cb46484d9a1d7a5782b3420234834fae530ca7
Reviewed-by: Etienne Pierre-Doray <etie...@chromium.org>
Commit-Queue: Benoit Lize <li...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1608600}
Files:
  • M third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc
Change size: S
Delta: 1 file changed, 11 insertions(+), 5 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Etienne Pierre-Doray
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia7cb46484d9a1d7a5782b3420234834fae530ca7
Gerrit-Change-Number: 7705952
Gerrit-PatchSet: 2
Gerrit-Owner: Benoit Lize <li...@chromium.org>
Gerrit-Reviewer: Benoit Lize <li...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages