Thiabaud Engelbrecht (Gerrit)

unread,

Mar 19, 2026, 10:22:32 AMMar 19

to Etienne Pierre-Doray, AyeAye, chromium...@chromium.org, blink-...@chromium.org, chikamu...@chromium.org, kinuko...@chromium.org, scheduler-...@chromium.org

Attention needed from Etienne Pierre-Doray

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:

Etienne Pierre-Doray

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Etienne Pierre-Doray (Gerrit)

unread,

Mar 19, 2026, 10:22:47 AMMar 19

to Thiabaud Engelbrecht, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, blink-...@chromium.org, chikamu...@chromium.org, kinuko...@chromium.org, scheduler-...@chromium.org

Attention needed from Thiabaud Engelbrecht

Etienne Pierre-Doray voted and added 1 comment

Votes added by Etienne Pierre-Doray

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Etienne Pierre-Doray . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:

Thiabaud Engelbrecht

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Thiabaud Engelbrecht (Gerrit)

unread,

Mar 19, 2026, 10:59:06 AMMar 19

to Etienne Pierre-Doray, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, blink-...@chromium.org, chikamu...@chromium.org, kinuko...@chromium.org, scheduler-...@chromium.org

Thiabaud Engelbrecht voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Kevin Ellis (Gerrit)

unread,

Mar 23, 2026, 3:45:33 PM (10 days ago) Mar 23

to Thiabaud Engelbrecht, Olga Gerchikov, Menard, Alexis, Raphael Kubo da Costa, Kentaro Hara, Etienne Pierre-Doray, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chikamu...@chromium.org, kinuko...@chromium.org, scheduler-...@chromium.org

Attention needed from Etienne Pierre-Doray and Thiabaud Engelbrecht

Kevin Ellis added 1 comment

File third_party/blink/renderer/core/animation/animation.cc

Line 2252, Patchset 4 (Latest): pending_finish_notification_ ||

Kevin Ellis . unresolved

Can likely fix the failing unit test in compositor_animations_test.cc by adding a call to perform a microtask checkpoint in SimulateFrame() after the call to Update(). This will ensure that he pending_finish_notification_ flag is cleared before the GC call in the test. This checkpoint was called in version of SimulateFrame() in animation_test.cc by was missing from compositor_animations_test.cc.

Open in Gerrit

Related details

Attention is currently required from:

Etienne Pierre-Doray
Thiabaud Engelbrecht

Submit Requirements:

Code-Coverage

Code-Owners
Code-Review

No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Kevin Ellis (Gerrit)

unread,

Mar 24, 2026, 8:36:22 AM (9 days ago) Mar 24

to Thiabaud Engelbrecht, Olga Gerchikov, Menard, Alexis, Raphael Kubo da Costa, Kentaro Hara, Etienne Pierre-Doray, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chikamu...@chromium.org, kinuko...@chromium.org, scheduler-...@chromium.org

Attention needed from Etienne Pierre-Doray and Thiabaud Engelbrecht

Kevin Ellis added 1 comment

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Kevin Ellis . resolved

Failure in EffectStackTest looks like it can be resolved in a similar manner to the composited animations test.

In effect_stack_test.cc:
```
 void UpdateTimeline(base::TimeDelta time) {
    GetDocument().GetAnimationClock().UpdateTime(
        GetDocument().Timeline().CalculateZeroTime() + time);
    timeline->ServiceAnimations(kTimingUpdateForAnimationFrame);
    
    // <--- insert a call to perform a microtask checkpoint here.
  }
```

Open in Gerrit

Related details

Attention is currently required from:

Etienne Pierre-Doray
Thiabaud Engelbrecht

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Thiabaud Engelbrecht (Gerrit)

unread,

Mar 27, 2026, 3:05:42 PM (6 days ago) Mar 27

to Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, blink-revie...@chromium.org, blink-...@chromium.org, chikamu...@chromium.org, kinuko...@chromium.org, scheduler-...@chromium.org

Attention needed from Thiabaud Engelbrecht

Message from Thiabaud Engelbrecht

Set Ready For Review

Open in Gerrit

Related details

Attention is currently required from:

Thiabaud Engelbrecht

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Etienne Pierre-Doray (Gerrit)

unread,

Mar 27, 2026, 3:06:45 PM (6 days ago) Mar 27

to Thiabaud Engelbrecht, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, blink-revie...@chromium.org, blink-...@chromium.org, chikamu...@chromium.org, kinuko...@chromium.org, scheduler-...@chromium.org

Attention needed from Thiabaud Engelbrecht

Etienne Pierre-Doray voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Thiabaud Engelbrecht

Submit Requirements:

Code-Coverage

Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Thiabaud Engelbrecht (Gerrit)

unread,

Mar 27, 2026, 3:41:25 PM (6 days ago) Mar 27

to Etienne Pierre-Doray, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, blink-revie...@chromium.org, blink-...@chromium.org, chikamu...@chromium.org, kinuko...@chromium.org, scheduler-...@chromium.org

Thiabaud Engelbrecht voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Mar 27, 2026, 4:49:06 PM (6 days ago) Mar 27

to Thiabaud Engelbrecht, Etienne Pierre-Doray, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, blink-revie...@chromium.org, blink-...@chromium.org, chikamu...@chromium.org, kinuko...@chromium.org, scheduler-...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

[input mode] Enable by default on Chromium side

Doc here: https://docs.google.com/document/d/1_j6a4dEmYHLYEYSE7qDLpD7jcisMYg4GrSvvzIi4N6I/edit?tab=t.0

Bug: 444705203

Change-Id: I5f99d3e59f8b9236d7cd6bcf183e4928bfa75990

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7700736

Reviewed-by: Etienne Pierre-Doray <etie...@chromium.org>

Commit-Queue: Thiabaud Engelbrecht <thia...@google.com>

Cr-Commit-Position: refs/heads/main@{#1606449}

Files:

M third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc

Change size: XS

Delta: 1 file changed, 1 insertion(+), 1 deletion(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Etienne Pierre-Doray

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

[input mode] Enable by default on Chromium side [chromium/src : main]

Thiabaud Engelbrecht (Gerrit)

New activity on the change

Related details

Etienne Pierre-Doray (Gerrit)

Etienne Pierre-Doray voted and added 1 comment

Votes added by Etienne Pierre-Doray

1 comment

Related details

Thiabaud Engelbrecht (Gerrit)

Thiabaud Engelbrecht voted Commit-Queue+2

Related details

Kevin Ellis (Gerrit)

Kevin Ellis added 1 comment

Related details

Kevin Ellis (Gerrit)

Kevin Ellis added 1 comment

Related details

Thiabaud Engelbrecht (Gerrit)

Message from Thiabaud Engelbrecht

Related details

Etienne Pierre-Doray (Gerrit)

Etienne Pierre-Doray voted Code-Review+1

Related details

Thiabaud Engelbrecht (Gerrit)

Thiabaud Engelbrecht voted Commit-Queue+2

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information