[MAGI] Update jj_git expert with recent findings [chromium/src : main]

[Joe Downing (Gerrit)]

Attention needed from Tzarial

Joe Downing has uploaded the change for review

Joe Downing would like Tzarial to review this change.

Commit message

[MAGI] Update jj_git expert with recent findings

Change-Id: If1021c737ea010c97fc4fe3a633af5f2ec9a52e3

Change diff

diff --git a/remoting/tools/magi-mode/personas/infra/jj_git.json b/remoting/tools/magi-mode/personas/infra/jj_git.json
index a5eff2f8..dcaaaf7 100644
--- a/remoting/tools/magi-mode/personas/infra/jj_git.json
+++ b/remoting/tools/magi-mode/personas/infra/jj_git.json
@@ -3,6 +3,8 @@
   "mandate": "Expert in jj on Git workflow, focusing on preserving Change-Ids and managing detached HEAD states.",
   "checklist": {
     "preserve_change_id": "Ensure `jj describe` does not overwrite the `Change-Id` footer when updating commit messages for Gerrit.",
-    "detached_head_awareness": "Remember that `jj` operates in a detached HEAD state in Git, so tools like `git cl status` may not map local commits to Gerrit issues automatically."
+    "detached_head_awareness": "Remember that `jj` operates in a detached HEAD state in Git, so tools like `git cl status` may not map local commits to Gerrit issues automatically.",
+    "sync_git_head": "Ensure Git `HEAD` is in sync with the `jj` parent commit before running `git cl upload` to avoid including unrelated changes in the diff.",
+    "avoid_no_squash": "Avoid `--no-squash` if it causes `git cl` to upload too many unrelated changes due to detached HEAD state."
   }
 }

Change information

Files:

• M remoting/tools/magi-mode/personas/infra/jj_git.json

Change size: XS

Delta: 1 file changed, 3 insertions(+), 1 deletion(-)

Open in Gerrit

Related details

Attention is currently required from:

• Tzarial

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: newchange

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: If1021c737ea010c97fc4fe3a633af5f2ec9a52e3

Gerrit-Change-Number: 7833647

Gerrit-PatchSet: 1

Gerrit-Owner: Joe Downing <joe...@chromium.org>

Gerrit-Reviewer: Tzarial <zo...@chromium.org>

Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>

Gerrit-CC: Akihiro Ota <akihi...@chromium.org>

Gerrit-CC: Andrew Rayskiy <green...@google.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>

Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: Mike Taylor <mike...@chromium.org>

Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>

Gerrit-CC: Peter Beverloo <pe...@chromium.org>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: Victor Tan <vict...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: chromotin...@chromium.org

Gerrit-Attention: Tzarial <zo...@chromium.org>

[Joe Downing (Gerrit)]

Joe Downing has uploaded the change for review

Joe Downing removed Olga Gerchikov, Andrew Rayskiy, Tzarial, Akihiro Ota, Chromium Metrics Reviews, Enterprise Policy Reviews, Victor Tan, Simon Hangl, (Julie)Jeongeun Kim, Mike Taylor, Menard, Alexis, Kevin Babbitt, Peter Beverloo, agriev...@chromium.org, cc-...@chromium.org, zackha...@chromium.org, stanfie...@google.com, feature-me...@chromium.org, ios-r...@chromium.org, storage...@chromium.org, blink-...@chromium.org, zelin+watch-we...@chromium.org, chromium-a...@chromium.org, jmedle...@chromium.org, sky+...@chromium.org, vasilii+watchlis...@chromium.org, zol...@webkit.org, francisjp...@google.com, josiah...@chromium.org, peilinwa...@google.com, ckitaga...@chromium.org, yongshun+...@google.com, ender...@chromium.org, rmcelra...@chromium.org, niharm...@google.com, dibyapal+wa...@chromium.org, nwoked...@chromium.org, hidehik...@chromium.org, jimmyxgong+watch...@chromium.org, mercer...@google.com, browser-comp...@chromium.org, oshima...@chromium.org, feature-v...@chromium.org, lwinston+watc...@google.com, hanxi...@chromium.org, andysjl...@chromium.org, arc-review...@google.com, dmurph+wat...@chromium.org, lucasrada...@google.com, dmurph+wa...@chromium.org, titoua...@chromium.org, chromiumme...@microsoft.com, dtraino...@chromium.org, rrsilva+wat...@google.com, derinel+wat...@google.com, mac-r...@chromium.org, blink-re...@chromium.org, ios-revie...@chromium.org, jophba...@chromium.org, chrome-intelligence-te...@google.com, extension...@chromium.org, ortuno...@chromium.org, tmartino+tran...@chromium.org, vakh+safe_br...@chromium.org, schedule...@chromium.org, philli...@chromium.org, yuzo+...@chromium.org, blink-rev...@chromium.org, christia...@chromium.org, kyungjunle...@google.com, alexmo...@chromium.org, asvitki...@chromium.org, blink-revi...@chromium.org, mfoltz+wa...@chromium.org, kinuko...@chromium.org, polard...@google.com, dullweb...@chromium.org, loyso...@chromium.org, dmurph+watc...@chromium.org, telemetr...@chromium.org, jdonnel...@chromium.org, kuragin+web-ap...@chromium.org, webap...@microsoft.com, japhet+...@chromium.org, asvitkine...@chromium.org, roblia...@chromium.org, trewin...@google.com, jatapiaro+wat...@google.com, mek+w...@chromium.org, creis...@chromium.org, nektar...@chromium.org, abigailbk...@google.com, jasonrobe...@google.com, srahim...@chromium.org, dtseng...@chromium.org, sloboda...@chromium.org, amraboelk...@chromium.org, xinghui...@chromium.org, dewitt...@chromium.org, webauthn...@chromium.org, chrome-intell...@chromium.org, mgiuca...@chromium.org, yhanada+...@chromium.org, aixba+wat...@chromium.org, gcasto+w...@chromium.org, marq+...@chromium.org, msrame...@chromium.org, michaelchec...@google.com, edgesto...@microsoft.com, omnibox-...@chromium.org, lens-chrome...@google.com, navigation...@chromium.org, aashna...@google.com, blink-revie...@chromium.org, enne...@chromium.org, mfoltz+wa...@chromium.org, blink-revie...@chromium.org and android-web...@chromium.org from reviewers of this change.

Commit message

[MAGI] Update jj_git expert with recent findings

Change-Id: If1021c737ea010c97fc4fe3a633af5f2ec9a52e3

Change diff

diff --git a/remoting/tools/magi-mode/personas/infra/jj_git.json b/remoting/tools/magi-mode/personas/infra/jj_git.json
index a5eff2f8..dcaaaf7 100644
--- a/remoting/tools/magi-mode/personas/infra/jj_git.json
+++ b/remoting/tools/magi-mode/personas/infra/jj_git.json
@@ -3,6 +3,8 @@
   "mandate": "Expert in jj on Git workflow, focusing on preserving Change-Ids and managing detached HEAD states.",
   "checklist": {
     "preserve_change_id": "Ensure `jj describe` does not overwrite the `Change-Id` footer when updating commit messages for Gerrit.",
-    "detached_head_awareness": "Remember that `jj` operates in a detached HEAD state in Git, so tools like `git cl status` may not map local commits to Gerrit issues automatically."
+    "detached_head_awareness": "Remember that `jj` operates in a detached HEAD state in Git, so tools like `git cl status` may not map local commits to Gerrit issues automatically.",
+    "sync_git_head": "Ensure Git `HEAD` is in sync with the `jj` parent commit before running `git cl upload` to avoid including unrelated changes in the diff.",
+    "avoid_no_squash": "Avoid `--no-squash` if it causes `git cl` to upload too many unrelated changes due to detached HEAD state."
   }
 }

Change information

Files:

• M remoting/tools/magi-mode/personas/infra/jj_git.json

Change size: XS

Delta: 1 file changed, 3 insertions(+), 1 deletion(-)

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: newchange

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: If1021c737ea010c97fc4fe3a633af5f2ec9a52e3

Gerrit-Change-Number: 7833647

Gerrit-PatchSet: 1

Gerrit-Owner: Joe Downing <joe...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: chromotin...@chromium.org