[blink] Migrate away from TestingPlatformSupportWithMockScheduler [chromium/src : main]

0 views
Skip to first unread message

Etienne Pierre-Doray (Gerrit)

unread,
Mar 30, 2026, 4:34:15 PM (3 days ago) Mar 30
to Kentaro Hara, Raphael Kubo da Costa, Chromium LUCI CQ, chromium...@chromium.org, Hongchan Choi, Nate Chapin, Dirk Schulze, Prashant Nevase, Stephen Chenney, Prashant Nevase, AyeAye, scheduler-...@chromium.org, chikamu...@chromium.org, dom+...@chromium.org, hiroshig...@chromium.org, kouhei...@chromium.org, blink-revie...@chromium.org, titoua...@chromium.org, ortuno...@chromium.org, blink-...@chromium.org, loading-re...@chromium.org, fuzzin...@chromium.org, web-schedulin...@chromium.org, loading...@chromium.org, fmalit...@chromium.org, blink-revi...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, video-networking...@google.com, blink-rev...@chromium.org, drott+bl...@chromium.org, gavinp...@chromium.org, fserb...@chromium.org, blink-reviews-p...@chromium.org
Attention needed from Kentaro Hara

Etienne Pierre-Doray voted and added 1 comment

Votes added by Etienne Pierre-Doray

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 25 (Latest):
Etienne Pierre-Doray . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:
  • Kentaro Hara
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7d284046d781af5f84867fe8abec809bbb91de59
Gerrit-Change-Number: 7703655
Gerrit-PatchSet: 25
Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Hongchan Choi <hong...@chromium.org>
Gerrit-CC: Michael Wilson <mjwi...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Prashant Nevase <pne...@microsoft.com>
Gerrit-CC: Prashant Nevase <pras...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Kentaro Hara <har...@chromium.org>
Gerrit-Comment-Date: Mon, 30 Mar 2026 20:34:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

AI Code Reviewer (Gerrit)

unread,
Mar 30, 2026, 4:35:03 PM (3 days ago) Mar 30
to Etienne Pierre-Doray, Kentaro Hara, Raphael Kubo da Costa, Chromium LUCI CQ, chromium...@chromium.org, Hongchan Choi, Nate Chapin, Dirk Schulze, Prashant Nevase, Stephen Chenney, Prashant Nevase, AyeAye, scheduler-...@chromium.org, chikamu...@chromium.org, dom+...@chromium.org, hiroshig...@chromium.org, kouhei...@chromium.org, blink-revie...@chromium.org, titoua...@chromium.org, ortuno...@chromium.org, blink-...@chromium.org, loading-re...@chromium.org, fuzzin...@chromium.org, web-schedulin...@chromium.org, loading...@chromium.org, fmalit...@chromium.org, blink-revi...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, video-networking...@google.com, blink-rev...@chromium.org, drott+bl...@chromium.org, gavinp...@chromium.org, fserb...@chromium.org, blink-reviews-p...@chromium.org
Attention needed from Kentaro Hara

AI Code Reviewer added 1 comment

File third_party/blink/renderer/platform/scheduler/test/task_environment.h
Line 42, Patchset 25 (Latest): scheduler::MainThreadSchedulerImpl* main_thread_scheduler() const {
AI Code Reviewer . unresolved

Blink Style Guide: Naming - Use 'CamelCase' for all function names. Please rename `main_thread_scheduler` to `MainThreadScheduler`.

To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **OK But Won't Fix**: reason | **Later**: b/<bug_id> | **Invalid:** reason


_This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent)._
_AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve._
_[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_

Open in Gerrit

Related details

Attention is currently required from:
  • Kentaro Hara
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I7d284046d781af5f84867fe8abec809bbb91de59
    Gerrit-Change-Number: 7703655
    Gerrit-PatchSet: 25
    Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
    Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
    Gerrit-CC: Hongchan Choi <hong...@chromium.org>
    Gerrit-CC: Michael Wilson <mjwi...@chromium.org>
    Gerrit-CC: Nate Chapin <jap...@chromium.org>
    Gerrit-CC: Prashant Nevase <pne...@microsoft.com>
    Gerrit-CC: Prashant Nevase <pras...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-CC: Stephen Chenney <sche...@chromium.org>
    Gerrit-Attention: Kentaro Hara <har...@chromium.org>
    Gerrit-Comment-Date: Mon, 30 Mar 2026 20:34:59 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Kentaro Hara (Gerrit)

    unread,
    Mar 30, 2026, 6:34:47 PM (3 days ago) Mar 30
    to Etienne Pierre-Doray, AI Code Reviewer, Raphael Kubo da Costa, Chromium LUCI CQ, chromium...@chromium.org, Hongchan Choi, Nate Chapin, Dirk Schulze, Prashant Nevase, Stephen Chenney, Prashant Nevase, AyeAye, scheduler-...@chromium.org, chikamu...@chromium.org, dom+...@chromium.org, hiroshig...@chromium.org, kouhei...@chromium.org, blink-revie...@chromium.org, titoua...@chromium.org, ortuno...@chromium.org, blink-...@chromium.org, loading-re...@chromium.org, fuzzin...@chromium.org, web-schedulin...@chromium.org, loading...@chromium.org, fmalit...@chromium.org, blink-revi...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, video-networking...@google.com, blink-rev...@chromium.org, drott+bl...@chromium.org, gavinp...@chromium.org, fserb...@chromium.org, blink-reviews-p...@chromium.org
    Attention needed from Etienne Pierre-Doray

    Kentaro Hara voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Etienne Pierre-Doray
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I7d284046d781af5f84867fe8abec809bbb91de59
    Gerrit-Change-Number: 7703655
    Gerrit-PatchSet: 25
    Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
    Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
    Gerrit-CC: Hongchan Choi <hong...@chromium.org>
    Gerrit-CC: Michael Wilson <mjwi...@chromium.org>
    Gerrit-CC: Nate Chapin <jap...@chromium.org>
    Gerrit-CC: Prashant Nevase <pne...@microsoft.com>
    Gerrit-CC: Prashant Nevase <pras...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-CC: Stephen Chenney <sche...@chromium.org>
    Gerrit-Attention: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Comment-Date: Mon, 30 Mar 2026 22:34:05 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Etienne Pierre-Doray (Gerrit)

    unread,
    Mar 30, 2026, 7:12:33 PM (3 days ago) Mar 30
    to Kentaro Hara, AI Code Reviewer, Raphael Kubo da Costa, Chromium LUCI CQ, chromium...@chromium.org, Hongchan Choi, Nate Chapin, Dirk Schulze, Prashant Nevase, Stephen Chenney, Prashant Nevase, AyeAye, scheduler-...@chromium.org, chikamu...@chromium.org, dom+...@chromium.org, hiroshig...@chromium.org, kouhei...@chromium.org, blink-revie...@chromium.org, titoua...@chromium.org, ortuno...@chromium.org, blink-...@chromium.org, loading-re...@chromium.org, fuzzin...@chromium.org, web-schedulin...@chromium.org, loading...@chromium.org, fmalit...@chromium.org, blink-revi...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, video-networking...@google.com, blink-rev...@chromium.org, drott+bl...@chromium.org, gavinp...@chromium.org, fserb...@chromium.org, blink-reviews-p...@chromium.org

    Etienne Pierre-Doray added 1 comment

    File third_party/blink/renderer/platform/scheduler/test/task_environment.h
    Line 42, Patchset 25 (Latest): scheduler::MainThreadSchedulerImpl* main_thread_scheduler() const {
    AI Code Reviewer . resolved

    Blink Style Guide: Naming - Use 'CamelCase' for all function names. Please rename `main_thread_scheduler` to `MainThreadScheduler`.

    To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
    **Done** | **OK But Won't Fix**: reason | **Later**: b/<bug_id> | **Invalid:** reason


    _This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent)._
    _AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve._
    _[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_

    Etienne Pierre-Doray

    Acknowledged; underscore is encouraged for accessors.

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I7d284046d781af5f84867fe8abec809bbb91de59
      Gerrit-Change-Number: 7703655
      Gerrit-PatchSet: 25
      Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
      Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
      Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>
      Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
      Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
      Gerrit-CC: Hongchan Choi <hong...@chromium.org>
      Gerrit-CC: Michael Wilson <mjwi...@chromium.org>
      Gerrit-CC: Nate Chapin <jap...@chromium.org>
      Gerrit-CC: Prashant Nevase <pne...@microsoft.com>
      Gerrit-CC: Prashant Nevase <pras...@chromium.org>
      Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
      Gerrit-CC: Stephen Chenney <sche...@chromium.org>
      Gerrit-Comment-Date: Mon, 30 Mar 2026 23:12:28 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
      satisfied_requirement
      open
      diffy

      Etienne Pierre-Doray (Gerrit)

      unread,
      Mar 30, 2026, 7:12:37 PM (3 days ago) Mar 30
      to Kentaro Hara, AI Code Reviewer, Raphael Kubo da Costa, Chromium LUCI CQ, chromium...@chromium.org, Hongchan Choi, Nate Chapin, Dirk Schulze, Prashant Nevase, Stephen Chenney, Prashant Nevase, AyeAye, scheduler-...@chromium.org, chikamu...@chromium.org, dom+...@chromium.org, hiroshig...@chromium.org, kouhei...@chromium.org, blink-revie...@chromium.org, titoua...@chromium.org, ortuno...@chromium.org, blink-...@chromium.org, loading-re...@chromium.org, fuzzin...@chromium.org, web-schedulin...@chromium.org, loading...@chromium.org, fmalit...@chromium.org, blink-revi...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, video-networking...@google.com, blink-rev...@chromium.org, drott+bl...@chromium.org, gavinp...@chromium.org, fserb...@chromium.org, blink-reviews-p...@chromium.org

      Etienne Pierre-Doray voted Commit-Queue+2

      Commit-Queue+2
      Gerrit-Comment-Date: Mon, 30 Mar 2026 23:12:31 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      Mar 30, 2026, 7:51:13 PM (3 days ago) Mar 30
      to Etienne Pierre-Doray, Kentaro Hara, AI Code Reviewer, Raphael Kubo da Costa, chromium...@chromium.org, Hongchan Choi, Nate Chapin, Dirk Schulze, Prashant Nevase, Stephen Chenney, Prashant Nevase, AyeAye, scheduler-...@chromium.org, chikamu...@chromium.org, dom+...@chromium.org, hiroshig...@chromium.org, kouhei...@chromium.org, blink-revie...@chromium.org, titoua...@chromium.org, ortuno...@chromium.org, blink-...@chromium.org, loading-re...@chromium.org, fuzzin...@chromium.org, web-schedulin...@chromium.org, loading...@chromium.org, fmalit...@chromium.org, blink-revi...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, video-networking...@google.com, blink-rev...@chromium.org, drott+bl...@chromium.org, gavinp...@chromium.org, fserb...@chromium.org, blink-reviews-p...@chromium.org

      Chromium LUCI CQ submitted the change

      Change information

      Commit message:
      [blink] Migrate away from TestingPlatformSupportWithMockScheduler

      This CL replaces all of TestingPlatformSupportWithMockScheduler by
      TestingPlatformSupport + TaskEnvironment in blink, because
      TestingPlatformSupportWithMockScheduler relies on (deprecated)
      ThreadControllerImpl to run the scheduler on top of another task runner.
      This adjust scheduler control (e.g. RunUntilIdle) somewhat mechanically.

      Why not add just TaskEnvironment in
      TestingPlatformSupportWithMockScheduler: TaskEnvironment doesn't support
      being nested; most tests using TestingPlatformSupportWithMockScheduler
      already have a TaskEnvironment. We could add TaskEnvironment inside
      TestingPlatformSupportWithMockScheduler and keep it in tests that don't
      otherwise have TaskEnvironment; but this is a minority, so for
      simplicity this CL makes sure every tests has a TaskEnvironment.

      This also adds a TaskEnvironmentWithMainThreadScheduler that doesn't
      instantiate a full Blink Main Thread for blink_platform_unittests that
      doesn't support it.
      Bug: 40881604
      Change-Id: I7d284046d781af5f84867fe8abec809bbb91de59
      Reviewed-by: Kentaro Hara <har...@chromium.org>
      Commit-Queue: Etienne Pierre-Doray <etie...@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#1607460}
      Files:
      • M third_party/blink/renderer/bindings/core/v8/script_streamer_test.cc
      • M third_party/blink/renderer/bindings/core/v8/v8_script_runner_test.cc
      • M third_party/blink/renderer/core/frame/local_frame_ukm_aggregator_test.cc
      • M third_party/blink/renderer/core/html/anchor_element_metrics_sender_test.cc
      • M third_party/blink/renderer/core/html/parser/html_document_parser_loading_test.cc
      • M third_party/blink/renderer/core/loader/anchor_element_interaction_test.cc
      • M third_party/blink/renderer/core/loader/interactive_detector_test.cc
      • M third_party/blink/renderer/core/loader/long_task_detector_test.cc
      • M third_party/blink/renderer/core/loader/resource/font_resource_test.cc
      • M third_party/blink/renderer/core/loader/resource/image_resource_test.cc
      • M third_party/blink/renderer/core/loader/resource/resource_loader_code_cache_test.cc
      • M third_party/blink/renderer/core/scheduler_integration_tests/throttling_test.cc
      • M third_party/blink/renderer/core/script/module_map_test.cc
      • M third_party/blink/renderer/core/script/module_record_resolver_impl_test.cc
      • M third_party/blink/renderer/core/script/script_runner_test.cc
      • M third_party/blink/renderer/core/scroll/scrollable_area_test.cc
      • M third_party/blink/renderer/core/scroll/scrollbar_theme_aura_test.cc
      • M third_party/blink/renderer/core/scroll/scrollbar_theme_overlay_test.cc
      • M third_party/blink/renderer/modules/canvas/canvas_fuzzer.cc
      • M third_party/blink/renderer/modules/peerconnection/thermal_resource_test.cc
      • M third_party/blink/renderer/platform/BUILD.gn
      • M third_party/blink/renderer/platform/audio/push_pull_fifo_multithread_test.cc
      • M third_party/blink/renderer/platform/graphics/bitmap_image_test.cc
      • M third_party/blink/renderer/platform/graphics/dark_mode_image_classifier_test.cc
      • M third_party/blink/renderer/platform/loader/fetch/memory_cache_correctness_test.cc
      • M third_party/blink/renderer/platform/loader/fetch/memory_cache_test.cc
      • M third_party/blink/renderer/platform/loader/fetch/raw_resource_test.cc
      • M third_party/blink/renderer/platform/loader/fetch/resource_loader_test.cc
      • M third_party/blink/renderer/platform/loader/fetch/resource_response_test.cc
      • M third_party/blink/renderer/platform/loader/fetch/resource_test.cc
      • M third_party/blink/renderer/platform/loader/fetch/url_loader/cached_metadata_handler_test.cc
      • M third_party/blink/renderer/platform/scheduler/BUILD.gn
      • A third_party/blink/renderer/platform/scheduler/test/task_environment.cc
      • A third_party/blink/renderer/platform/scheduler/test/task_environment.h
      • D third_party/blink/renderer/platform/testing/testing_platform_support_with_mock_scheduler.cc
      • D third_party/blink/renderer/platform/testing/testing_platform_support_with_mock_scheduler.h
      • M third_party/blink/renderer/platform/timer_test.cc
      Change size: XL
      Delta: 37 files changed, 591 insertions(+), 698 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Kentaro Hara
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I7d284046d781af5f84867fe8abec809bbb91de59
      Gerrit-Change-Number: 7703655
      Gerrit-PatchSet: 26
      Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
      Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>
      Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages