Cleanup: Remove histogram macros header includes in base [chromium/src : main]

0 views
Skip to first unread message

Alexei Svitkine (Gerrit)

unread,
Mar 26, 2026, 12:07:14 PM (7 days ago) Mar 26
to Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, Sadrul Chowdhury, Sean Maher, Thiabaud Engelbrecht, agriev...@chromium.org, asvitki...@chromium.org, chromiumme...@microsoft.com, fdoray...@chromium.org, gab+...@chromium.org, gavinp...@chromium.org, ios-r...@chromium.org, jessemcke...@google.com, lizeb...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, roblia...@chromium.org, scheduler...@chromium.org, security-...@chromium.org, torne...@chromium.org, yfriedm...@chromium.org
Attention needed from Daniel Cheng

Alexei Svitkine voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Cheng
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I619f7df3320a8bb7338b59123c2bb1815a366dbc
Gerrit-Change-Number: 7701735
Gerrit-PatchSet: 4
Gerrit-Owner: Alexei Svitkine <asvi...@chromium.org>
Gerrit-Reviewer: Alexei Svitkine <asvi...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
Gerrit-CC: Sean Maher <sp...@chromium.org>
Gerrit-CC: Thiabaud Engelbrecht <thia...@google.com>
Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
Gerrit-Comment-Date: Thu, 26 Mar 2026 16:07:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Daniel Cheng (Gerrit)

unread,
Mar 26, 2026, 1:26:43 PM (7 days ago) Mar 26
to Alexei Svitkine, Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, Sadrul Chowdhury, Sean Maher, Thiabaud Engelbrecht, agriev...@chromium.org, asvitki...@chromium.org, chromiumme...@microsoft.com, fdoray...@chromium.org, gab+...@chromium.org, gavinp...@chromium.org, ios-r...@chromium.org, jessemcke...@google.com, lizeb...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, roblia...@chromium.org, scheduler...@chromium.org, security-...@chromium.org, torne...@chromium.org, yfriedm...@chromium.org
Attention needed from Alexei Svitkine

Daniel Cheng voted

Code-Review+1
Commit-Queue+2
Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Alexei Svitkine
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I619f7df3320a8bb7338b59123c2bb1815a366dbc
Gerrit-Change-Number: 7701735
Gerrit-PatchSet: 4
Gerrit-Owner: Alexei Svitkine <asvi...@chromium.org>
Gerrit-Reviewer: Alexei Svitkine <asvi...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
Gerrit-CC: Sean Maher <sp...@chromium.org>
Gerrit-CC: Thiabaud Engelbrecht <thia...@google.com>
Gerrit-Attention: Alexei Svitkine <asvi...@chromium.org>
Gerrit-Comment-Date: Thu, 26 Mar 2026 17:26:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Mar 26, 2026, 1:29:46 PM (7 days ago) Mar 26
to Alexei Svitkine, Daniel Cheng, chromium...@chromium.org, Sadrul Chowdhury, Sean Maher, Thiabaud Engelbrecht, agriev...@chromium.org, asvitki...@chromium.org, chromiumme...@microsoft.com, fdoray...@chromium.org, gab+...@chromium.org, gavinp...@chromium.org, ios-r...@chromium.org, jessemcke...@google.com, lizeb...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, roblia...@chromium.org, scheduler...@chromium.org, security-...@chromium.org, torne...@chromium.org, yfriedm...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Cleanup: Remove histogram macros header includes in base
Bug: None
Change-Id: I619f7df3320a8bb7338b59123c2bb1815a366dbc
Reviewed-by: Daniel Cheng <dch...@chromium.org>
Auto-Submit: Alexei Svitkine <asvi...@chromium.org>
Owners-Override: Daniel Cheng <dch...@chromium.org>
Commit-Queue: Daniel Cheng <dch...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1605641}
Files:
  • M base/android/trace_event_binding.cc
  • M base/ios/scoped_critical_action.mm
  • M base/json/json_reader.cc
  • M base/memory/platform_shared_memory_region_android.cc
  • M base/memory/platform_shared_memory_region_posix.cc
  • M base/memory/platform_shared_memory_region_win.cc
  • M base/message_loop/message_pump_win.cc
  • M base/metrics/field_trial.cc
  • M base/metrics/histogram_base.cc
  • M base/metrics/persistent_histogram_allocator.cc
  • M base/metrics/persistent_sample_map.cc
  • M base/native_library_win.cc
  • M base/profiler/metadata_recorder.cc
  • M base/profiler/native_unwinder_android.cc
  • M base/rand_util_posix.cc
  • M base/task/cancelable_task_tracker.cc
  • M base/task/sequence_manager/task_queue_impl.cc
  • M base/task/sequence_manager/thread_controller.cc
  • M base/task/sequence_manager/thread_controller_with_message_pump_impl.cc
  • M base/task/thread_pool/task_tracker.cc
  • M base/task/thread_pool/thread_group_impl.cc
  • M base/threading/platform_thread_win.cc
Change size: S
Delta: 22 files changed, 4 insertions(+), 22 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Daniel Cheng
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I619f7df3320a8bb7338b59123c2bb1815a366dbc
Gerrit-Change-Number: 7701735
Gerrit-PatchSet: 5
Gerrit-Owner: Alexei Svitkine <asvi...@chromium.org>
Gerrit-Reviewer: Alexei Svitkine <asvi...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages