[Fuzzing] Add FuzzTest's LLVM wrapper to "fuzzer_test" template [chromium/src : main]
0 views
Skip to first unread message
Alex Kallam (Gerrit)
May 4, 2026, 9:13:12 PM (7 days ago) May 4
to Enterprise Policy Reviews, Titouan Rigoudy, Code Review Nudger, Chromium LUCI CQ, Giovanni Ortuno Urquidi, android-bu...@system.gserviceaccount.com, mfoltz+wa...@chromium.org, ajayramamurt...@google.com, scheduler-...@chromium.org, chikamu...@chromium.org, kinuko...@chromium.org, feature-me...@chromium.org, pushi+wa...@google.com, net-r...@chromium.org, ios-r...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, andysjl...@chromium.org, nwoked...@chromium.org, chromiumme...@microsoft.com, pdf-r...@chromium.org, xinghui...@chromium.org, blink-...@chromium.org, asvitki...@chromium.org, gcasto+w...@chromium.org, crisrael+...@google.com, zackha...@chromium.org, jonmann+w...@chromium.org, jackshira+...@google.com, browser-comp...@chromium.org, tmartino+tran...@chromium.org, cfredri...@chromium.org, ortuno...@chromium.org, titoua...@chromium.org
Attention needed from Titouan Rigoudy
Alex Kallam added 2 comments![]( "Open in Gerrit")
File chrome/browser/first_party_sets/BUILD.gn
Line 153, Patchset 6:
exclude_wrapper = trueTitouan Rigoudy . resolved
Alex KallamWe should add a comment and/or a TODO here.
I have added a comment here and in all of the manual exclusions that were tracked in crrev.com/c/7804294 and merged into this CL.
File testing/libfuzzer/fuzzer_test.gni
Line 100, Patchset 6:
# because they are not supported by the wrapper and will be manuallyTitouan Rigoudy . resolved
Alex Kallam```suggestion
# because they are not supported by the wrapper and will be manually
```
Done
Related details
Attention is currently required from:
- Titouan Rigoudy
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Titouan Rigoudy (Gerrit)
May 5, 2026, 5:19:43 AM (6 days ago) May 5
to Alex Kallam, Enterprise Policy Reviews, Code Review Nudger, Chromium LUCI CQ, Giovanni Ortuno Urquidi, android-bu...@system.gserviceaccount.com, mfoltz+wa...@chromium.org, ajayramamurt...@google.com, scheduler-...@chromium.org, chikamu...@chromium.org, kinuko...@chromium.org, feature-me...@chromium.org, pushi+wa...@google.com, net-r...@chromium.org, ios-r...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, andysjl...@chromium.org, nwoked...@chromium.org, chromiumme...@microsoft.com, pdf-r...@chromium.org, xinghui...@chromium.org, blink-...@chromium.org, asvitki...@chromium.org, gcasto+w...@chromium.org, crisrael+...@google.com, zackha...@chromium.org, jonmann+w...@chromium.org, jackshira+...@google.com, browser-comp...@chromium.org, tmartino+tran...@chromium.org, cfredri...@chromium.org, ortuno...@chromium.org, titoua...@chromium.org
Attention needed from Alex Kallam
Titouan Rigoudy voted and added 2 comments![]( "Open in Gerrit")
Votes added by Titouan Rigoudy
| Code-Review | +1 |
2 comments
Patchset-level comments
File-level comment, Patchset 11 (Latest):
Titouan Rigoudy . resolved
Still LGTM with one last optional nit.
File testing/libfuzzer/fuzzer_test.gni
Line 32, Patchset 11 (Latest):
# - exclude_wrapper - do not apply the llvm wrapper for centipede buildsTitouan Rigoudy . unresolved
[Optional] Now that I see what this looks like on random `fuzzer_test` targets, I find `exclude_wrapper` to be quite obtuse. Consider flipping the bit and renaming to `is_fuzztest_compatible`, which would be nicely consistent with `is_fuzzilli_compatible`.
Related details
Attention is currently required from:
- Alex Kallam
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Kallam (Gerrit)
11:33 AM (3 hours ago) 11:33 AM
to Titouan Rigoudy, Enterprise Policy Reviews, Code Review Nudger, Chromium LUCI CQ, Giovanni Ortuno Urquidi, android-bu...@system.gserviceaccount.com, grt+...@chromium.org, mfoltz+wa...@chromium.org, ajayramamurt...@google.com, scheduler-...@chromium.org, chikamu...@chromium.org, kinuko...@chromium.org, feature-me...@chromium.org, pushi+wa...@google.com, net-r...@chromium.org, ios-r...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, andysjl...@chromium.org, nwoked...@chromium.org, chromiumme...@microsoft.com, pdf-r...@chromium.org, xinghui...@chromium.org, blink-...@chromium.org, asvitki...@chromium.org, gcasto+w...@chromium.org, crisrael+...@google.com, zackha...@chromium.org, jonmann+w...@chromium.org, jackshira+...@google.com, browser-comp...@chromium.org, tmartino+tran...@chromium.org, cfredri...@chromium.org, ortuno...@chromium.org, titoua...@chromium.org
Alex Kallam voted and added 1 comment![]( "Open in Gerrit")
Votes added by Alex Kallam
| Commit-Queue | +1 |
1 comment
File testing/libfuzzer/fuzzer_test.gni
Line 32, Patchset 11:
# - exclude_wrapper - do not apply the llvm wrapper for centipede buildsTitouan Rigoudy . resolved
[Optional] Now that I see what this looks like on random `fuzzer_test` targets, I find `exclude_wrapper` to be quite obtuse. Consider flipping the bit and renaming to `is_fuzztest_compatible`, which would be nicely consistent with `is_fuzzilli_compatible`.
Alex Kallam
Done. Hopefully this workaround is short-lived enough that the lack of `is_fuzztest_compatible = true` on other targets doesn't cause confusion.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages