[cc/scheduler] Factor out webview state machine from scheduler [chromium/src : main]

0 views
Skip to first unread message

Jonathan Ross (Gerrit)

unread,
Feb 19, 2026, 2:54:13 PM (3 days ago) Feb 19
to Stacy Gaikovaia, Chromium LUCI CQ, chromium...@chromium.org, cc-...@chromium.org, schedule...@chromium.org
Attention needed from Stacy Gaikovaia

Jonathan Ross added 4 comments

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Jonathan Ross . resolved

Conceptually sgtm

File cc/scheduler/scheduler_state_machine.cc
Line 669, Patchset 1 (Latest): if (CanSendBeginMainFrameWhileIdle()) {
Jonathan Ross . unresolved

This is mis-named, as this prevents sending BMF. It's more `ShouldBeginMainFrameWhenIdle`

File cc/scheduler/webview_scheduler_state_machine.h
Line 19, Patchset 1 (Latest): // TODO(gaiko): Put functions here
Jonathan Ross . unresolved

Nit: crbug link

File cc/scheduler/webview_scheduler_state_machine.cc
Line 32, Patchset 1 (Latest): if (did_invalidate_layer_tree_frame_sink_) {
Jonathan Ross . unresolved

Future looking, we could move this var into this class in follow ups

Open in Gerrit

Related details

Attention is currently required from:
  • Stacy Gaikovaia
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic301da56365debf2b677fc83a2023e1122065c5f
Gerrit-Change-Number: 7595174
Gerrit-PatchSet: 1
Gerrit-Owner: Stacy Gaikovaia <ga...@google.com>
Gerrit-Reviewer: Jonathan Ross <jon...@chromium.org>
Gerrit-Reviewer: Stacy Gaikovaia <ga...@google.com>
Gerrit-Attention: Stacy Gaikovaia <ga...@google.com>
Gerrit-Comment-Date: Thu, 19 Feb 2026 19:54:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Stacy Gaikovaia (Gerrit)

unread,
Feb 19, 2026, 3:12:37 PM (3 days ago) Feb 19
to Jonathan Ross, Chromium LUCI CQ, chromium...@chromium.org, cc-...@chromium.org, schedule...@chromium.org
Attention needed from Jonathan Ross

Stacy Gaikovaia voted and added 3 comments

Votes added by Stacy Gaikovaia

Commit-Queue+2

3 comments

File cc/scheduler/scheduler_state_machine.cc
Line 669, Patchset 1: if (CanSendBeginMainFrameWhileIdle()) {
Jonathan Ross . resolved

This is mis-named, as this prevents sending BMF. It's more `ShouldBeginMainFrameWhenIdle`

Stacy Gaikovaia

Changed to `ShouldBeginMainFrameWhenIdle`

File cc/scheduler/webview_scheduler_state_machine.h
Line 19, Patchset 1: // TODO(gaiko): Put functions here
Jonathan Ross . resolved

Nit: crbug link

Stacy Gaikovaia

Removed!

File cc/scheduler/webview_scheduler_state_machine.cc
Line 32, Patchset 1: if (did_invalidate_layer_tree_frame_sink_) {
Jonathan Ross . resolved

Future looking, we could move this var into this class in follow ups

Stacy Gaikovaia
Open in Gerrit

Related details

Attention is currently required from:
  • Jonathan Ross
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic301da56365debf2b677fc83a2023e1122065c5f
    Gerrit-Change-Number: 7595174
    Gerrit-PatchSet: 2
    Gerrit-Owner: Stacy Gaikovaia <ga...@google.com>
    Gerrit-Reviewer: Jonathan Ross <jon...@chromium.org>
    Gerrit-Reviewer: Stacy Gaikovaia <ga...@google.com>
    Gerrit-Attention: Jonathan Ross <jon...@chromium.org>
    Gerrit-Comment-Date: Thu, 19 Feb 2026 20:12:31 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Jonathan Ross <jon...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Jonathan Ross (Gerrit)

    unread,
    Feb 19, 2026, 3:48:54 PM (2 days ago) Feb 19
    to Stacy Gaikovaia, Chromium LUCI CQ, chromium...@chromium.org, cc-...@chromium.org, schedule...@chromium.org
    Attention needed from Stacy Gaikovaia

    Jonathan Ross voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Stacy Gaikovaia
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ic301da56365debf2b677fc83a2023e1122065c5f
      Gerrit-Change-Number: 7595174
      Gerrit-PatchSet: 2
      Gerrit-Owner: Stacy Gaikovaia <ga...@google.com>
      Gerrit-Reviewer: Jonathan Ross <jon...@chromium.org>
      Gerrit-Reviewer: Stacy Gaikovaia <ga...@google.com>
      Gerrit-Attention: Stacy Gaikovaia <ga...@google.com>
      Gerrit-Comment-Date: Thu, 19 Feb 2026 20:48:49 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Stacy Gaikovaia (Gerrit)

      unread,
      Feb 19, 2026, 3:49:06 PM (2 days ago) Feb 19
      to Jonathan Ross, Chromium LUCI CQ, chromium...@chromium.org, cc-...@chromium.org, schedule...@chromium.org

      Stacy Gaikovaia voted Commit-Queue+2

      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ic301da56365debf2b677fc83a2023e1122065c5f
      Gerrit-Change-Number: 7595174
      Gerrit-PatchSet: 2
      Gerrit-Owner: Stacy Gaikovaia <ga...@google.com>
      Gerrit-Reviewer: Jonathan Ross <jon...@chromium.org>
      Gerrit-Reviewer: Stacy Gaikovaia <ga...@google.com>
      Gerrit-Comment-Date: Thu, 19 Feb 2026 20:49:01 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages