Revert "[task] Integrate SequenceManager "best effort" into ThreadType mapping" [chromium/src : main]
0 views
Skip to first unread message
Mei Liang (Gerrit)
Apr 27, 2026, 6:40:15 PM (14 days ago) Apr 27
to rubber-...@appspot.gserviceaccount.com, Gabriel Charette, Chromium LUCI CQ, Etienne Pierre-Doray, android-bu...@system.gserviceaccount.com, Code Review Nudger, chromium...@chromium.org, scheduler...@chromium.org
Attention needed from Etienne Pierre-Doray, Gabriel Charette and Joe Mason
Mei Liang voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Commit-Queue | +1 |
| Owners-Override | +1 |
Related details
Attention is currently required from:
- Etienne Pierre-Doray
- Gabriel Charette
- Joe Mason
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
rubber-stamper@appspot.gserviceaccount.com (Gerrit)
Apr 27, 2026, 6:40:22 PM (14 days ago) Apr 27
to Mei Liang, Gabriel Charette, Chromium LUCI CQ, Etienne Pierre-Doray, android-bu...@system.gserviceaccount.com, Code Review Nudger, chromium...@chromium.org, scheduler...@chromium.org
Attention needed from Etienne Pierre-Doray, Gabriel Charette and Joe Mason
rubber-...@appspot.gserviceaccount.com voted![]( "Open in Gerrit")
| Bot-Commit | +1 |
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Etienne Pierre-Doray
- Gabriel Charette
- Joe Mason
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 27, 2026, 6:40:50 PM (14 days ago) Apr 27
to Mei Liang, rubber-...@appspot.gserviceaccount.com, Gabriel Charette, Etienne Pierre-Doray, android-bu...@system.gserviceaccount.com, Code Review Nudger, chromium...@chromium.org, scheduler...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Revert "[task] Integrate SequenceManager "best effort" into ThreadType mapping"
This reverts commit 0c91a42a7765ab67ed253908362e3e25087ab46a.
Reason for revert: Tree is broken, https://ci.chromium.org/ui/p/chromium/bisection/compile-analysis/b/8683330511251170193
Original change's description:
> [task] Integrate SequenceManager "best effort" into ThreadType mapping
>
> This CL integrates concept of SequenceManager best effort task runner
> into ThreadType mapping, allowing for multiple TaskPriority to be considered "best effort".
> This also removes unused GetCurrentBestEffort(), since it would otherwise need to be updated.
>
> Bug: 495439030
> Change-Id: I3c71c4b81ea05a767868d0f07076e0760fe4dec6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7736792
> Reviewed-by: Gabriel Charette <g...@chromium.org>
> Reviewed-by: Joe Mason <joenot...@google.com>
> Commit-Queue: Etienne Pierre-Doray <etie...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1621347}
Bug: 495439030
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I2e5865f536e07cf6a8adea3a9e44182b41883233
Owners-Override: Mei Liang <meil...@chromium.org>
Auto-Submit: Mei Liang <meil...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1621359}
Files:
- M base/task/sequence_manager/sequence_manager_impl.cc
- M base/task/sequence_manager/sequence_manager_impl.h
- M base/task/sequence_manager/sequence_manager_impl_unittest.cc
- M base/task/sequenced_task_runner.cc
- M base/task/sequenced_task_runner.h
- M base/task/sequenced_task_runner_unittest.cc
- M base/task/single_thread_task_runner.cc
- M base/task/single_thread_task_runner.h
- M base/task/single_thread_task_runner_unittest.cc
- M base/test/task_environment.cc
- M base/test/task_environment.h
Change size: L
Delta: 11 files changed, 571 insertions(+), 42 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: Bot-Commit+1 by rubber-...@appspot.gserviceaccount.com
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gabriel Charette (Gerrit)
Apr 27, 2026, 6:40:58 PM (14 days ago) Apr 27
to Mei Liang, Gabriel Charette, Chromium LUCI CQ, rubber-...@appspot.gserviceaccount.com, Etienne Pierre-Doray, android-bu...@system.gserviceaccount.com, Code Review Nudger, chromium...@chromium.org, scheduler...@chromium.org
Attention needed from Mei Liang
Gabriel Charette voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Mei Liang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mei Liang (Gerrit)
Apr 27, 2026, 6:41:39 PM (14 days ago) Apr 27
to Chromium LUCI CQ, Gabriel Charette, rubber-...@appspot.gserviceaccount.com, Etienne Pierre-Doray, android-bu...@system.gserviceaccount.com, Code Review Nudger, chromium...@chromium.org, scheduler...@chromium.org
Attention needed from Mei Liang
Mei Liang has created a revert of this change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Mei Liang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mei Liang (Gerrit)
Apr 27, 2026, 6:48:48 PM (14 days ago) Apr 27
to Chromium LUCI CQ, Gabriel Charette, rubber-...@appspot.gserviceaccount.com, Etienne Pierre-Doray, android-bu...@system.gserviceaccount.com, Code Review Nudger, chromium...@chromium.org, scheduler...@chromium.org
Mei Liang added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Mei Liang . resolved
There's a new usage of GetCurrentBestEffort in https://chromium-review.git.corp.google.com/c/chromium/src/+/7783493
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages