[task] Expose internal::GetCurrentTaskImportance() - apply missing comments. [chromium/src : main]

0 views
Skip to first unread message

Etienne Pierre-Doray (Gerrit)

unread,
Feb 12, 2026, 9:07:18 AM (10 days ago) Feb 12
to Francois Pierre Doray, Jerome Jiang, Mirko Bonadei, AyeAye, chromium...@chromium.org, fgal...@chromium.org, mar...@chromium.org, penghuan...@chromium.org, fuzzin...@chromium.org, net-r...@chromium.org, chrome-intelligence-te...@google.com, jz...@chromium.org, cblume...@chromium.org, chrome-intell...@chromium.org, blink-...@chromium.org, chikamu...@chromium.org, fdoray...@chromium.org, gab+...@chromium.org, jessemcke...@google.com, kinuko...@chromium.org, network-ser...@chromium.org, roblia...@chromium.org, scheduler...@chromium.org, scheduler-...@chromium.org, scheduler-b...@chromium.org
Attention needed from Francois Pierre Doray

Etienne Pierre-Doray added 1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Etienne Pierre-Doray . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:
  • Francois Pierre Doray
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie379f81a1e6fc68c4f5fd7147e6bdb6c0f724639
Gerrit-Change-Number: 7571842
Gerrit-PatchSet: 4
Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
Gerrit-CC: Jerome Jiang <ji...@chromium.org>
Gerrit-CC: Mirko Bonadei <mbon...@chromium.org>
Gerrit-Attention: Francois Pierre Doray <fdo...@chromium.org>
Gerrit-Comment-Date: Thu, 12 Feb 2026 14:07:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Francois Pierre Doray (Gerrit)

unread,
Feb 12, 2026, 10:05:13 AM (10 days ago) Feb 12
to Etienne Pierre-Doray, Chromium LUCI CQ, Jerome Jiang, Mirko Bonadei, AyeAye, chromium...@chromium.org, fgal...@chromium.org, mar...@chromium.org, penghuan...@chromium.org, fuzzin...@chromium.org, net-r...@chromium.org, chrome-intelligence-te...@google.com, jz...@chromium.org, cblume...@chromium.org, chrome-intell...@chromium.org, blink-...@chromium.org, chikamu...@chromium.org, fdoray...@chromium.org, gab+...@chromium.org, jessemcke...@google.com, kinuko...@chromium.org, network-ser...@chromium.org, roblia...@chromium.org, scheduler...@chromium.org, scheduler-...@chromium.org, scheduler-b...@chromium.org
Attention needed from Etienne Pierre-Doray

Francois Pierre Doray voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Etienne Pierre-Doray
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie379f81a1e6fc68c4f5fd7147e6bdb6c0f724639
    Gerrit-Change-Number: 7571842
    Gerrit-PatchSet: 5
    Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
    Gerrit-CC: Jerome Jiang <ji...@chromium.org>
    Gerrit-CC: Mirko Bonadei <mbon...@chromium.org>
    Gerrit-Attention: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Comment-Date: Thu, 12 Feb 2026 15:05:05 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Francois Pierre Doray (Gerrit)

    unread,
    Feb 12, 2026, 10:09:52 AM (10 days ago) Feb 12
    to Etienne Pierre-Doray, Hayato Ito, Chromium LUCI CQ, Jerome Jiang, Mirko Bonadei, AyeAye, chromium...@chromium.org, fgal...@chromium.org, mar...@chromium.org, penghuan...@chromium.org, fuzzin...@chromium.org, net-r...@chromium.org, chrome-intelligence-te...@google.com, jz...@chromium.org, cblume...@chromium.org, chrome-intell...@chromium.org, blink-...@chromium.org, chikamu...@chromium.org, fdoray...@chromium.org, gab+...@chromium.org, jessemcke...@google.com, kinuko...@chromium.org, network-ser...@chromium.org, roblia...@chromium.org, scheduler...@chromium.org, scheduler-...@chromium.org, scheduler-b...@chromium.org
    Attention needed from Etienne Pierre-Doray and Hayato Ito

    Francois Pierre Doray voted and added 1 comment

    Votes added by Francois Pierre Doray

    Commit-Queue+2
    Owners-Override+1

    1 comment

    Patchset-level comments
    File-level comment, Patchset 5 (Latest):
    Francois Pierre Doray . resolved

    OO+1 (this is applying comments that should have been applied as part of another CL)

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Etienne Pierre-Doray
    • Hayato Ito
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie379f81a1e6fc68c4f5fd7147e6bdb6c0f724639
    Gerrit-Change-Number: 7571842
    Gerrit-PatchSet: 5
    Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
    Gerrit-Reviewer: Hayato Ito <hay...@chromium.org>
    Gerrit-CC: Jerome Jiang <ji...@chromium.org>
    Gerrit-CC: Mirko Bonadei <mbon...@chromium.org>
    Gerrit-Attention: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Attention: Hayato Ito <hay...@chromium.org>
    Gerrit-Comment-Date: Thu, 12 Feb 2026 15:09:46 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Feb 12, 2026, 10:35:55 AM (10 days ago) Feb 12
    to Etienne Pierre-Doray, Francois Pierre Doray, Hayato Ito, Jerome Jiang, Mirko Bonadei, AyeAye, chromium...@chromium.org, fgal...@chromium.org, mar...@chromium.org, penghuan...@chromium.org, fuzzin...@chromium.org, net-r...@chromium.org, chrome-intelligence-te...@google.com, jz...@chromium.org, cblume...@chromium.org, chrome-intell...@chromium.org, blink-...@chromium.org, chikamu...@chromium.org, fdoray...@chromium.org, gab+...@chromium.org, jessemcke...@google.com, kinuko...@chromium.org, network-ser...@chromium.org, roblia...@chromium.org, scheduler...@chromium.org, scheduler-...@chromium.org, scheduler-b...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [task] Expose internal::GetCurrentTaskImportance() - apply missing comments.

    Follow-up to
    https://chromium-review.googlesource.com/c/chromium/src/+/7521684
    I failed to upload the latest patch before submitting. This CL
    applies the comment from the latest patch.
    Change-Id: Ie379f81a1e6fc68c4f5fd7147e6bdb6c0f724639
    Reviewed-by: Francois Pierre Doray <fdo...@chromium.org>
    Owners-Override: Francois Pierre Doray <fdo...@chromium.org>
    Commit-Queue: Francois Pierre Doray <fdo...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1583965}
    Files:
    • M base/task/sequence_manager/sequence_manager.h
    • M base/task/sequence_manager/thread_controller_with_message_pump_impl.cc
    • M base/task/thread_pool/task_tracker.h
    • M base/task/thread_type.h
    • M content/browser/scheduler/browser_task_priority.cc
    • M services/network/public/cpp/network_service_task_priority.cc
    • M third_party/blink/renderer/platform/scheduler/common/task_priority.cc
    Change size: S
    Delta: 7 files changed, 16 insertions(+), 23 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Francois Pierre Doray
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie379f81a1e6fc68c4f5fd7147e6bdb6c0f724639
    Gerrit-Change-Number: 7571842
    Gerrit-PatchSet: 6
    Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
    Gerrit-Reviewer: Hayato Ito <hay...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages