[tracing] Migrate legacy TRACE_EVENT_OBJECT macros in base [chromium/src : main]
0 views
Skip to first unread message
Etienne Pierre-Doray (Gerrit)
May 1, 2026, 2:52:47 PM (10 days ago) May 1
to Gabriel Charette, chromium...@chromium.org, scheduler...@chromium.org, spang...@chromium.org, wfh+...@chromium.org, tracing...@chromium.org
Attention needed from Gabriel Charette
Etienne Pierre-Doray has uploaded the change for review![]( "Open in Gerrit")
Etienne Pierre-Doray would like Gabriel Charette to review this change.
Commit message
[tracing] Migrate legacy TRACE_EVENT_OBJECT macros in base
This CL replaces legacy TRACE_EVENT_OBJECT macros (e.g., TRACE_EVENT_OBJECT_DELETED_WITH_ID)
with modern TRACE_EVENT_INSTANT macros. These events are now emitted with more explicit
event names to provide better context, utilizing perfetto::TerminatingFlow where
applicable to maintain flow tracking.
This CL was uploaded by git cl split.
R=g...@chromium.org
Bug: 432427382
Change-Id: I61729216d0b038ad85da79274c89aa6319f095ce
Change diff
Change information
Files:
- M base/task/sequence_manager/sequence_manager_impl.cc
- M base/trace_event/trace_event.h
- M base/trace_event/trace_event_unittest.cc
Change size: M
Delta: 3 files changed, 14 insertions(+), 56 deletions(-)
Related details
Attention is currently required from:
- Gabriel Charette
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gabriel Charette (Gerrit)
May 1, 2026, 2:56:06 PM (10 days ago) May 1
to Etienne Pierre-Doray, Gabriel Charette, chromium...@chromium.org, scheduler...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray
Gabriel Charette voted and added 1 comment![]( "Open in Gerrit")
Votes added by Gabriel Charette
| Code-Review | +1 |
1 comment
Commit Message
Line 14, Patchset 1 (Latest):
This CL was uploaded by git cl split.Gabriel Charette . unresolved
Was it? Seems pretty precise
Related details
Attention is currently required from:
- Etienne Pierre-Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
May 4, 2026, 1:57:27 PM (7 days ago) May 4
to Chromium LUCI CQ, Gabriel Charette, chromium...@chromium.org, scheduler...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Gabriel Charette
Etienne Pierre-Doray added 1 comment![]( "Open in Gerrit")
Commit Message
Line 14, Patchset 1 (Latest):
This CL was uploaded by git cl split.Gabriel Charette . resolved
Was it? Seems pretty precise
Etienne Pierre-Doray
It was, but the base/ parts are mostly cleanup meant to happen after the other CLs landed (so I temporarily set it as WIP)
Those other CLs now landed, so we go land this, but the fact that it was extracted with cl split isn't super relevant.
Related details
Attention is currently required from:
- Gabriel Charette
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
May 4, 2026, 1:57:44 PM (7 days ago) May 4
to Chromium LUCI CQ, Gabriel Charette, chromium...@chromium.org, scheduler...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Gabriel Charette
Etienne Pierre-Doray voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Gabriel Charette
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
May 4, 2026, 4:07:06 PM (7 days ago) May 4
to Etienne Pierre-Doray, Gabriel Charette, chromium...@chromium.org, scheduler...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[tracing] Migrate legacy TRACE_EVENT_OBJECT macros in base
This CL replaces legacy TRACE_EVENT_OBJECT macros (e.g., TRACE_EVENT_OBJECT_DELETED_WITH_ID)
with modern TRACE_EVENT_INSTANT macros. These events are now emitted with more explicit
event names to provide better context, utilizing perfetto::TerminatingFlow where
applicable to maintain flow tracking.
This CL was uploaded by git cl split.
Bug: 432427382
Change-Id: I61729216d0b038ad85da79274c89aa6319f095ce
Reviewed-by: Gabriel Charette <g...@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etie...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1624884}
Files:
- M base/task/sequence_manager/sequence_manager_impl.cc
- M base/trace_event/trace_event.h
- M base/trace_event/trace_event_unittest.cc
Change size: M
Delta: 3 files changed, 14 insertions(+), 56 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Gabriel Charette
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages