[task] Remove id from ThreadPoolSingleThread thread name [chromium/src : main]
0 views
Skip to first unread message
Etienne Pierre-Doray (Gerrit)
May 5, 2026, 1:55:03 PM (6 days ago) May 5
to Gabriel Charette, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, fdoray...@chromium.org, gab+...@chromium.org, jessemcke...@google.com, roblia...@chromium.org, scheduler...@chromium.org
Attention needed from Gabriel Charette
Etienne Pierre-Doray voted and added 1 comment![]( "Open in Gerrit")
Votes added by Etienne Pierre-Doray
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Gabriel Charette
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gabriel Charette (Gerrit)
May 5, 2026, 1:59:12 PM (6 days ago) May 5
to Etienne Pierre-Doray, Gabriel Charette, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, fdoray...@chromium.org, gab+...@chromium.org, jessemcke...@google.com, roblia...@chromium.org, scheduler...@chromium.org
Attention needed from Etienne Pierre-Doray
Gabriel Charette voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Etienne Pierre-Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gabriel Charette (Gerrit)
May 5, 2026, 2:00:01 PM (6 days ago) May 5
to Etienne Pierre-Doray, Gabriel Charette, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, fdoray...@chromium.org, gab+...@chromium.org, jessemcke...@google.com, roblia...@chromium.org, scheduler...@chromium.org
Attention needed from Etienne Pierre-Doray
Gabriel Charette added 1 comment![]( "Open in Gerrit")
File base/task/thread_pool/pooled_single_thread_task_runner_manager_unittest.cc
Line 383, Patchset 3 (Latest):
::testing::MatchesRegex(Gabriel Charette . unresolved
Can do simpler than Regex match now.
Related details
Attention is currently required from:
- Etienne Pierre-Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
May 5, 2026, 2:35:55 PM (6 days ago) May 5
to Gabriel Charette, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, fdoray...@chromium.org, gab+...@chromium.org, jessemcke...@google.com, roblia...@chromium.org, scheduler...@chromium.org
Etienne Pierre-Doray added 1 comment![]( "Open in Gerrit")
File base/task/thread_pool/pooled_single_thread_task_runner_manager_unittest.cc
Can do simpler than Regex match now.
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
May 5, 2026, 2:35:57 PM (6 days ago) May 5
to Gabriel Charette, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, fdoray...@chromium.org, gab+...@chromium.org, jessemcke...@google.com, roblia...@chromium.org, scheduler...@chromium.org
Etienne Pierre-Doray voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
May 5, 2026, 6:57:16 PM (6 days ago) May 5
to Etienne Pierre-Doray, Gabriel Charette, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, fdoray...@chromium.org, gab+...@chromium.org, jessemcke...@google.com, roblia...@chromium.org, scheduler...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
3 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: base/task/thread_pool/pooled_single_thread_task_runner_manager_unittest.cc
Insertions: 8, Deletions: 9.
@@ -307,17 +307,17 @@
? ""
: "Shared");
const std::string background =
- "^ThreadPoolSingleThread" + maybe_shared + "Background$";
+ "ThreadPoolSingleThread" + maybe_shared + "Background";
const std::string utility =
- "^ThreadPoolSingleThread" + maybe_shared + "Utility$";
+ "ThreadPoolSingleThread" + maybe_shared + "Utility";
const std::string foreground =
- "^ThreadPoolSingleThread" + maybe_shared + "Foreground$";
+ "ThreadPoolSingleThread" + maybe_shared + "Foreground";
const std::string background_blocking =
- "^ThreadPoolSingleThread" + maybe_shared + "BackgroundBlocking$";
+ "ThreadPoolSingleThread" + maybe_shared + "BackgroundBlocking";
const std::string utility_blocking =
- "^ThreadPoolSingleThread" + maybe_shared + "UtilityBlocking$";
+ "ThreadPoolSingleThread" + maybe_shared + "UtilityBlocking";
const std::string foreground_blocking =
- "^ThreadPoolSingleThread" + maybe_shared + "ForegroundBlocking$";
+ "ThreadPoolSingleThread" + maybe_shared + "ForegroundBlocking";
const struct {
TaskTraits traits;
@@ -379,9 +379,8 @@
TestWaitableEvent event;
CreateTaskRunner(test_case.traits)
->PostTask(FROM_HERE, BindLambdaForTesting([&] {
- EXPECT_THAT(PlatformThread::GetName(),
- ::testing::MatchesRegex(
- test_case.expected_thread_name));
+ EXPECT_EQ(PlatformThread::GetName(),
+ test_case.expected_thread_name);
event.Signal();
}));
event.Wait();
```
Change information
Commit message:
[task] Remove id from ThreadPoolSingleThread thread name
We don't get value from indexing thread name (this isn't done
for any other threads), and is causing an unbound name leak.
Bug: 509920709
Change-Id: I008744b06c748981b5e86024e933d83f884c2647
Reviewed-by: Gabriel Charette <g...@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etie...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1625778}
Files:
- M base/task/thread_pool/pooled_single_thread_task_runner_manager.cc
- M base/task/thread_pool/pooled_single_thread_task_runner_manager_unittest.cc
Change size: S
Delta: 2 files changed, 10 insertions(+), 11 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Gabriel Charette
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages